9a5886bd8c
Summary: Current implementation of the ```read_options.deadline``` option only checks the deadline for random file reads during point lookups. This PR extends the checks to file opens, prefetches and preloads as part of table open. The main changes are in the ```BlockBasedTable```, partitioned index and filter readers, and ```TableCache``` to take ReadOptions as an additional parameter. In ```BlockBasedTable::Open```, in order to retain existing behavior w.r.t checksum verification and block cache usage, we filter out most of the options in ```ReadOptions``` except ```deadline```. However, having the ```ReadOptions``` gives us more flexibility to honor other options like verify_checksums, fill_cache etc. in the future. Additional changes in callsites due to function signature changes in ```NewTableReader()``` and ```FilePrefetchBuffer```. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6982 Test Plan: Add new unit tests in db_basic_test Reviewed By: riversand963 Differential Revision: D22219515 Pulled By: anand1976 fbshipit-source-id: 8a3b92f4a889808013838603aa3ca35229cd501b
74 lines
2.7 KiB
C++
74 lines
2.7 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#ifndef ROCKSDB_LITE
|
|
#include "table/cuckoo/cuckoo_table_factory.h"
|
|
|
|
#include "db/dbformat.h"
|
|
#include "table/cuckoo/cuckoo_table_builder.h"
|
|
#include "table/cuckoo/cuckoo_table_reader.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
Status CuckooTableFactory::NewTableReader(
|
|
const ReadOptions& /*ro*/, const TableReaderOptions& table_reader_options,
|
|
std::unique_ptr<RandomAccessFileReader>&& file, uint64_t file_size,
|
|
std::unique_ptr<TableReader>* table,
|
|
bool /*prefetch_index_and_filter_in_cache*/) const {
|
|
std::unique_ptr<CuckooTableReader> new_reader(new CuckooTableReader(
|
|
table_reader_options.ioptions, std::move(file), file_size,
|
|
table_reader_options.internal_comparator.user_comparator(), nullptr));
|
|
Status s = new_reader->status();
|
|
if (s.ok()) {
|
|
*table = std::move(new_reader);
|
|
}
|
|
return s;
|
|
}
|
|
|
|
TableBuilder* CuckooTableFactory::NewTableBuilder(
|
|
const TableBuilderOptions& table_builder_options, uint32_t column_family_id,
|
|
WritableFileWriter* file) const {
|
|
// Ignore the skipFIlters flag. Does not apply to this file format
|
|
//
|
|
|
|
// TODO: change builder to take the option struct
|
|
return new CuckooTableBuilder(
|
|
file, table_options_.hash_table_ratio, 64,
|
|
table_options_.max_search_depth,
|
|
table_builder_options.internal_comparator.user_comparator(),
|
|
table_options_.cuckoo_block_size, table_options_.use_module_hash,
|
|
table_options_.identity_as_first_hash, nullptr /* get_slice_hash */,
|
|
column_family_id, table_builder_options.column_family_name,
|
|
table_builder_options.db_id, table_builder_options.db_session_id);
|
|
}
|
|
|
|
std::string CuckooTableFactory::GetPrintableTableOptions() const {
|
|
std::string ret;
|
|
ret.reserve(2000);
|
|
const int kBufferSize = 200;
|
|
char buffer[kBufferSize];
|
|
|
|
snprintf(buffer, kBufferSize, " hash_table_ratio: %lf\n",
|
|
table_options_.hash_table_ratio);
|
|
ret.append(buffer);
|
|
snprintf(buffer, kBufferSize, " max_search_depth: %u\n",
|
|
table_options_.max_search_depth);
|
|
ret.append(buffer);
|
|
snprintf(buffer, kBufferSize, " cuckoo_block_size: %u\n",
|
|
table_options_.cuckoo_block_size);
|
|
ret.append(buffer);
|
|
snprintf(buffer, kBufferSize, " identity_as_first_hash: %d\n",
|
|
table_options_.identity_as_first_hash);
|
|
ret.append(buffer);
|
|
return ret;
|
|
}
|
|
|
|
TableFactory* NewCuckooTableFactory(const CuckooTableOptions& table_options) {
|
|
return new CuckooTableFactory(table_options);
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
#endif // ROCKSDB_LITE
|