andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/tools
History
Sagar Vemuri c94f073e5e Fix Mac build break in casting (#4722) 
Summary:
Mac build is failing with the below error:
```
$ make db_bench -j8
...
...
tools/db_bench_tool.cc:4583:25: error: no matching function for call to 'max'
              (uint64_t)std::max(0l, seek_pos - FLAGS_max_scan_distance),
                        ^~~~~~~~
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/algorithm:2717:1: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('long' vs. 'long long')
max(const _Tp& __a, const _Tp& __b)
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/algorithm:2727:1: note: candidate template ignored: could not match 'initializer_list<type-parameter-0-0>' against 'long'
max(initializer_list<_Tp> __t, _Compare __comp)
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/algorithm:2709:1: note: candidate function template not viable: requires 3 arguments, but 2 were provided
max(const _Tp& __a, const _Tp& __b, _Compare __comp)
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/algorithm:2735:1: note: candidate function template not viable: requires single argument '__t', but 2 arguments were provided
max(initializer_list<_Tp> __t)
^
1 error generated.
make: *** [tools/db_bench_tool.o] Error 1
```

My compiler version:
Mac OS X Mojave
```
$ clang++ --version
Apple LLVM version 10.0.0 (clang-1000.11.45.5)
Target: x86_64-apple-darwin18.2.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
```
Pull Request resolved: https://github.com/facebook/rocksdb/pull/4722

Differential Revision: D13220196

Pulled By: sagar0

fbshipit-source-id: 01e5e928288a5613027c83a26ad8aedf04438b14
2018-11-27 13:30:16 -08:00
..
advisor
Rules Advisor: some fixes to support fetching stats from ODS (#4223)
2018-08-02 15:42:42 -07:00
dump
fix gflags namespace
2017-12-01 10:42:05 -08:00
rdb
Fix /bin/bash shebangs
2017-08-03 15:56:46 -07:00
auto_sanity_test.sh
Suppress lint in old files
2018-01-29 12:56:42 -08:00
benchmark_leveldb.sh
Suppress lint in old files
2018-01-29 12:56:42 -08:00
benchmark.sh
benchmark.sh: to fix divide by zero runtime error (#4442)
2018-10-10 21:03:19 -07:00
blob_dump.cc
comment unused parameters to turn on -Wunused-parameter flag
2018-04-12 17:59:16 -07:00
check_format_compatible.sh
Include newer RocksDB versions in compat test (#4634)
2018-11-06 14:25:39 -08:00
CMakeLists.txt
cmake support for linux and osx (#1358)
2016-09-28 11:53:15 -07:00
db_bench_tool_test.cc
Update all unique/shared_ptr instances to be qualified with namespace std (#4638)
2018-11-09 11:19:58 -08:00
db_bench_tool.cc
Fix Mac build break in casting (#4722)
2018-11-27 13:30:16 -08:00
db_bench.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_crashtest.py
Enable crash-recovery stress test for atomic flush (#4605)
2018-10-30 14:03:36 -07:00
db_repl_stress.cc
Update all unique/shared_ptr instances to be qualified with namespace std (#4638)
2018-11-09 11:19:58 -08:00
db_sanity_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
db_stress.cc
Improve result report of scan (#4648)
2018-11-13 20:03:59 -08:00
dbench_monitor
Fix /bin/bash shebangs
2017-08-03 15:56:46 -07:00
Dockerfile
adding docker build script and dockerfile
2015-05-22 16:03:39 -07:00
generate_random_db.sh
Fix /bin/bash shebangs
2017-08-03 15:56:46 -07:00
ingest_external_sst.sh
Add compatibility test of SST ingestion (#4310)
2018-08-24 14:27:43 -07:00
ldb_cmd_impl.h
Add SST ingestion to ldb (#4205)
2018-08-09 14:29:11 -07:00
ldb_cmd_test.cc
fix memory leak in two_level_iterator
2018-04-15 17:26:26 -07:00
ldb_cmd.cc
Add SstFileReader to read sst files (#4717)
2018-11-27 13:02:23 -08:00
ldb_test.py
Add SST ingestion to ldb (#4205)
2018-08-09 14:29:11 -07:00
ldb_tool.cc
Add SST ingestion to ldb (#4205)
2018-08-09 14:29:11 -07:00
ldb.cc
comment unused parameters to turn on -Wunused-parameter flag
2018-04-12 17:59:16 -07:00
pflag
Fix /bin/bash shebangs
2017-08-03 15:56:46 -07:00
reduce_levels_test.cc
Per-thread unique test db names (#4135)
2018-07-13 17:27:39 -07:00
regression_test.sh
Suppress lint in old files
2018-01-29 12:56:42 -08:00
report_lite_binary_size.sh
Legocastle job to report lite build binary size to scuba
2018-02-15 17:27:24 -08:00
rocksdb_dump_test.sh
Suppress lint in old files
2018-01-29 12:56:42 -08:00
run_flash_bench.sh
Fix /bin/bash shebangs
2017-08-03 15:56:46 -07:00
run_leveldb.sh
Fix /bin/bash shebangs
2017-08-03 15:56:46 -07:00
sample-dump.dmp
First version of rocksdb_dump and rocksdb_undump.
2015-06-19 16:24:36 -07:00
sst_dump_test.cc
Update all unique/shared_ptr instances to be qualified with namespace std (#4638)
2018-11-09 11:19:58 -08:00
sst_dump_tool_imp.h
Add SstFileReader to read sst files (#4717)
2018-11-27 13:02:23 -08:00
sst_dump_tool.cc
Add SstFileReader to read sst files (#4717)
2018-11-27 13:02:23 -08:00
sst_dump.cc
comment unused parameters to turn on -Wunused-parameter flag
2018-04-12 17:59:16 -07:00
trace_analyzer_test.cc
Add the unit test of Iterator to trace_analyzer_test (#4282)
2018-08-23 17:28:32 -07:00
trace_analyzer_tool.cc
Add unique key number changing statistics to Trace_analyzer (#4646)
2018-11-12 08:26:50 -08:00
trace_analyzer_tool.h
Add unique key number changing statistics to Trace_analyzer (#4646)
2018-11-12 08:26:50 -08:00
trace_analyzer.cc
RocksDB Trace Analyzer (#4091)
2018-08-13 11:44:02 -07:00
verify_random_db.sh
tools/check_format_compatible.sh to cover forward option reading too (#3994)
2018-06-15 11:12:29 -07:00
write_external_sst.sh
correct mistyped msg. (#4341)
2018-09-13 14:57:38 -07:00
write_stress_runner.py
Suppress lint in old files
2018-01-29 12:56:42 -08:00
write_stress.cc
Compilation fixes for powerpc build, -Wparentheses-equality error and missing header guards
2018-02-09 14:12:43 -08:00