Zhongyi Xie
9196e80b15
Reduce heavy hitter for Get operation
Summary:
This PR addresses the following heavy hitters in `Get` operation by moving calls to `StatisticsImpl::recordTick` from `BlockBasedTable` to `Version::Get`
- rocksdb.block.cache.bytes.write
- rocksdb.block.cache.add
- rocksdb.block.cache.data.miss
- rocksdb.block.cache.data.bytes.insert
- rocksdb.block.cache.data.add
- rocksdb.block.cache.hit
- rocksdb.block.cache.data.hit
- rocksdb.block.cache.bytes.read
The db_bench statistics before and after the change are:
|1GB block read|Children |Self |Command |Shared Object |Symbol|
|---|---|---|---|---|---|
|master: |4.22% |1.31% |db_bench |db_bench |[.] rocksdb::StatisticsImpl::recordTick|
|updated: |0.51% |0.21% |db_bench |db_bench |[.] rocksdb::StatisticsImpl::recordTick|
| |0.14% |0.14% |db_bench |db_bench |[.] rocksdb::GetContext::record_counters|
|1MB block read|Children |Self |Command |Shared Object |Symbol|
|---|---|---|---|---|---|
|master: |3.48% |1.08% |db_bench |db_bench |[.] rocksdb::StatisticsImpl::recordTick|
|updated: |0.80% |0.31% |db_bench |db_bench |[.] rocksdb::StatisticsImpl::recordTick|
| |0.35% |0.35% |db_bench |db_bench |[.] rocksdb::GetContext::record_counters|
Closes https://github.com/facebook/rocksdb/pull/3172
Differential Revision: D6330532
Pulled By: miasantreble
fbshipit-source-id: 2b492959e00a3db29e9437ecdcc5e48ca4ec5741
2017-12-14 16:52:06 -08:00
..
2017-11-10 09:26:24 -08:00
2017-11-10 09:26:24 -08:00
2017-09-14 14:18:59 -07:00
2017-11-28 14:12:44 -08:00
2017-10-17 11:13:19 -07:00
2017-11-10 09:26:24 -08:00
2017-12-11 13:57:48 -08:00
2017-07-21 18:26:26 -07:00
2017-10-27 11:26:42 -07:00
2017-07-21 18:26:26 -07:00
2017-08-19 14:10:08 -07:00
2017-11-01 18:56:43 -07:00
2017-11-02 17:27:38 -07:00
2017-11-01 18:56:43 -07:00
2017-07-21 18:26:26 -07:00
2017-11-30 23:50:45 -08:00
2017-12-14 16:51:26 -08:00
2017-11-16 17:57:25 -08:00
2017-12-11 13:27:06 -08:00
2017-12-11 13:27:06 -08:00
2017-12-11 13:27:06 -08:00
2017-11-09 17:42:00 -08:00
2017-09-13 15:41:38 -07:00
2017-12-11 13:27:06 -08:00
2017-07-15 16:11:23 -07:00
2017-07-21 18:26:26 -07:00
2017-08-09 15:58:13 -07:00
2017-08-11 12:29:14 -07:00
2017-10-19 10:57:12 -07:00
2017-10-19 10:57:12 -07:00
2017-10-17 08:57:09 -07:00
2017-07-21 18:26:26 -07:00
2017-07-21 18:26:26 -07:00
2017-10-20 15:42:07 -07:00
2017-12-07 11:12:43 -08:00
2017-07-21 18:26:26 -07:00
2017-07-15 16:11:23 -07:00
2017-07-18 11:56:57 -07:00
2017-07-21 18:26:26 -07:00
2017-11-16 17:57:25 -08:00
2017-11-30 23:50:45 -08:00
2017-10-05 18:11:43 -07:00
2017-11-10 17:28:12 -08:00
2017-11-30 23:50:45 -08:00
2017-10-09 17:15:28 -07:00
2017-07-21 18:26:26 -07:00
2017-11-30 23:50:45 -08:00
2017-12-11 13:27:06 -08:00
2017-11-30 23:50:45 -08:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-26 21:11:47 -07:00
2017-11-29 22:56:29 -08:00
2017-12-06 11:56:39 -08:00
2017-10-09 17:15:28 -07:00
2017-11-29 22:56:29 -08:00
2017-07-15 16:11:23 -07:00
2017-07-21 18:26:26 -07:00
2017-12-06 11:56:39 -08:00
2017-11-16 17:57:25 -08:00
2017-10-23 15:27:27 -07:00
2017-08-29 18:41:35 -07:00
2017-11-17 11:58:17 -08:00
2017-07-15 16:11:23 -07:00
2017-09-28 18:17:30 -07:00
2017-07-21 18:26:26 -07:00
2017-11-09 17:42:00 -08:00
2017-11-10 17:28:12 -08:00
2017-11-21 20:11:38 -08:00
2017-12-11 13:27:06 -08:00
2017-12-11 13:27:06 -08:00
2017-11-30 23:50:45 -08:00
2017-11-28 11:42:48 -08:00
2017-07-15 16:11:23 -07:00
2017-11-01 18:56:43 -07:00
2017-12-11 11:57:15 -08:00
2017-07-21 18:26:26 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-28 16:27:16 -07:00
2017-11-28 11:27:02 -08:00
2017-11-30 23:50:45 -08:00
2017-11-28 11:27:02 -08:00
2017-07-21 18:26:26 -07:00
2017-07-21 18:26:26 -07:00
2017-07-21 18:26:26 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-10-06 10:41:53 -07:00
2017-12-14 16:51:26 -08:00
2017-10-06 10:41:53 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-12-01 10:42:05 -08:00
2017-09-21 17:56:38 -07:00
2017-07-21 18:26:26 -07:00
2017-10-27 15:00:05 -07:00
2017-10-23 15:27:27 -07:00
2017-10-05 18:11:43 -07:00
2017-07-21 18:26:26 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-10-19 10:57:12 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-21 18:26:26 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-21 18:26:26 -07:00
2017-07-15 16:11:23 -07:00
2017-10-23 15:27:27 -07:00
2017-10-23 15:27:27 -07:00
2017-11-02 22:28:10 -07:00
2017-11-02 22:28:10 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-08-16 23:42:00 -07:00
2017-08-16 23:42:00 -07:00
2017-07-15 16:11:23 -07:00
2017-07-21 18:26:26 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-21 18:26:26 -07:00
2017-11-30 23:50:45 -08:00
2017-12-01 10:42:05 -08:00
2017-11-28 11:27:02 -08:00
2017-11-28 11:27:02 -08:00
2017-11-28 11:27:02 -08:00
2017-09-11 09:14:48 -07:00
2017-10-10 13:12:37 -07:00
2017-11-30 23:50:45 -08:00
2017-10-18 09:11:50 -07:00
2017-07-15 16:11:23 -07:00
2017-11-02 15:58:27 -07:00
2017-11-16 17:57:25 -08:00
2017-07-15 16:11:23 -07:00
2017-07-21 18:26:26 -07:00
2017-11-01 22:56:17 -07:00
2017-07-21 18:26:26 -07:00
2017-11-10 17:28:12 -08:00
2017-11-10 17:28:12 -08:00
2017-07-15 16:11:23 -07:00
2017-12-07 11:57:36 -08:00
2017-08-24 16:10:54 -07:00
2017-07-15 16:11:23 -07:00
2017-07-21 18:26:26 -07:00
2017-12-07 11:57:36 -08:00
2017-07-21 18:26:26 -07:00
2017-12-14 16:52:06 -08:00
2017-11-30 23:50:45 -08:00
2017-11-30 23:50:45 -08:00
2017-11-10 17:28:12 -08:00
2017-11-10 17:28:12 -08:00
2017-07-15 16:11:23 -07:00
2017-11-11 11:28:37 -08:00
2017-10-19 10:57:12 -07:00
2017-12-07 11:57:36 -08:00
2017-12-06 17:12:27 -08:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-11-28 11:42:48 -08:00
2017-11-30 23:50:45 -08:00