2fdf91a4f8
Summary: Replace manual memory management with std::unique_ptr in a number of places; not exhaustive, but this fixes a few leaks with file handles as well as clarifies semantics of the ownership of file handles with log classes. Test Plan: db_stress, make check Reviewers: dhruba Reviewed By: dhruba CC: zshao, leveldb, heyongqiang Differential Revision: https://reviews.facebook.net/D8043
134 lines
3.9 KiB
C++
134 lines
3.9 KiB
C++
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#include "db/table_cache.h"
|
|
|
|
#include "db/filename.h"
|
|
#include "db/db_statistics.h"
|
|
#include "leveldb/env.h"
|
|
#include "leveldb/table.h"
|
|
#include "util/coding.h"
|
|
|
|
namespace leveldb {
|
|
|
|
struct TableAndFile {
|
|
unique_ptr<RandomAccessFile> file;
|
|
unique_ptr<Table> table;
|
|
};
|
|
|
|
static class DBStatistics* dbstatistics;
|
|
|
|
static void DeleteEntry(const Slice& key, void* value) {
|
|
TableAndFile* tf = reinterpret_cast<TableAndFile*>(value);
|
|
if (dbstatistics) {
|
|
dbstatistics->incNumFileCloses();
|
|
}
|
|
delete tf;
|
|
}
|
|
|
|
static void UnrefEntry(void* arg1, void* arg2) {
|
|
Cache* cache = reinterpret_cast<Cache*>(arg1);
|
|
Cache::Handle* h = reinterpret_cast<Cache::Handle*>(arg2);
|
|
cache->Release(h);
|
|
}
|
|
|
|
TableCache::TableCache(const std::string& dbname,
|
|
const Options* options,
|
|
int entries)
|
|
: env_(options->env),
|
|
dbname_(dbname),
|
|
options_(options),
|
|
cache_(NewLRUCache(entries, options->table_cache_numshardbits)) {
|
|
dbstatistics = (DBStatistics*)options->statistics;
|
|
}
|
|
|
|
TableCache::~TableCache() {
|
|
}
|
|
|
|
Status TableCache::FindTable(uint64_t file_number, uint64_t file_size,
|
|
Cache::Handle** handle, bool* tableIO) {
|
|
Status s;
|
|
char buf[sizeof(file_number)];
|
|
EncodeFixed64(buf, file_number);
|
|
Slice key(buf, sizeof(buf));
|
|
DBStatistics* stats = (DBStatistics*) options_->statistics;
|
|
*handle = cache_->Lookup(key);
|
|
if (*handle == NULL) {
|
|
if (tableIO != NULL) {
|
|
*tableIO = true; // we had to do IO from storage
|
|
}
|
|
std::string fname = TableFileName(dbname_, file_number);
|
|
unique_ptr<RandomAccessFile> file;
|
|
unique_ptr<Table> table;
|
|
s = env_->NewRandomAccessFile(fname, &file);
|
|
stats ? stats->incNumFileOpens() : (void)0;
|
|
if (s.ok()) {
|
|
s = Table::Open(*options_, std::move(file), file_size, &table);
|
|
}
|
|
|
|
if (!s.ok()) {
|
|
assert(table == NULL);
|
|
stats ? stats->incNumFileErrors() : (void)0;
|
|
// We do not cache error results so that if the error is transient,
|
|
// or somebody repairs the file, we recover automatically.
|
|
} else {
|
|
TableAndFile* tf = new TableAndFile;
|
|
tf->file = std::move(file);
|
|
tf->table = std::move(table);
|
|
*handle = cache_->Insert(key, tf, 1, &DeleteEntry);
|
|
}
|
|
}
|
|
return s;
|
|
}
|
|
|
|
Iterator* TableCache::NewIterator(const ReadOptions& options,
|
|
uint64_t file_number,
|
|
uint64_t file_size,
|
|
Table** tableptr) {
|
|
if (tableptr != NULL) {
|
|
*tableptr = NULL;
|
|
}
|
|
|
|
Cache::Handle* handle = NULL;
|
|
Status s = FindTable(file_number, file_size, &handle);
|
|
if (!s.ok()) {
|
|
return NewErrorIterator(s);
|
|
}
|
|
|
|
Table* table =
|
|
reinterpret_cast<TableAndFile*>(cache_->Value(handle))->table.get();
|
|
Iterator* result = table->NewIterator(options);
|
|
result->RegisterCleanup(&UnrefEntry, cache_.get(), handle);
|
|
if (tableptr != NULL) {
|
|
*tableptr = table;
|
|
}
|
|
return result;
|
|
}
|
|
|
|
Status TableCache::Get(const ReadOptions& options,
|
|
uint64_t file_number,
|
|
uint64_t file_size,
|
|
const Slice& k,
|
|
void* arg,
|
|
void (*saver)(void*, const Slice&, const Slice&, bool),
|
|
bool* tableIO) {
|
|
Cache::Handle* handle = NULL;
|
|
Status s = FindTable(file_number, file_size, &handle, tableIO);
|
|
if (s.ok()) {
|
|
Table* t =
|
|
reinterpret_cast<TableAndFile*>(cache_->Value(handle))->table.get();
|
|
s = t->InternalGet(options, k, arg, saver);
|
|
cache_->Release(handle);
|
|
}
|
|
return s;
|
|
}
|
|
|
|
void TableCache::Evict(uint64_t file_number) {
|
|
char buf[sizeof(file_number)];
|
|
EncodeFixed64(buf, file_number);
|
|
cache_->Erase(Slice(buf, sizeof(buf)));
|
|
}
|
|
|
|
} // namespace leveldb
|