bda8d93ba9
Summary: It's always annoying to find a header does not include its own dependencies and only works when included after other includes. This change adds `make check-headers` which validates that each header can be included at the top of a file. Some headers are excluded e.g. because of platform or external dependencies. rocksdb_namespace.h had to be re-worked slightly to enable checking for failure to include it. (ROCKSDB_NAMESPACE is a valid namespace name.) Fixes mostly involve adding and cleaning up #includes, but for FileTraceWriter, a constructor was out-of-lined to make a forward declaration sufficient. This check is not currently run with `make check` but is added to CircleCI build-linux-unity since that one is already relatively fast. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8893 Test Plan: existing tests and resolving issues detected by new check Reviewed By: mrambacher Differential Revision: D30823300 Pulled By: pdillinger fbshipit-source-id: 9fff223944994c83c105e2e6496d24845dc8e572
57 lines
1.4 KiB
C++
57 lines
1.4 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
#pragma once
|
|
|
|
#include <cstdint>
|
|
|
|
#include "rocksdb/rocksdb_namespace.h"
|
|
|
|
#ifndef ROCKSDB_LITE
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
namespace blob_db {
|
|
|
|
/**
|
|
* Statistics related to a single garbage collection pass (i.e. a single
|
|
* (sub)compaction).
|
|
*/
|
|
class BlobDBGarbageCollectionStats {
|
|
public:
|
|
uint64_t AllBlobs() const { return all_blobs_; }
|
|
uint64_t AllBytes() const { return all_bytes_; }
|
|
uint64_t RelocatedBlobs() const { return relocated_blobs_; }
|
|
uint64_t RelocatedBytes() const { return relocated_bytes_; }
|
|
uint64_t NewFiles() const { return new_files_; }
|
|
bool HasError() const { return error_; }
|
|
|
|
void AddBlob(uint64_t size) {
|
|
++all_blobs_;
|
|
all_bytes_ += size;
|
|
}
|
|
|
|
void AddRelocatedBlob(uint64_t size) {
|
|
++relocated_blobs_;
|
|
relocated_bytes_ += size;
|
|
}
|
|
|
|
void AddNewFile() { ++new_files_; }
|
|
|
|
void SetError() { error_ = true; }
|
|
|
|
private:
|
|
uint64_t all_blobs_ = 0;
|
|
uint64_t all_bytes_ = 0;
|
|
uint64_t relocated_blobs_ = 0;
|
|
uint64_t relocated_bytes_ = 0;
|
|
uint64_t new_files_ = 0;
|
|
bool error_ = false;
|
|
};
|
|
|
|
} // namespace blob_db
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
#endif // ROCKSDB_LITE
|