rocksdb/build_tools
mrambacher 493a4e28d9 Pass PLATFORM_FLAGS in build_detect_platform (#8111)
Summary:
At least under MacOS, some things were excluded from the build (like Snappy) because the compilation flags were not passed in correctly.  This PR does a few things:
- Passes the EXTRA_CXX/LDFLAGS into build_detect_platform.  This means that if some tool (like TBB for example) is not installed in a standard place, it could still be detected by build_detect_platform.  In this case, the developer would invoke: "EXTRA_CXXFLAGS=<path to TBB include> EXTRA_LDFLAGS=<path to TBB library> make", and the build script would find the tools in the extra location.
- Changes the compilation tests to use PLATFORM_CXXFLAGS.  This change causes the EXTRA_FLAGS passed in to the script to be included in the compilation check.  Additionally, flags set by the script itself (like --std=c++11) will be used during the checks.

Validated that the make_platform.mk file generated on Linux does not change with this change.  On my MacOS machine, the SNAPPY libraries are now available (they were not before as they required --std=c++11 to build).

I also verified that I can build against TBB installed on my Mac by passing in the EXTRA CXX and LD FLAGS to the location in which TBB is installed.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8111

Reviewed By: jay-zhuang

Differential Revision: D27353516

Pulled By: mrambacher

fbshipit-source-id: b6b378c96dbf678bab1479556dcbcb49c47e807d
2021-03-31 07:40:46 -07:00
..
amalgamate.py Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00
build_detect_platform Pass PLATFORM_FLAGS in build_detect_platform (#8111) 2021-03-31 07:40:46 -07:00
dependencies_4.8.1.sh Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00
dependencies_platform007.sh PosixRandomAccessFile::MultiRead() to use I/O uring if supported (#5881) 2019-12-07 20:55:52 -08:00
dependencies_platform009.sh Still use platform007 for gcc (#7253) 2020-08-13 14:49:34 -07:00
dependencies.sh Update dependencies (#5777) 2019-09-16 20:44:47 -07:00
dockerbuild.sh Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00
error_filter.py Enable txn in crash tests (#6155) 2019-12-11 16:01:55 -08:00
fb_compile_mongo.sh Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00
fbcode_config4.8.1.sh Makefile support for link-time optimization (#7181) 2020-07-28 13:10:44 -07:00
fbcode_config_platform007.sh Makefile support for link-time optimization (#7181) 2020-07-28 13:10:44 -07:00
fbcode_config_platform009.sh Upgrade tool chain (#7251) 2020-08-12 19:30:00 -07:00
fbcode_config.sh Makefile support for link-time optimization (#7181) 2020-07-28 13:10:44 -07:00
format-diff.sh Use actual url instead of tinyurl.com (#7950) 2021-02-10 10:08:09 -08:00
gnu_parallel fix some spelling typos (#6464) 2020-02-28 14:14:03 -08:00
make_package.sh Use standard variables for installing/uninstalling with make (#7187) 2020-08-28 14:47:31 -07:00
precommit_checker.py build_tools/precommit_checker.py: don't hard-code a platform-afflicted python path (#6124) 2019-12-05 11:49:17 -08:00
regression_build_test.sh Don't download from (unreliable) maven.org (#6348) 2020-01-30 11:02:08 -08:00
rocksdb-lego-determinator Add stress crash test with timestamp to lego determinator (#8104) 2021-03-24 17:58:31 -07:00
run_ci_db_test.ps1 Extract test cases correctly in run_ci_db_test.ps1 script (#7989) 2021-02-23 14:25:42 -08:00
setup_centos7.sh Adding new build script for CentOS 7 (#6617) 2020-04-06 16:20:27 -07:00
update_dependencies.sh PosixRandomAccessFile::MultiRead() to use I/O uring if supported (#5881) 2019-12-07 20:55:52 -08:00
version.sh Add copyright headers per FB open-source checkup tool. (#5199) 2019-04-18 10:55:01 -07:00