767777c2bd
Summary: We need to turn on -Wshorten-64-to-32 for mobile. See D1671432 (internal phabricator) for details. This diff turns on the warning flag and fixes all the errors. There were also some interesting errors that I might call bugs, especially in plain table. Going forward, I think it makes sense to have this flag turned on and be very very careful when converting 64-bit to 32-bit variables. Test Plan: compiles Reviewers: ljin, rven, yhchiang, sdong Reviewed By: yhchiang Subscribers: bobbaldwin, dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28689
174 lines
6.0 KiB
C++
174 lines
6.0 KiB
C++
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
#include "db/compaction_picker.h"
|
|
#include <string>
|
|
#include "util/logging.h"
|
|
#include "util/testharness.h"
|
|
#include "util/testutil.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class CountingLogger : public Logger {
|
|
public:
|
|
virtual void Logv(const char* format, va_list ap) override { log_count++; }
|
|
size_t log_count;
|
|
};
|
|
|
|
class CompactionPickerTest {
|
|
public:
|
|
const Comparator* ucmp;
|
|
InternalKeyComparator icmp;
|
|
Options options;
|
|
ImmutableCFOptions ioptions;
|
|
MutableCFOptions mutable_cf_options;
|
|
LevelCompactionPicker level_compaction_picker;
|
|
std::string cf_name;
|
|
CountingLogger logger;
|
|
LogBuffer log_buffer;
|
|
VersionStorageInfo vstorage;
|
|
uint32_t file_num;
|
|
CompactionOptionsFIFO fifo_options;
|
|
std::vector<uint64_t> size_being_compacted;
|
|
|
|
CompactionPickerTest()
|
|
: ucmp(BytewiseComparator()),
|
|
icmp(ucmp),
|
|
ioptions(options),
|
|
mutable_cf_options(options, ioptions),
|
|
level_compaction_picker(ioptions, &icmp),
|
|
cf_name("dummy"),
|
|
log_buffer(InfoLogLevel::INFO_LEVEL, &logger),
|
|
vstorage(&icmp, ucmp, options.num_levels, kCompactionStyleLevel,
|
|
nullptr),
|
|
file_num(1) {
|
|
fifo_options.max_table_files_size = 1;
|
|
mutable_cf_options.RefreshDerivedOptions(ioptions);
|
|
size_being_compacted.resize(options.num_levels);
|
|
}
|
|
|
|
~CompactionPickerTest() {
|
|
for (int i = 0; i < vstorage.num_levels(); i++) {
|
|
for (auto* f : vstorage.LevelFiles(i)) {
|
|
delete f;
|
|
}
|
|
}
|
|
}
|
|
|
|
void Add(int level, uint32_t file_number, const char* smallest,
|
|
const char* largest, uint64_t file_size = 0, uint32_t path_id = 0,
|
|
SequenceNumber smallest_seq = 100,
|
|
SequenceNumber largest_seq = 100) {
|
|
assert(level < vstorage.num_levels());
|
|
FileMetaData* f = new FileMetaData;
|
|
f->fd = FileDescriptor(file_number, path_id, file_size);
|
|
f->smallest = InternalKey(smallest, smallest_seq, kTypeValue);
|
|
f->largest = InternalKey(largest, largest_seq, kTypeValue);
|
|
f->compensated_file_size = file_size;
|
|
f->refs = 0;
|
|
vstorage.MaybeAddFile(level, f);
|
|
}
|
|
|
|
void UpdateVersionStorageInfo() {
|
|
vstorage.ComputeCompactionScore(mutable_cf_options, fifo_options,
|
|
size_being_compacted);
|
|
vstorage.UpdateFilesBySize();
|
|
vstorage.UpdateNumNonEmptyLevels();
|
|
vstorage.GenerateFileIndexer();
|
|
vstorage.GenerateLevelFilesBrief();
|
|
vstorage.SetFinalized();
|
|
}
|
|
};
|
|
|
|
TEST(CompactionPickerTest, Empty) {
|
|
UpdateVersionStorageInfo();
|
|
std::unique_ptr<Compaction> compaction(level_compaction_picker.PickCompaction(
|
|
cf_name, mutable_cf_options, &vstorage, &log_buffer));
|
|
ASSERT_TRUE(compaction.get() == nullptr);
|
|
}
|
|
|
|
TEST(CompactionPickerTest, Single) {
|
|
mutable_cf_options.level0_file_num_compaction_trigger = 2;
|
|
Add(0, 1U, "p", "q");
|
|
UpdateVersionStorageInfo();
|
|
|
|
std::unique_ptr<Compaction> compaction(level_compaction_picker.PickCompaction(
|
|
cf_name, mutable_cf_options, &vstorage, &log_buffer));
|
|
ASSERT_TRUE(compaction.get() == nullptr);
|
|
}
|
|
|
|
TEST(CompactionPickerTest, Level0Trigger) {
|
|
mutable_cf_options.level0_file_num_compaction_trigger = 2;
|
|
Add(0, 1U, "150", "200");
|
|
Add(0, 2U, "200", "250");
|
|
|
|
UpdateVersionStorageInfo();
|
|
|
|
std::unique_ptr<Compaction> compaction(level_compaction_picker.PickCompaction(
|
|
cf_name, mutable_cf_options, &vstorage, &log_buffer));
|
|
ASSERT_TRUE(compaction.get() != nullptr);
|
|
ASSERT_EQ(2U, compaction->num_input_files(0));
|
|
ASSERT_EQ(1U, compaction->input(0, 0)->fd.GetNumber());
|
|
ASSERT_EQ(2U, compaction->input(0, 1)->fd.GetNumber());
|
|
}
|
|
|
|
TEST(CompactionPickerTest, Level1Trigger) {
|
|
Add(1, 66U, "150", "200", 1000000000U);
|
|
UpdateVersionStorageInfo();
|
|
|
|
std::unique_ptr<Compaction> compaction(level_compaction_picker.PickCompaction(
|
|
cf_name, mutable_cf_options, &vstorage, &log_buffer));
|
|
ASSERT_TRUE(compaction.get() != nullptr);
|
|
ASSERT_EQ(1U, compaction->num_input_files(0));
|
|
ASSERT_EQ(66U, compaction->input(0, 0)->fd.GetNumber());
|
|
}
|
|
|
|
TEST(CompactionPickerTest, Level1Trigger2) {
|
|
Add(1, 66U, "150", "200", 1000000001U);
|
|
Add(1, 88U, "201", "300", 1000000000U);
|
|
Add(2, 6U, "150", "179", 1000000000U);
|
|
Add(2, 7U, "180", "220", 1000000000U);
|
|
Add(2, 8U, "221", "300", 1000000000U);
|
|
UpdateVersionStorageInfo();
|
|
|
|
std::unique_ptr<Compaction> compaction(level_compaction_picker.PickCompaction(
|
|
cf_name, mutable_cf_options, &vstorage, &log_buffer));
|
|
ASSERT_TRUE(compaction.get() != nullptr);
|
|
ASSERT_EQ(1U, compaction->num_input_files(0));
|
|
ASSERT_EQ(2U, compaction->num_input_files(1));
|
|
ASSERT_EQ(66U, compaction->input(0, 0)->fd.GetNumber());
|
|
ASSERT_EQ(6U, compaction->input(1, 0)->fd.GetNumber());
|
|
ASSERT_EQ(7U, compaction->input(1, 1)->fd.GetNumber());
|
|
}
|
|
|
|
TEST(CompactionPickerTest, LevelMaxScore) {
|
|
mutable_cf_options.target_file_size_base = 10000000;
|
|
mutable_cf_options.target_file_size_multiplier = 10;
|
|
Add(0, 1U, "150", "200", 1000000000U);
|
|
// Level 1 score 1.2
|
|
Add(1, 66U, "150", "200", 6000000U);
|
|
Add(1, 88U, "201", "300", 6000000U);
|
|
// Level 2 score 1.8. File 7 is the largest. Should be picked
|
|
Add(2, 6U, "150", "179", 60000000U);
|
|
Add(2, 7U, "180", "220", 60000001U);
|
|
Add(2, 8U, "221", "300", 60000000U);
|
|
// Level 3 score slightly larger than 1
|
|
Add(3, 26U, "150", "170", 260000000U);
|
|
Add(3, 27U, "171", "179", 260000000U);
|
|
Add(3, 28U, "191", "220", 260000000U);
|
|
Add(3, 29U, "221", "300", 260000000U);
|
|
UpdateVersionStorageInfo();
|
|
|
|
std::unique_ptr<Compaction> compaction(level_compaction_picker.PickCompaction(
|
|
cf_name, mutable_cf_options, &vstorage, &log_buffer));
|
|
ASSERT_TRUE(compaction.get() != nullptr);
|
|
ASSERT_EQ(1U, compaction->num_input_files(0));
|
|
ASSERT_EQ(7U, compaction->input(0, 0)->fd.GetNumber());
|
|
}
|
|
|
|
} // namespace rocksdb
|
|
|
|
int main(int argc, char** argv) { return rocksdb::test::RunAllTests(); }
|