andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
97ec8a1349
rocksdb/utilities
History
Sagar Vemuri 7124268a09 Reduce the number of params needed to construct DBIter 
Summary:
DBIter, and in-turn NewDBIterator and NewArenaWrappedDBIterator, take a  bunch of params. They can be reduced by passing in ReadOptions directly instead of passing in every new param separately. It also seems much cleaner as a bunch of the params towards the end seem to be optional.

(Recently I introduced max_skippable_internal_keys, which added one more to the already huge count).

Idea courtesy IslamAbdelRahman
Closes https://github.com/facebook/rocksdb/pull/2116

Differential Revision: D4857128

Pulled By: sagar0

fbshipit-source-id: 7d239df094b94bd9ea79d145cdf825478ac037a8
2017-04-10 11:14:14 -07:00
..
backupable Move some files under util/ to separate dirs 2017-04-05 19:09:16 -07:00
blob_db Move some files under util/ to separate dirs 2017-04-05 19:09:16 -07:00
checkpoint Move auto_roll_logger and filename out of db/ 2017-04-03 18:39:14 -07:00
compaction_filters Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
convenience Move auto_roll_logger and filename out of db/ 2017-04-03 18:39:14 -07:00
date_tiered Reduce the number of params needed to construct DBIter 2017-04-10 11:14:14 -07:00
document make all DB::Get overloads virtual 2017-03-30 23:39:14 -07:00
geodb Move auto_roll_logger and filename out of db/ 2017-04-03 18:39:14 -07:00
leveldb_options Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
lua Level-based L0->L0 compaction 2017-04-04 18:09:11 -07:00
memory Disable auto compactions in memory_test and re-enable the test (#1408) 2016-10-19 18:18:42 -07:00
merge_operators Add macros to include file name and line number during Logging 2017-03-15 19:39:12 -07:00
option_change_migration option_change_migration_test: force full compaction when needed 2016-11-15 22:09:34 -08:00
options Move some files under util/ to separate dirs 2017-04-05 19:09:16 -07:00
persistent_cache Move memtable related files into memtable directory 2017-04-06 14:09:13 -07:00
redis Eliminate use of 'using namespace std'. Also remove a number of ADL references to std functions. 2016-05-20 07:42:18 -07:00
simulator_cache Move some files under util/ to separate dirs 2017-04-05 19:09:16 -07:00
spatialdb Remove disableDataSync option 2017-02-13 11:09:13 -08:00
table_properties_collectors Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
transactions Move some files under util/ to separate dirs 2017-04-05 19:09:16 -07:00
ttl Move various string utility functions into string_util 2017-04-06 14:54:12 -07:00
write_batch_with_index Move memtable related files into memtable directory 2017-04-06 14:09:13 -07:00
col_buf_decoder.cc fix non-portable behavior in encoder 2017-01-20 16:39:22 -08:00
col_buf_decoder.h Fix clang build failure and refactor unit test 2016-08-02 15:16:39 -07:00
col_buf_encoder.cc Fix travis (compile for clang < 3.9) 2016-12-01 10:09:22 -08:00
col_buf_encoder.h Fix clang build failure and refactor unit test 2016-08-02 15:16:39 -07:00
column_aware_encoding_exp.cc Fix build on FreeBSD 2017-01-10 11:39:12 -08:00
column_aware_encoding_test.cc Fix clang build failure and refactor unit test 2016-08-02 15:16:39 -07:00
column_aware_encoding_util.cc Fix Windows build issues (#1253) 2016-08-02 17:15:18 -07:00
column_aware_encoding_util.h Move some files under util/ to separate dirs 2017-04-05 19:09:16 -07:00
env_librados_test.cc Move some files under util/ to separate dirs 2017-04-05 19:09:16 -07:00
env_librados.cc change UseDirectIO() to use_direct_io() 2017-01-13 12:09:15 -08:00
env_librados.md Add EnvLibrados - RocksDB Env of RADOS (#1222) 2016-07-21 11:16:34 -07:00
env_mirror_test.cc Move some files under util/ to separate dirs 2017-04-05 19:09:16 -07:00
env_mirror.cc direct io write support 2016-12-22 13:09:19 -08:00
env_timed_test.cc add TimedEnv 2017-04-04 11:24:12 -07:00
env_timed.cc Move some files under util/ to separate dirs 2017-04-05 19:09:16 -07:00
merge_operators.h Introduce FullMergeV2 (eliminate memcpy from merge operators) 2016-07-20 09:49:03 -07:00
object_registry_test.cc Generalize Env registration framework 2017-01-25 16:09:14 -08:00
util_merge_operators_test.cc Introduce FullMergeV2 (eliminate memcpy from merge operators) 2016-07-20 09:49:03 -07:00