9fd6edf81c
Summary: gtest does not use exceptions to fail a unit test by design, and `ASSERT*`s are implemented using `return`. As a consequence we cannot use `ASSERT*` in a function that does not return `void` value ([[ https://code.google.com/p/googletest/wiki/AdvancedGuide#Assertion_Placement | 1]]), and have to fix our existing code. This diff does this in a generic way, with no manual changes. In order to detect all existing `ASSERT*` that are used in functions that doesn't return void value, I change the code to generate compile errors for such cases. In `util/testharness.h` I defined `EXPECT*` assertions, the same way as `ASSERT*`, and redefined `ASSERT*` to return `void`. Then executed: ```lang=bash % USE_CLANG=1 make all -j55 -k 2> build.log % perl -naF: -e 'print "-- -number=".$F[1]." ".$F[0]."\n" if /: error:/' \ build.log | xargs -L 1 perl -spi -e 's/ASSERT/EXPECT/g if $. == $number' % make format ``` After that I reverted back change to `ASSERT*` in `util/testharness.h`. But preserved introduced `EXPECT*`, which is the same as `ASSERT*`. This will be deleted once switched to gtest. This diff is independent and contains manual changes only in `util/testharness.h`. Test Plan: Make sure all tests are passing. ```lang=bash % USE_CLANG=1 make check ``` Reviewers: igor, lgalanis, sdong, yufei.zhu, rven, meyering Reviewed By: meyering Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D33333
124 lines
3.4 KiB
C++
124 lines
3.4 KiB
C++
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
//
|
|
#include "utilities/geodb/geodb_impl.h"
|
|
|
|
#include <cctype>
|
|
#include "util/testharness.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class GeoDBTest {
|
|
public:
|
|
static const std::string kDefaultDbName;
|
|
static Options options;
|
|
DB* db;
|
|
GeoDB* geodb;
|
|
|
|
GeoDBTest() {
|
|
GeoDBOptions geodb_options;
|
|
EXPECT_OK(DestroyDB(kDefaultDbName, options));
|
|
options.create_if_missing = true;
|
|
Status status = DB::Open(options, kDefaultDbName, &db);
|
|
geodb = new GeoDBImpl(db, geodb_options);
|
|
}
|
|
|
|
~GeoDBTest() {
|
|
delete geodb;
|
|
}
|
|
|
|
GeoDB* getdb() {
|
|
return geodb;
|
|
}
|
|
};
|
|
|
|
const std::string GeoDBTest::kDefaultDbName = "/tmp/geodefault";
|
|
Options GeoDBTest::options = Options();
|
|
|
|
// Insert, Get and Remove
|
|
TEST(GeoDBTest, SimpleTest) {
|
|
GeoPosition pos1(100, 101);
|
|
std::string id1("id1");
|
|
std::string value1("value1");
|
|
|
|
// insert first object into database
|
|
GeoObject obj1(pos1, id1, value1);
|
|
Status status = getdb()->Insert(obj1);
|
|
ASSERT_TRUE(status.ok());
|
|
|
|
// insert second object into database
|
|
GeoPosition pos2(200, 201);
|
|
std::string id2("id2");
|
|
std::string value2 = "value2";
|
|
GeoObject obj2(pos2, id2, value2);
|
|
status = getdb()->Insert(obj2);
|
|
ASSERT_TRUE(status.ok());
|
|
|
|
// retrieve first object using position
|
|
std::string value;
|
|
status = getdb()->GetByPosition(pos1, Slice(id1), &value);
|
|
ASSERT_TRUE(status.ok());
|
|
ASSERT_EQ(value, value1);
|
|
|
|
// retrieve first object using id
|
|
GeoObject obj;
|
|
status = getdb()->GetById(Slice(id1), &obj);
|
|
ASSERT_TRUE(status.ok());
|
|
ASSERT_EQ(obj.position.latitude, 100);
|
|
ASSERT_EQ(obj.position.longitude, 101);
|
|
ASSERT_EQ(obj.id.compare(id1), 0);
|
|
ASSERT_EQ(obj.value, value1);
|
|
|
|
// delete first object
|
|
status = getdb()->Remove(Slice(id1));
|
|
ASSERT_TRUE(status.ok());
|
|
status = getdb()->GetByPosition(pos1, Slice(id1), &value);
|
|
ASSERT_TRUE(status.IsNotFound());
|
|
status = getdb()->GetById(id1, &obj);
|
|
ASSERT_TRUE(status.IsNotFound());
|
|
|
|
// check that we can still find second object
|
|
status = getdb()->GetByPosition(pos2, id2, &value);
|
|
ASSERT_TRUE(status.ok());
|
|
ASSERT_EQ(value, value2);
|
|
status = getdb()->GetById(id2, &obj);
|
|
ASSERT_TRUE(status.ok());
|
|
}
|
|
|
|
// Search.
|
|
// Verify distances via http://www.stevemorse.org/nearest/distance.php
|
|
TEST(GeoDBTest, Search) {
|
|
GeoPosition pos1(45, 45);
|
|
std::string id1("mid1");
|
|
std::string value1 = "midvalue1";
|
|
|
|
// insert object at 45 degree latitude
|
|
GeoObject obj1(pos1, id1, value1);
|
|
Status status = getdb()->Insert(obj1);
|
|
ASSERT_TRUE(status.ok());
|
|
|
|
// search all objects centered at 46 degree latitude with
|
|
// a radius of 200 kilometers. We should find the one object that
|
|
// we inserted earlier.
|
|
std::vector<GeoObject> values;
|
|
status = getdb()->SearchRadial(GeoPosition(46, 46), 200000, &values);
|
|
ASSERT_TRUE(status.ok());
|
|
ASSERT_EQ(values.size(), 1U);
|
|
|
|
// search all objects centered at 46 degree latitude with
|
|
// a radius of 2 kilometers. There should be none.
|
|
values.clear();
|
|
status = getdb()->SearchRadial(GeoPosition(46, 46), 2, &values);
|
|
ASSERT_TRUE(status.ok());
|
|
ASSERT_EQ(values.size(), 0U);
|
|
}
|
|
|
|
} // namespace rocksdb
|
|
|
|
int main(int argc, char* argv[]) {
|
|
return rocksdb::test::RunAllTests();
|
|
}
|