9e82540901
Summary: Changing blob file format and some code cleanup around the change. The change with blob log format are: * Remove timestamp field in blob file header, blob file footer and blob records. The field is not being use and often confuse with expiration field. * Blob file header now come with column family id, which always equal to default column family id. It leaves room for future support of column family. * Compression field in blob file header now is a standalone byte (instead of compact encode with flags field) * Blob file footer now come with its own crc. * Key length now being uint64_t instead of uint32_t * Blob CRC now checksum both key and value (instead of value only). * Some reordering of the fields. The list of cleanups: * Better inline comments in blob_log_format.h * rename ttlrange_t and snrange_t to ExpirationRange and SequenceRange respectively. * simplify blob_db::Reader * Move crc checking logic to inside blob_log_format.cc Closes https://github.com/facebook/rocksdb/pull/3081 Differential Revision: D6171304 Pulled By: yiwu-arbug fbshipit-source-id: e4373e0d39264441b7e2fbd0caba93ddd99ea2af
97 lines
2.5 KiB
C++
97 lines
2.5 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
#ifndef ROCKSDB_LITE
|
|
|
|
#include "utilities/blob_db/blob_log_reader.h"
|
|
|
|
#include <algorithm>
|
|
|
|
#include "util/file_reader_writer.h"
|
|
|
|
namespace rocksdb {
|
|
namespace blob_db {
|
|
|
|
Reader::Reader(std::shared_ptr<Logger> info_log,
|
|
unique_ptr<SequentialFileReader>&& _file)
|
|
: info_log_(info_log), file_(std::move(_file)), buffer_(), next_byte_(0) {}
|
|
|
|
Status Reader::ReadSlice(uint64_t size, Slice* slice, std::string* buf) {
|
|
buf->reserve(size);
|
|
Status s = file_->Read(size, slice, &(*buf)[0]);
|
|
next_byte_ += size;
|
|
if (!s.ok()) {
|
|
return s;
|
|
}
|
|
if (slice->size() != size) {
|
|
return Status::Corruption("EOF reached while reading record");
|
|
}
|
|
return s;
|
|
}
|
|
|
|
Status Reader::ReadHeader(BlobLogHeader* header) {
|
|
assert(file_.get() != nullptr);
|
|
assert(next_byte_ == 0);
|
|
Status s = ReadSlice(BlobLogHeader::kSize, &buffer_, &backing_store_);
|
|
if (!s.ok()) {
|
|
return s;
|
|
}
|
|
|
|
if (buffer_.size() != BlobLogHeader::kSize) {
|
|
return Status::Corruption("EOF reached before file header");
|
|
}
|
|
|
|
return header->DecodeFrom(buffer_);
|
|
}
|
|
|
|
Status Reader::ReadRecord(BlobLogRecord* record, ReadLevel level,
|
|
uint64_t* blob_offset) {
|
|
Status s = ReadSlice(BlobLogRecord::kHeaderSize, &buffer_, &backing_store_);
|
|
if (!s.ok()) {
|
|
return s;
|
|
}
|
|
if (buffer_.size() != BlobLogRecord::kHeaderSize) {
|
|
return Status::Corruption("EOF reached before record header");
|
|
}
|
|
|
|
s = record->DecodeHeaderFrom(buffer_);
|
|
if (!s.ok()) {
|
|
return s;
|
|
}
|
|
|
|
uint64_t kb_size = record->key_size + record->value_size;
|
|
if (blob_offset != nullptr) {
|
|
*blob_offset = next_byte_ + record->key_size;
|
|
}
|
|
|
|
switch (level) {
|
|
case kReadHeader:
|
|
file_->Skip(record->key_size + record->value_size);
|
|
next_byte_ += kb_size;
|
|
break;
|
|
|
|
case kReadHeaderKey:
|
|
s = ReadSlice(record->key_size, &record->key, &record->key_buf);
|
|
file_->Skip(record->value_size);
|
|
next_byte_ += record->value_size;
|
|
break;
|
|
|
|
case kReadHeaderKeyBlob:
|
|
s = ReadSlice(record->key_size, &record->key, &record->key_buf);
|
|
if (s.ok()) {
|
|
s = ReadSlice(record->value_size, &record->value, &record->value_buf);
|
|
}
|
|
if (s.ok()) {
|
|
s = record->CheckBlobCRC();
|
|
}
|
|
break;
|
|
}
|
|
return s;
|
|
}
|
|
|
|
} // namespace blob_db
|
|
} // namespace rocksdb
|
|
#endif // ROCKSDB_LITE
|