andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/table
History
Andrew Kryczka 9eca6d651d fix comparison count for format_version=3 indexes (#6650) 
Summary:
In index blocks since `format_version=3`, user keys are written
rather than internal keys. When reading such blocks, the comparator is
obtained via `InternalKeyComparator::user_comparator()`. That function
must not return an unwrapped result as the wrapper class provides
accounting logic to populate `PerfContext::user_key_comparison_count`.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6650

Test Plan:
ran db_bench and verified
`PerfContext::user_key_comparison_count` became larger.

Reviewed By: cheng-chang

Differential Revision: D20866325

Pulled By: ajkr

fbshipit-source-id: ad755d46bda31157dacc5b66e532279f19ad538c
2020-04-13 11:18:37 -07:00
..
adaptive
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
block_based
fix comparison count for format_version=3 indexes (#6650)
2020-04-13 11:18:37 -07:00
cuckoo
Use FileChecksumGenFactory for SST file checksum (#6600)
2020-03-29 15:58:46 -07:00
plain
Move the OptionTypeMap code closer to home (#6198)
2020-04-03 10:52:38 -07:00
block_fetcher.cc
Properly account block_decompress_time (#6658)
2020-04-07 12:53:59 -07:00
block_fetcher.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
cleanable_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
format.cc
Remove memcpy from RandomAccessFileReader::Read in direct IO mode (#6455)
2020-03-06 14:05:12 -08:00
format.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
get_context.cc
return timestamp from get (#6409)
2020-03-02 16:01:00 -08:00
get_context.h
return timestamp from get (#6409)
2020-03-02 16:01:00 -08:00
internal_iterator.h
Iterator with timestamp (#6255)
2020-03-06 16:24:27 -08:00
iter_heap.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
iterator_wrapper.h
Some minor fix-ups (#6440)
2020-02-21 15:09:56 -08:00
iterator.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
merger_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
merging_iterator.cc
Some minor fix-ups (#6440)
2020-02-21 15:09:56 -08:00
merging_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
meta_blocks.cc
Fix range deletion tombstone ingestion with global seqno (#6429)
2020-02-25 15:31:48 -08:00
meta_blocks.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
mock_table.cc
Remove memcpy from RandomAccessFileReader::Read in direct IO mode (#6455)
2020-03-06 14:05:12 -08:00
mock_table.h
Use FileChecksumGenFactory for SST file checksum (#6600)
2020-03-29 15:58:46 -07:00
multiget_context.h
multiget support for timestamps (#6483)
2020-03-24 11:24:09 -07:00
persistent_cache_helper.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
persistent_cache_helper.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
persistent_cache_options.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
scoped_arena_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
sst_file_reader_test.cc
Allow table/sst_file_reader_test.cc to use custom Env (#6536)
2020-03-17 11:02:13 -07:00
sst_file_reader.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
sst_file_writer_collectors.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
sst_file_writer.cc
Make options.bottommost_compression, compression_opts and bottommost_compression_opts dynamically changeable. (#6615)
2020-03-31 12:11:42 -07:00
table_builder.h
In block based table builder, make variables for estimating file size atomic (#6636)
2020-04-02 16:16:24 -07:00
table_properties_internal.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_properties.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_reader_bench.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_reader_caller.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_reader.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_test.cc
Fix msvc debug test failures (#6579)
2020-04-03 09:54:25 -07:00
two_level_iterator.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
two_level_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00