andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
A library that provides an embeddable, persistent key-value store for fast storage.
4,111 Commits 152 Branches 236 Tags 271 MiB
C++ 82.1%
Java 10.3%
C 2.5%
Python 1.7%
Perl 1.1%
Other 2.1%
a263002a36
Go to file
Yueh-Hsuan Chiang a263002a36 Fixed a tsan warning in db_stress.cc 
Summary:
Fixed the following tsan warning in db_stress.cc

  WARNING: ThreadSanitizer: data race (pid=3163194)
  Read of size 8 at 0x7fd1797cb518 by thread T32:
    #0 VerifyDb tools/db_stress.cc:1731 (db_stress+0x000000040674)
    #1 rocksdb::StressTest::ThreadBody(void*) tools/db_stress.cc:1191 (db_stress+0x0000000625a9)
    #2 StartThreadWrapper util/env_posix.cc:1648 (db_stress+0x00000028bbbd)

  Previous write of size 8 at 0x7fd1797cb518 by thread T31:
    #0 VerifyDb tools/db_stress.cc:1726 (db_stress+0x00000004072a)
    #1 rocksdb::StressTest::ThreadBody(void*) tools/db_stress.cc:1191 (db_stress+0x0000000625a9)
    #2 StartThreadWrapper util/env_posix.cc:1648 (db_stress+0x00000028bbbd)

The cause is that in VerifyDb(), the static local const variable long max_key
can be read and written at the same time.  This patch fixed it by making it
non-static.

Test Plan: db_stress

Reviewers: igor, sdong, IslamAbdelRahman, anthony

Reviewed By: anthony

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D47703
2015-09-28 12:06:43 -07:00
arcanist_util Fix linters on non-fb machines 2015-08-11 11:36:12 -07:00
build_tools Minor fix to CI job definition 2015-09-25 14:54:51 -07:00
coverage Fix coverage script 2014-11-03 14:53:00 -08:00
db Override DBImplReadOnly::SyncWAL() to return NotSupported. Previously, calling it caused program abort. 2015-09-25 21:25:30 -07:00
doc Remove seek compaction 2014-06-20 10:23:02 +02:00
examples Fix compact_files_example 2015-08-25 12:29:44 -07:00
hdfs [Cleanup] Remove RandomRWFile 2015-08-12 10:18:59 -07:00
include/rocksdb Fix SingleDelete support in WriteBatchWithIndex 2015-09-25 12:23:07 -07:00
java [RocksJava] Fix test failure of InfoLogLevelTest 2015-09-21 18:26:21 -07:00
port Re-work to support size_t max constant for 32/64-bit. 2015-09-22 10:34:21 -07:00
table Fix the bug of using freed memory introduced by recent plain table reader patch 2015-09-23 16:16:26 -07:00
third-party "make format" against last 10 commits 2015-07-13 13:50:18 -07:00
tools Fixed a tsan warning in db_stress.cc 2015-09-28 12:06:43 -07:00
util Fixed a compile error in util/arena.h 2015-09-28 11:51:32 -07:00
utilities Fix SingleDelete support in WriteBatchWithIndex 2015-09-25 12:23:07 -07:00
.arcconfig Integrate Jenkins with Phabricator 2015-04-07 11:56:29 -07:00
.clang-format A script that automatically reformat affected lines 2014-01-14 12:21:24 -08:00
.gitignore Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
.travis.yml Fix clang-format on Travis 2015-09-18 10:15:02 -07:00
appveyor.yml Add auto-build manifest for appveyor 2015-08-07 15:37:46 -07:00
AUTHORS Add AUTHORS file. Fix #203 2014-09-29 10:52:18 -07:00
CMakeLists.txt Remove ldb HexToString method's usage of sscanf 2015-09-23 14:25:46 -07:00
CONTRIBUTING.md facebook accounts are not required for CLA signers 2014-07-08 05:57:54 -04:00
DUMP_FORMAT.md First version of rocksdb_dump and rocksdb_undump. 2015-06-19 16:24:36 -07:00
HISTORY.md Add experimental DB::AddFile() to plug sst files into empty DB 2015-09-23 12:42:43 -07:00
INSTALL.md Fixed a typo in INSTALL.md 2015-09-03 19:46:09 -07:00
LICENSE Fix copyright year 2014-03-12 12:06:58 -07:00
Makefile Simplifying valgrind testing 2015-09-23 15:08:58 -07:00
PATENTS Update Patent Grant. 2015-04-13 10:33:43 +01:00
README.md Replaced "built on on earlier work" by "built on earlier work" in README.md 2014-09-17 01:16:17 -07:00
ROCKSDB_LITE.md Optimistic Transactions 2015-05-29 14:36:35 -07:00
src.mk Remove ldb HexToString method's usage of sscanf 2015-09-23 14:25:46 -07:00
thirdparty.inc Conditional use of third-party libraries 2015-07-09 14:42:41 -07:00
USERS.md Add Cloudera's blog post to USERS.md 2015-09-02 14:04:51 -07:00
Vagrantfile RocksDB on FreeBSD support 2015-02-26 15:19:17 -08:00
WINDOWS_PORT.md Commit both PR and internal code review changes 2015-07-07 16:58:20 -07:00

README.md

RocksDB: A Persistent Key-Value Store for Flash and RAM Storage

Build Status

RocksDB is developed and maintained by Facebook Database Engineering Team. It is built on earlier work on LevelDB by Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com)

This code is a library that forms the core building block for a fast key value server, especially suited for storing data on flash drives. It has a Log-Structured-Merge-Database (LSM) design with flexible tradeoffs between Write-Amplification-Factor (WAF), Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF). It has multi-threaded compactions, making it specially suitable for storing multiple terabytes of data in a single database.

Start with example usage here: https://github.com/facebook/rocksdb/tree/master/examples

See the github wiki for more explanation.

The public interface is in include/. Callers should not include or rely on the details of any other header files in this package. Those internal APIs may be changed without warning.

Design discussions are conducted in https://www.facebook.com/groups/rocksdb.dev/