andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/table
History
sdong 079e50d2ba Disallow BlockBasedTableBuilder to set status from non-OK (#6776) 
Summary:
There is no systematic mechanism to prevent BlockBasedTableBuilder's status to be set from non-OK to OK. Adding a mechanism to force this will help us prevent failures in the future.

The solution is to only make it possible to set the status code if the status code to set is not OK.

Since the status code passed to CompressAndVerifyBlock() is changed, a mini refactoring is done too so that the output arguments are changed from reference to pointers, based on Google C++ Style.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6776

Test Plan: Run all existing test.

Reviewed By: pdillinger

Differential Revision: D21314382

fbshipit-source-id: 27000c10f1e4c121661e026548d6882066409375
2020-04-30 15:37:03 -07:00
..
adaptive
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
block_based
Disallow BlockBasedTableBuilder to set status from non-OK (#6776)
2020-04-30 15:37:03 -07:00
cuckoo
Pass a timeout to FileSystem for random reads (#6751)
2020-04-30 14:50:39 -07:00
plain
Pass a timeout to FileSystem for random reads (#6751)
2020-04-30 14:50:39 -07:00
block_fetcher_test.cc
Reduce memory copies when fetching and uncompressing blocks from SST files (#6689)
2020-04-24 15:32:56 -07:00
block_fetcher.cc
Pass a timeout to FileSystem for random reads (#6751)
2020-04-30 14:50:39 -07:00
block_fetcher.h
Reduce memory copies when fetching and uncompressing blocks from SST files (#6689)
2020-04-24 15:32:56 -07:00
cleanable_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
format.cc
Pass a timeout to FileSystem for random reads (#6751)
2020-04-30 14:50:39 -07:00
format.h
Basic MultiGet support for partitioned filters (#6757)
2020-04-28 14:49:34 -07:00
get_context.cc
Stats for redundant insertions into block cache (#6681)
2020-04-27 13:20:27 -07:00
get_context.h
Stats for redundant insertions into block cache (#6681)
2020-04-27 13:20:27 -07:00
internal_iterator.h
Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)
2020-04-15 17:40:44 -07:00
iter_heap.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
iterator_wrapper.h
Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)
2020-04-15 17:40:44 -07:00
iterator.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
merger_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
merging_iterator.cc
Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)
2020-04-15 17:40:44 -07:00
merging_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
meta_blocks.cc
Fix range deletion tombstone ingestion with global seqno (#6429)
2020-02-25 15:31:48 -08:00
meta_blocks.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
mock_table.cc
Pass a timeout to FileSystem for random reads (#6751)
2020-04-30 14:50:39 -07:00
mock_table.h
Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)
2020-04-15 17:40:44 -07:00
multiget_context.h
Basic MultiGet support for partitioned filters (#6757)
2020-04-28 14:49:34 -07:00
persistent_cache_helper.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
persistent_cache_helper.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
persistent_cache_options.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
scoped_arena_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
sst_file_reader_test.cc
Allow table/sst_file_reader_test.cc to use custom Env (#6536)
2020-03-17 11:02:13 -07:00
sst_file_reader.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
sst_file_writer_collectors.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
sst_file_writer.cc
Make options.bottommost_compression, compression_opts and bottommost_compression_opts dynamically changeable. (#6615)
2020-03-31 12:11:42 -07:00
table_builder.h
In block based table builder, make variables for estimating file size atomic (#6636)
2020-04-02 16:16:24 -07:00
table_properties_internal.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_properties.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_reader_bench.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_reader_caller.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_reader.h
Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)
2020-04-15 17:40:44 -07:00
table_test.cc
Pass a timeout to FileSystem for random reads (#6751)
2020-04-30 14:50:39 -07:00
two_level_iterator.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
two_level_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00