a0e9ee5965
Summary: This diff adds rapidjson (https://code.google.com/p/rapidjson/) to RocksDB repository. First step to adding JSON is to add a JSON parser :) I'm not sure if rapidjson is the right choice. I only considered folly as an alternative. Using folly JSON parser has serious downsides. I tried extracting folly::json from the folly library. However, it depends on folly::dynamic, which basically depends on everything else. I would prefer to avoid adding complete folly library as RocksDB dependency. Folly has a lot of its own dependencies (https://github.com/facebook/folly) and also looks like open source world has some trouble installing it (https://groups.google.com/forum/#!forum/facebook-folly -- 60% of the posts are compile errors). We can discuss this if you think otherwise. RapidJSON does not have any dependencies whatsoever. No boost, no STL. We don't need to compile it since it's all header files. The performance results are also impressive: https://code.google.com/p/rapidjson/wiki/Performance. However, I'll make sure to write code in a way that we can easily switch JSON implementations going forward. Quora thread has some alternatives: http://www.quora.com/What-is-the-best-C-JSON-library Test Plan: none Reviewers: dhruba, haobo, yhchiang, sdong, jamesgpearce Reviewed By: haobo CC: leveldb Differential Revision: https://reviews.facebook.net/D18729
47 lines
923 B
C++
47 lines
923 B
C++
#ifndef RAPIDJSON_FILESTREAM_H_
|
|
#define RAPIDJSON_FILESTREAM_H_
|
|
|
|
#include <cstdio>
|
|
|
|
namespace rapidjson {
|
|
|
|
//! Wrapper of C file stream for input or output.
|
|
/*!
|
|
This simple wrapper does not check the validity of the stream.
|
|
\implements Stream
|
|
*/
|
|
class FileStream {
|
|
public:
|
|
typedef char Ch; //!< Character type. Only support char.
|
|
|
|
FileStream(FILE* fp) : fp_(fp), count_(0) { Read(); }
|
|
char Peek() const { return current_; }
|
|
char Take() { char c = current_; Read(); return c; }
|
|
size_t Tell() const { return count_; }
|
|
void Put(char c) { fputc(c, fp_); }
|
|
|
|
// Not implemented
|
|
char* PutBegin() { return 0; }
|
|
size_t PutEnd(char*) { return 0; }
|
|
|
|
private:
|
|
void Read() {
|
|
RAPIDJSON_ASSERT(fp_ != 0);
|
|
int c = fgetc(fp_);
|
|
if (c != EOF) {
|
|
current_ = (char)c;
|
|
count_++;
|
|
}
|
|
else
|
|
current_ = '\0';
|
|
}
|
|
|
|
FILE* fp_;
|
|
char current_;
|
|
size_t count_;
|
|
};
|
|
|
|
} // namespace rapidjson
|
|
|
|
#endif // RAPIDJSON_FILESTREAM_H_
|