Hui Xiao
49623f9c8e
Account memory of big memory users in BlockBasedTable in global memory limit (#9748)
Summary:
**Context:**
Through heap profiling, we discovered that `BlockBasedTableReader` objects can accumulate and lead to high memory usage (e.g, `max_open_file = -1`). These memories are currently not saved, not tracked, not constrained and not cache evict-able. As a first step to improve this, similar to https://github.com/facebook/rocksdb/pull/8428, this PR is to track an estimate of `BlockBasedTableReader` object's memory in block cache and fail future creation if the memory usage exceeds the available space of cache at the time of creation.
**Summary:**
- Approximate big memory users (`BlockBasedTable::Rep` and `TableProperties` )' memory usage in addition to the existing estimated ones (filter block/index block/un-compression dictionary)
- Charge all of these memory usages to block cache on `BlockBasedTable::Open()` and release them on `~BlockBasedTable()` as there is no memory usage fluctuation of concern in between
- Refactor on CacheReservationManager (and its call-sites) to add concurrent support for BlockBasedTable used in this PR.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/9748
Test Plan:
- New unit tests
- db bench: `OpenDb` : **-0.52% in ms**
- Setup `./db_bench -benchmarks=fillseq -db=/dev/shm/testdb -disable_auto_compactions=1 -write_buffer_size=1048576`
- Repeated run with pre-change w/o feature and post-change with feature, benchmark `OpenDb`: `./db_bench -benchmarks=readrandom -use_existing_db=1 -db=/dev/shm/testdb -reserve_table_reader_memory=true (remove this when running w/o feature) -file_opening_threads=3 -open_files=-1 -report_open_timing=true| egrep 'OpenDb:'`
#-run | (feature-off) avg milliseconds | std milliseconds | (feature-on) avg milliseconds | std milliseconds | change (%)
-- | -- | -- | -- | -- | --
10 | 11.4018 | 5.95173 | 9.47788 | 1.57538 | -16.87382694
20 | 9.23746 | 0.841053 | 9.32377 | 1.14074 | 0.9343477536
40 | 9.0876 | 0.671129 | 9.35053 | 1.11713 | 2.893283155
80 | 9.72514 | 2.28459 | 9.52013 | 1.0894 | -2.108041632
160 | 9.74677 | 0.991234 | 9.84743 | 1.73396 | 1.032752389
320 | 10.7297 | 5.11555 | 10.547 | 1.97692 | **-1.70275031**
640 | 11.7092 | 2.36565 | 11.7869 | 2.69377 | **0.6635807741**
- db bench on write with cost to cache in WriteBufferManager (just in case this PR's CRM refactoring accidentally slows down anything in WBM) : `fillseq` : **+0.54% in micros/op**
`./db_bench -benchmarks=fillseq -db=/dev/shm/testdb -disable_auto_compactions=1 -cost_write_buffer_to_cache=true -write_buffer_size=10000000000 | egrep 'fillseq'`
#-run | (pre-PR) avg micros/op | std micros/op | (post-PR) avg micros/op | std micros/op | change (%)
-- | -- | -- | -- | -- | --
10 | 6.15 | 0.260187 | 6.289 | 0.371192 | 2.260162602
20 | 7.28025 | 0.465402 | 7.37255 | 0.451256 | 1.267813605
40 | 7.06312 | 0.490654 | 7.13803 | 0.478676 | **1.060579461**
80 | 7.14035 | 0.972831 | 7.14196 | 0.92971 | **0.02254791432**
- filter bench: `bloom filter`: **-0.78% in ms/key**
- ` ./filter_bench -impl=2 -quick -reserve_table_builder_memory=true | grep 'Build avg'`
#-run | (pre-PR) avg ns/key | std ns/key | (post-PR) ns/key | std ns/key | change (%)
-- | -- | -- | -- | -- | --
10 | 26.4369 | 0.442182 | 26.3273 | 0.422919 | **-0.4145720565**
20 | 26.4451 | 0.592787 | 26.1419 | 0.62451 | **-1.1465262**
- Crash test `python3 tools/db_crashtest.py blackbox --reserve_table_reader_memory=1 --cache_size=1` killed as normal
Reviewed By: ajkr
Differential Revision: D35136549
Pulled By: hx235
fbshipit-source-id: 146978858d0f900f43f4eb09bfd3e83195e3be28
2022-04-06 10:33:00 -07:00
..
2022-02-16 23:18:14 -08:00
2022-03-21 16:11:02 -07:00
2022-04-05 12:26:36 -07:00
2022-03-15 09:50:21 -07:00
2021-09-29 04:04:40 -07:00
2022-03-15 14:45:34 -07:00
2021-09-16 17:23:36 -07:00
2022-04-05 09:52:33 -07:00
2022-03-23 10:00:54 -07:00
2021-12-10 08:13:26 -08:00
2022-03-24 13:05:17 -07:00
2022-03-24 13:05:17 -07:00
2022-02-22 12:23:00 -08:00
2021-12-10 08:13:26 -08:00
2022-02-16 23:18:14 -08:00
2022-01-04 16:45:49 -08:00
2021-10-18 23:32:01 -07:00
2022-02-17 16:31:41 -08:00
2022-02-04 14:15:58 -08:00
2022-04-06 10:33:00 -07:00
2022-03-15 12:31:14 -07:00
2022-01-27 13:01:09 -08:00
2022-04-01 16:06:14 -07:00
2022-03-31 20:00:52 -07:00
2022-03-21 12:04:33 -07:00
2021-11-08 11:05:59 -08:00
2022-01-28 13:28:38 -08:00
2022-01-28 13:28:38 -08:00
2021-09-29 04:04:40 -07:00
2022-02-01 22:19:01 -08:00
2021-08-10 11:10:07 -07:00
2022-03-04 11:35:28 -08:00
2022-04-05 12:26:36 -07:00
2022-02-08 19:31:28 -08:00
2022-03-07 18:06:19 -08:00
2022-03-15 09:50:21 -07:00
2022-03-08 13:19:39 -08:00
2022-01-04 16:45:49 -08:00
2022-04-06 10:33:00 -07:00
2021-09-07 13:28:29 -07:00
2022-04-06 10:33:00 -07:00
2022-03-18 16:35:51 -07:00
2022-02-09 12:36:43 -08:00
2022-03-22 10:22:18 -07:00
2022-03-29 14:36:35 -07:00
2021-11-18 17:31:50 -08:00
2022-03-23 19:41:31 -07:00
2022-03-11 16:13:23 -08:00
2022-02-08 12:15:35 -08:00
2021-11-08 11:05:59 -08:00
2021-11-08 11:05:59 -08:00
2021-11-08 11:05:59 -08:00
2021-11-10 10:49:04 -08:00
2022-03-11 16:13:23 -08:00
2021-11-08 11:05:59 -08:00
2022-03-15 14:45:34 -07:00
2022-03-15 14:45:34 -07:00
2022-03-15 14:45:34 -07:00
2022-03-23 19:41:31 -07:00
2021-12-08 14:30:57 -08:00
2022-03-18 16:35:51 -07:00
2021-11-08 11:05:59 -08:00
2022-03-02 17:41:02 -08:00
2021-12-16 17:15:13 -08:00
2022-01-04 16:45:49 -08:00
2021-12-13 09:00:36 -08:00
2022-03-30 15:55:31 -07:00
2022-02-08 12:15:35 -08:00
2022-03-21 16:11:02 -07:00
2022-03-15 14:45:34 -07:00
2022-01-12 09:31:12 -08:00
2022-01-21 11:37:46 -08:00
2022-01-21 11:37:46 -08:00
2022-03-11 16:13:23 -08:00
2022-02-18 18:23:07 -08:00
2021-12-16 17:15:13 -08:00
2022-03-18 16:35:51 -07:00
2021-10-20 13:17:00 -07:00
2022-03-18 16:35:51 -07:00
2021-11-16 10:20:50 -08:00
2022-02-22 12:23:00 -08:00
2022-02-17 16:19:31 -08:00
2022-03-09 15:49:53 -08:00
2022-03-09 15:49:53 -08:00
2022-03-09 15:49:53 -08:00
2022-03-09 15:49:53 -08:00
2022-03-09 15:49:53 -08:00
2021-09-29 04:04:40 -07:00
2021-09-07 11:31:59 -07:00
2022-01-12 09:31:12 -08:00
2022-03-15 14:45:34 -07:00
2022-03-31 20:00:52 -07:00
2022-03-15 14:45:34 -07:00
2022-01-27 14:55:04 -08:00
2022-01-27 14:55:04 -08:00
2021-11-19 17:53:47 -08:00
2021-11-19 17:53:47 -08:00
2021-11-19 17:53:47 -08:00
2022-01-04 16:45:49 -08:00
2021-12-10 11:05:35 -08:00
2021-09-29 04:04:40 -07:00
2021-09-29 04:04:40 -07:00
2022-03-12 11:45:56 -08:00
2022-03-12 11:45:56 -08:00
2021-09-07 11:31:59 -07:00
2022-01-21 11:37:46 -08:00
2021-09-10 10:00:26 -07:00
2021-10-06 07:48:31 -07:00
2021-10-06 07:48:31 -07:00
2021-10-06 07:48:31 -07:00
2021-09-10 10:00:26 -07:00
2022-01-21 11:37:46 -08:00
2021-09-10 10:00:26 -07:00
2022-03-15 09:55:49 -07:00
2022-01-21 11:37:46 -08:00
2021-11-18 11:43:44 -08:00
2021-11-19 11:37:06 -08:00
2021-12-10 11:05:35 -08:00
2021-09-29 04:04:40 -07:00
2022-02-09 12:36:43 -08:00
2022-02-09 12:36:43 -08:00
2022-01-21 11:37:46 -08:00
2022-03-23 19:41:31 -07:00
2021-12-03 14:43:14 -08:00
2022-03-31 20:00:52 -07:00
2022-02-04 08:19:20 -08:00
2022-03-23 19:41:31 -07:00
2022-03-29 14:36:35 -07:00
2022-03-24 13:05:17 -07:00
2022-03-18 16:35:51 -07:00
2021-09-21 09:23:48 -07:00
2022-02-22 14:23:01 -08:00
2022-02-22 14:23:01 -08:00
2022-04-01 10:30:17 -07:00
2022-03-08 13:19:39 -08:00
2022-03-08 13:19:39 -08:00