b4b69e4f77
Summary: Our existing test notation is very similar to what is used in gtest. It makes it easy to adopt what is different. In this diff I modify existing [[ https://code.google.com/p/googletest/wiki/Primer#Test_Fixtures:_Using_the_Same_Data_Configuration_for_Multiple_Te | test fixture ]] classes to inherit from `testing::Test`. Also for unit tests that use fixture class, `TEST` is replaced with `TEST_F` as required in gtest. There are several custom `main` functions in our existing tests. To make this transition easier, I modify all `main` functions to fallow gtest notation. But eventually we can remove them and use implementation of `main` that gtest provides. ```lang=bash % cat ~/transform #!/bin/sh files=$(git ls-files '*test\.cc') for file in $files do if grep -q "rocksdb::test::RunAllTests()" $file then if grep -Eq '^class \w+Test {' $file then perl -pi -e 's/^(class \w+Test) {/${1}: public testing::Test {/g' $file perl -pi -e 's/^(TEST)/${1}_F/g' $file fi perl -pi -e 's/(int main.*\{)/${1}::testing::InitGoogleTest(&argc, argv);/g' $file perl -pi -e 's/rocksdb::test::RunAllTests/RUN_ALL_TESTS/g' $file fi done % sh ~/transform % make format ``` Second iteration of this diff contains only scripted changes. Third iteration contains manual changes to fix last errors and make it compilable. Test Plan: Build and notice no errors. ```lang=bash % USE_CLANG=1 make check -j55 ``` Tests are still testing. Reviewers: meyering, sdong, rven, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D35157
154 lines
4.4 KiB
C++
154 lines
4.4 KiB
C++
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#include "rocksdb/slice_transform.h"
|
|
|
|
#include "rocksdb/db.h"
|
|
#include "rocksdb/env.h"
|
|
#include "rocksdb/filter_policy.h"
|
|
#include "rocksdb/statistics.h"
|
|
#include "rocksdb/table.h"
|
|
#include "util/testharness.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class SliceTransformTest : public testing::Test {};
|
|
|
|
TEST_F(SliceTransformTest, CapPrefixTransform) {
|
|
std::string s;
|
|
s = "abcdefge";
|
|
|
|
unique_ptr<const SliceTransform> transform;
|
|
|
|
transform.reset(NewCappedPrefixTransform(6));
|
|
ASSERT_EQ(transform->Transform(s).ToString(), "abcdef");
|
|
ASSERT_TRUE(transform->SameResultWhenAppended("123456"));
|
|
ASSERT_TRUE(transform->SameResultWhenAppended("1234567"));
|
|
ASSERT_TRUE(!transform->SameResultWhenAppended("12345"));
|
|
|
|
transform.reset(NewCappedPrefixTransform(8));
|
|
ASSERT_EQ(transform->Transform(s).ToString(), "abcdefge");
|
|
|
|
transform.reset(NewCappedPrefixTransform(10));
|
|
ASSERT_EQ(transform->Transform(s).ToString(), "abcdefge");
|
|
|
|
transform.reset(NewCappedPrefixTransform(0));
|
|
ASSERT_EQ(transform->Transform(s).ToString(), "");
|
|
|
|
transform.reset(NewCappedPrefixTransform(0));
|
|
ASSERT_EQ(transform->Transform("").ToString(), "");
|
|
}
|
|
|
|
class SliceTransformDBTest : public testing::Test {
|
|
private:
|
|
std::string dbname_;
|
|
Env* env_;
|
|
DB* db_;
|
|
|
|
public:
|
|
SliceTransformDBTest() : env_(Env::Default()), db_(nullptr) {
|
|
dbname_ = test::TmpDir() + "/slice_transform_db_test";
|
|
EXPECT_OK(DestroyDB(dbname_, last_options_));
|
|
}
|
|
|
|
~SliceTransformDBTest() {
|
|
delete db_;
|
|
EXPECT_OK(DestroyDB(dbname_, last_options_));
|
|
}
|
|
|
|
DB* db() { return db_; }
|
|
|
|
// Return the current option configuration.
|
|
Options* GetOptions() { return &last_options_; }
|
|
|
|
void DestroyAndReopen() {
|
|
// Destroy using last options
|
|
Destroy();
|
|
ASSERT_OK(TryReopen());
|
|
}
|
|
|
|
void Destroy() {
|
|
delete db_;
|
|
db_ = nullptr;
|
|
ASSERT_OK(DestroyDB(dbname_, last_options_));
|
|
}
|
|
|
|
Status TryReopen() {
|
|
delete db_;
|
|
db_ = nullptr;
|
|
last_options_.create_if_missing = true;
|
|
|
|
return DB::Open(last_options_, dbname_, &db_);
|
|
}
|
|
|
|
Options last_options_;
|
|
};
|
|
|
|
namespace {
|
|
uint64_t TestGetTickerCount(const Options& options, Tickers ticker_type) {
|
|
return options.statistics->getTickerCount(ticker_type);
|
|
}
|
|
} // namespace
|
|
|
|
TEST_F(SliceTransformDBTest, CapPrefix) {
|
|
last_options_.prefix_extractor.reset(NewCappedPrefixTransform(8));
|
|
last_options_.statistics = rocksdb::CreateDBStatistics();
|
|
BlockBasedTableOptions bbto;
|
|
bbto.filter_policy.reset(NewBloomFilterPolicy(10, false));
|
|
bbto.whole_key_filtering = false;
|
|
last_options_.table_factory.reset(NewBlockBasedTableFactory(bbto));
|
|
ASSERT_OK(TryReopen());
|
|
|
|
ReadOptions ro;
|
|
FlushOptions fo;
|
|
WriteOptions wo;
|
|
|
|
ASSERT_OK(db()->Put(wo, "barbarbar", "foo"));
|
|
ASSERT_OK(db()->Put(wo, "barbarbar2", "foo2"));
|
|
ASSERT_OK(db()->Put(wo, "foo", "bar"));
|
|
ASSERT_OK(db()->Put(wo, "foo3", "bar3"));
|
|
ASSERT_OK(db()->Flush(fo));
|
|
|
|
unique_ptr<Iterator> iter(db()->NewIterator(ro));
|
|
|
|
iter->Seek("foo");
|
|
ASSERT_OK(iter->status());
|
|
ASSERT_TRUE(iter->Valid());
|
|
ASSERT_EQ(iter->value().ToString(), "bar");
|
|
ASSERT_EQ(TestGetTickerCount(last_options_, BLOOM_FILTER_PREFIX_USEFUL), 0U);
|
|
|
|
iter->Seek("foo2");
|
|
ASSERT_OK(iter->status());
|
|
ASSERT_TRUE(!iter->Valid());
|
|
ASSERT_EQ(TestGetTickerCount(last_options_, BLOOM_FILTER_PREFIX_USEFUL), 1U);
|
|
|
|
iter->Seek("barbarbar");
|
|
ASSERT_OK(iter->status());
|
|
ASSERT_TRUE(iter->Valid());
|
|
ASSERT_EQ(iter->value().ToString(), "foo");
|
|
ASSERT_EQ(TestGetTickerCount(last_options_, BLOOM_FILTER_PREFIX_USEFUL), 1U);
|
|
|
|
iter->Seek("barfoofoo");
|
|
ASSERT_OK(iter->status());
|
|
ASSERT_TRUE(!iter->Valid());
|
|
ASSERT_EQ(TestGetTickerCount(last_options_, BLOOM_FILTER_PREFIX_USEFUL), 2U);
|
|
|
|
iter->Seek("foobarbar");
|
|
ASSERT_OK(iter->status());
|
|
ASSERT_TRUE(!iter->Valid());
|
|
ASSERT_EQ(TestGetTickerCount(last_options_, BLOOM_FILTER_PREFIX_USEFUL), 3U);
|
|
}
|
|
|
|
} // namespace rocksdb
|
|
|
|
int main(int argc, char** argv) {
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
return RUN_ALL_TESTS();
|
|
}
|