bda8d93ba9
Summary: It's always annoying to find a header does not include its own dependencies and only works when included after other includes. This change adds `make check-headers` which validates that each header can be included at the top of a file. Some headers are excluded e.g. because of platform or external dependencies. rocksdb_namespace.h had to be re-worked slightly to enable checking for failure to include it. (ROCKSDB_NAMESPACE is a valid namespace name.) Fixes mostly involve adding and cleaning up #includes, but for FileTraceWriter, a constructor was out-of-lined to make a forward declaration sufficient. This check is not currently run with `make check` but is added to CircleCI build-linux-unity since that one is already relatively fast. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8893 Test Plan: existing tests and resolving issues detected by new check Reviewed By: mrambacher Differential Revision: D30823300 Pulled By: pdillinger fbshipit-source-id: 9fff223944994c83c105e2e6496d24845dc8e572
68 lines
2.3 KiB
C++
68 lines
2.3 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include "db/db_impl/db_impl.h"
|
|
#include "util/set_comparator.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
// During recovery if the memtable is flushed we cannot rely on its help on
|
|
// duplicate key detection and as key insert will not be attempted. This class
|
|
// will be used as a emulator of memtable to tell if insertion of a key/seq
|
|
// would have resulted in duplication.
|
|
class DuplicateDetector {
|
|
public:
|
|
explicit DuplicateDetector(DBImpl* db) : db_(db) {}
|
|
bool IsDuplicateKeySeq(uint32_t cf, const Slice& key, SequenceNumber seq) {
|
|
assert(seq >= batch_seq_);
|
|
if (batch_seq_ != seq) { // it is a new batch
|
|
keys_.clear();
|
|
}
|
|
batch_seq_ = seq;
|
|
CFKeys& cf_keys = keys_[cf];
|
|
if (cf_keys.size() == 0) { // just inserted
|
|
InitWithComp(cf);
|
|
}
|
|
auto it = cf_keys.insert(key);
|
|
if (it.second == false) { // second is false if a element already existed.
|
|
keys_.clear();
|
|
InitWithComp(cf);
|
|
keys_[cf].insert(key);
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
private:
|
|
SequenceNumber batch_seq_ = 0;
|
|
DBImpl* db_;
|
|
using CFKeys = std::set<Slice, SetComparator>;
|
|
std::map<uint32_t, CFKeys> keys_;
|
|
void InitWithComp(const uint32_t cf) {
|
|
auto h = db_->GetColumnFamilyHandle(cf);
|
|
if (!h) {
|
|
// TODO(myabandeh): This is not a concern in MyRocks as drop cf is not
|
|
// implemented yet. When it does, we should return proper error instead
|
|
// of throwing exception.
|
|
ROCKS_LOG_FATAL(
|
|
db_->immutable_db_options().info_log,
|
|
"Recovering an entry from the dropped column family %" PRIu32
|
|
". WAL must must have been emptied before dropping the column "
|
|
"family", cf);
|
|
#ifndef ROCKSDB_LITE
|
|
throw std::runtime_error(
|
|
"Recovering an entry from a dropped column family. "
|
|
"WAL must must have been flushed before dropping the column "
|
|
"family");
|
|
#endif
|
|
return;
|
|
}
|
|
auto cmp = h->GetComparator();
|
|
keys_[cf] = CFKeys(SetComparator(cmp));
|
|
}
|
|
};
|
|
} // namespace ROCKSDB_NAMESPACE
|