64b6452e0c
Summary: Merging iterator invokes InternalKeyComparator.Compare() frequently to heap merge. By making InternalKeyComparator final and merging iterator to directly use InternalKeyComparator rather than through Iterator interface, we can give compiler a choice to avoid one more virtual function call if possible. I ran readseq benchmark in memory-only use case to make sure the performance at least doesn't regress. I have to disable the final key word in debug build, as a hack test class depends on overriding the class. Closes https://github.com/facebook/rocksdb/pull/2860 Differential Revision: D5800461 Pulled By: siying fbshipit-source-id: ab876f22a09bb5c560740911412336e0e25ccb53
43 lines
1.2 KiB
C++
43 lines
1.2 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
|
|
#pragma once
|
|
|
|
#include "db/dbformat.h"
|
|
#include "table/iterator_wrapper.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
// When used with std::priority_queue, this comparison functor puts the
|
|
// iterator with the max/largest key on top.
|
|
class MaxIteratorComparator {
|
|
public:
|
|
MaxIteratorComparator(const InternalKeyComparator* comparator)
|
|
: comparator_(comparator) {}
|
|
|
|
bool operator()(IteratorWrapper* a, IteratorWrapper* b) const {
|
|
return comparator_->Compare(a->key(), b->key()) < 0;
|
|
}
|
|
private:
|
|
const InternalKeyComparator* comparator_;
|
|
};
|
|
|
|
// When used with std::priority_queue, this comparison functor puts the
|
|
// iterator with the min/smallest key on top.
|
|
class MinIteratorComparator {
|
|
public:
|
|
MinIteratorComparator(const InternalKeyComparator* comparator)
|
|
: comparator_(comparator) {}
|
|
|
|
bool operator()(IteratorWrapper* a, IteratorWrapper* b) const {
|
|
return comparator_->Compare(a->key(), b->key()) > 0;
|
|
}
|
|
private:
|
|
const InternalKeyComparator* comparator_;
|
|
};
|
|
|
|
} // namespace rocksdb
|