e089db40f9
Summary:
When Get() or NewIterator() trigger file loads, skip caching the filter block if
(1) optimize_filters_for_hits is set and (2) the file is on the bottommost
level. Also skip checking filters under the same conditions, which means that
for a preloaded file or a file that was trivially-moved to the bottom level, its
filter block will eventually expire from the cache.
- added parameters/instance variables in various places in order to propagate the config ("skip_filters") from version_set to block_based_table_reader
- in BlockBasedTable::Rep, this optimization prevents filter from being loaded when the file is opened simply by setting filter_policy = nullptr
- in BlockBasedTable::Get/BlockBasedTable::NewIterator, this optimization prevents filter from being used (even if it was loaded already) by setting filter = nullptr
Test Plan:
updated unit test:
$ ./db_test --gtest_filter=DBTest.OptimizeFiltersForHits
will also run 'make check'
Reviewers: sdong, igor, paultuckfield, anthony, rven, kradhakrishnan, IslamAbdelRahman, yhchiang
Reviewed By: yhchiang
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D51633
85 lines
2.8 KiB
C++
85 lines
2.8 KiB
C++
// Copyright (c) 2014, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#pragma once
|
|
#ifndef ROCKSDB_LITE
|
|
#include <string>
|
|
#include <memory>
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
#include "db/dbformat.h"
|
|
#include "rocksdb/env.h"
|
|
#include "rocksdb/options.h"
|
|
#include "table/table_reader.h"
|
|
#include "util/file_reader_writer.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class Arena;
|
|
class TableReader;
|
|
class InternalIterator;
|
|
|
|
class CuckooTableReader: public TableReader {
|
|
public:
|
|
CuckooTableReader(const ImmutableCFOptions& ioptions,
|
|
std::unique_ptr<RandomAccessFileReader>&& file,
|
|
uint64_t file_size, const Comparator* user_comparator,
|
|
uint64_t (*get_slice_hash)(const Slice&, uint32_t,
|
|
uint64_t));
|
|
~CuckooTableReader() {}
|
|
|
|
std::shared_ptr<const TableProperties> GetTableProperties() const override {
|
|
return table_props_;
|
|
}
|
|
|
|
Status status() const { return status_; }
|
|
|
|
Status Get(const ReadOptions& read_options, const Slice& key,
|
|
GetContext* get_context, bool skip_filters = false) override;
|
|
|
|
InternalIterator* NewIterator(const ReadOptions&, Arena* arena = nullptr,
|
|
bool skip_filters = false) override;
|
|
void Prepare(const Slice& target) override;
|
|
|
|
// Report an approximation of how much memory has been used.
|
|
size_t ApproximateMemoryUsage() const override;
|
|
|
|
// Following methods are not implemented for Cuckoo Table Reader
|
|
uint64_t ApproximateOffsetOf(const Slice& key) override { return 0; }
|
|
void SetupForCompaction() override {}
|
|
// End of methods not implemented.
|
|
|
|
private:
|
|
friend class CuckooTableIterator;
|
|
void LoadAllKeys(std::vector<std::pair<Slice, uint32_t>>* key_to_bucket_id);
|
|
std::unique_ptr<RandomAccessFileReader> file_;
|
|
Slice file_data_;
|
|
bool is_last_level_;
|
|
bool identity_as_first_hash_;
|
|
bool use_module_hash_;
|
|
std::shared_ptr<const TableProperties> table_props_;
|
|
Status status_;
|
|
uint32_t num_hash_func_;
|
|
std::string unused_key_;
|
|
uint32_t key_length_;
|
|
uint32_t user_key_length_;
|
|
uint32_t value_length_;
|
|
uint32_t bucket_length_;
|
|
uint32_t cuckoo_block_size_;
|
|
uint32_t cuckoo_block_bytes_minus_one_;
|
|
uint64_t table_size_;
|
|
const Comparator* ucomp_;
|
|
uint64_t (*get_slice_hash_)(const Slice& s, uint32_t index,
|
|
uint64_t max_num_buckets);
|
|
};
|
|
|
|
} // namespace rocksdb
|
|
#endif // ROCKSDB_LITE
|