c6d464a9da
Summary: I have manually audited the entire RocksJava code base. Sorry for the large pull-request, I have broken it down into many small atomic commits though. My initial intention was to fix the warnings that appear when running RocksJava on Java 8 with `-Xcheck:jni`, for example when running `make jtest` you would see many errors similar to: ``` WARNING in native method: JNI call made without checking exceptions when required to from CallObjectMethod WARNING in native method: JNI call made without checking exceptions when required to from CallVoidMethod WARNING in native method: JNI call made without checking exceptions when required to from CallStaticVoidMethod ... ``` A few of those warnings still remain, however they seem to come directly from the JVM and are not directly related to RocksJava; I am in contact with the OpenJDK hostpot-dev mailing list about these - http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-February/025981.html. As a result of fixing these, I realised we were not r Closes https://github.com/facebook/rocksdb/pull/1890 Differential Revision: D4591758 Pulled By: siying fbshipit-source-id: 7f7fdf4
159 lines
4.3 KiB
C++
159 lines
4.3 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
// This file implements the "bridge" between Java and C++ and enables
|
|
// calling c++ rocksdb::Iterator methods from Java side.
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <jni.h>
|
|
|
|
#include "include/org_rocksdb_RocksIterator.h"
|
|
#include "rocksjni/portal.h"
|
|
#include "rocksdb/iterator.h"
|
|
|
|
/*
|
|
* Class: org_rocksdb_RocksIterator
|
|
* Method: disposeInternal
|
|
* Signature: (J)V
|
|
*/
|
|
void Java_org_rocksdb_RocksIterator_disposeInternal(
|
|
JNIEnv* env, jobject jobj, jlong handle) {
|
|
auto* it = reinterpret_cast<rocksdb::Iterator*>(handle);
|
|
assert(it != nullptr);
|
|
delete it;
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RocksIterator
|
|
* Method: isValid0
|
|
* Signature: (J)Z
|
|
*/
|
|
jboolean Java_org_rocksdb_RocksIterator_isValid0(
|
|
JNIEnv* env, jobject jobj, jlong handle) {
|
|
return reinterpret_cast<rocksdb::Iterator*>(handle)->Valid();
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RocksIterator
|
|
* Method: seekToFirst0
|
|
* Signature: (J)V
|
|
*/
|
|
void Java_org_rocksdb_RocksIterator_seekToFirst0(
|
|
JNIEnv* env, jobject jobj, jlong handle) {
|
|
reinterpret_cast<rocksdb::Iterator*>(handle)->SeekToFirst();
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RocksIterator
|
|
* Method: seekToLast0
|
|
* Signature: (J)V
|
|
*/
|
|
void Java_org_rocksdb_RocksIterator_seekToLast0(
|
|
JNIEnv* env, jobject jobj, jlong handle) {
|
|
reinterpret_cast<rocksdb::Iterator*>(handle)->SeekToLast();
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RocksIterator
|
|
* Method: next0
|
|
* Signature: (J)V
|
|
*/
|
|
void Java_org_rocksdb_RocksIterator_next0(
|
|
JNIEnv* env, jobject jobj, jlong handle) {
|
|
reinterpret_cast<rocksdb::Iterator*>(handle)->Next();
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RocksIterator
|
|
* Method: prev0
|
|
* Signature: (J)V
|
|
*/
|
|
void Java_org_rocksdb_RocksIterator_prev0(
|
|
JNIEnv* env, jobject jobj, jlong handle) {
|
|
reinterpret_cast<rocksdb::Iterator*>(handle)->Prev();
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RocksIterator
|
|
* Method: seek0
|
|
* Signature: (J[BI)V
|
|
*/
|
|
void Java_org_rocksdb_RocksIterator_seek0(
|
|
JNIEnv* env, jobject jobj, jlong handle,
|
|
jbyteArray jtarget, jint jtarget_len) {
|
|
jbyte* target = env->GetByteArrayElements(jtarget, nullptr);
|
|
if(target == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
return;
|
|
}
|
|
|
|
rocksdb::Slice target_slice(
|
|
reinterpret_cast<char*>(target), jtarget_len);
|
|
|
|
auto* it = reinterpret_cast<rocksdb::Iterator*>(handle);
|
|
it->Seek(target_slice);
|
|
|
|
env->ReleaseByteArrayElements(jtarget, target, JNI_ABORT);
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RocksIterator
|
|
* Method: status0
|
|
* Signature: (J)V
|
|
*/
|
|
void Java_org_rocksdb_RocksIterator_status0(
|
|
JNIEnv* env, jobject jobj, jlong handle) {
|
|
auto* it = reinterpret_cast<rocksdb::Iterator*>(handle);
|
|
rocksdb::Status s = it->status();
|
|
|
|
if (s.ok()) {
|
|
return;
|
|
}
|
|
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RocksIterator
|
|
* Method: key0
|
|
* Signature: (J)[B
|
|
*/
|
|
jbyteArray Java_org_rocksdb_RocksIterator_key0(
|
|
JNIEnv* env, jobject jobj, jlong handle) {
|
|
auto* it = reinterpret_cast<rocksdb::Iterator*>(handle);
|
|
rocksdb::Slice key_slice = it->key();
|
|
|
|
jbyteArray jkey = env->NewByteArray(static_cast<jsize>(key_slice.size()));
|
|
if(jkey == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
return nullptr;
|
|
}
|
|
env->SetByteArrayRegion(jkey, 0, static_cast<jsize>(key_slice.size()),
|
|
reinterpret_cast<const jbyte*>(key_slice.data()));
|
|
return jkey;
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RocksIterator
|
|
* Method: value0
|
|
* Signature: (J)[B
|
|
*/
|
|
jbyteArray Java_org_rocksdb_RocksIterator_value0(
|
|
JNIEnv* env, jobject jobj, jlong handle) {
|
|
auto* it = reinterpret_cast<rocksdb::Iterator*>(handle);
|
|
rocksdb::Slice value_slice = it->value();
|
|
|
|
jbyteArray jkeyValue =
|
|
env->NewByteArray(static_cast<jsize>(value_slice.size()));
|
|
if(jkeyValue == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
return nullptr;
|
|
}
|
|
env->SetByteArrayRegion(jkeyValue, 0, static_cast<jsize>(value_slice.size()),
|
|
reinterpret_cast<const jbyte*>(value_slice.data()));
|
|
return jkeyValue;
|
|
}
|