andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/table
History
Cheng Chang bcb9e41080 Explicitly free allocated buffer when status is not ok (#6903) 
Summary:
Currently we rely on `BlockContents` to implicitly free the allocated scratch buffer, but when IO error happens, it doesn't make sense to construct the `BlockContents` which might be corrupted. In the stress test, we find that `assert(req.result.size() == block_size(handle));` fails because of potential IO errors.

In this PR, we explicitly free the scratch buffer on error without constructing `BlockContents`.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6903

Test Plan: watch stress test

Reviewed By: anand1976

Differential Revision: D21823869

Pulled By: cheng-chang

fbshipit-source-id: 5603fc80e9bf3f44a9d7250ddebd871afe1eb89f
2020-06-01 15:19:40 -07:00
..
adaptive
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
block_based
Explicitly free allocated buffer when status is not ok (#6903)
2020-06-01 15:19:40 -07:00
cuckoo
Pass a timeout to FileSystem for random reads (#6751)
2020-04-30 14:50:39 -07:00
plain
Add Struct Type to OptionsTypeInfo (#6425)
2020-05-21 10:58:39 -07:00
block_fetcher_test.cc
skip direct I/O tests in rocksdb lite (#6867)
2020-05-21 13:57:17 -07:00
block_fetcher.cc
Pass a timeout to FileSystem for random reads (#6751)
2020-04-30 14:50:39 -07:00
block_fetcher.h
Reduce memory copies when fetching and uncompressing blocks from SST files (#6689)
2020-04-24 15:32:56 -07:00
cleanable_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
format.cc
Add tests for compression failure in BlockBasedTableBuilder (#6709)
2020-05-12 09:27:35 -07:00
format.h
Basic MultiGet support for partitioned filters (#6757)
2020-04-28 14:49:34 -07:00
get_context.cc
Add timestamp to delete (#6253)
2020-05-28 10:40:03 -07:00
get_context.h
Stats for redundant insertions into block cache (#6681)
2020-04-27 13:20:27 -07:00
internal_iterator.h
Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)
2020-04-15 17:40:44 -07:00
iter_heap.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
iterator_wrapper.h
Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)
2020-04-15 17:40:44 -07:00
iterator.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
merger_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
merging_iterator.cc
Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)
2020-04-15 17:40:44 -07:00
merging_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
meta_blocks.cc
sst_dump to reduce number of file reads (#6836)
2020-05-12 18:23:33 -07:00
meta_blocks.h
sst_dump to reduce number of file reads (#6836)
2020-05-12 18:23:33 -07:00
mock_table.cc
Pass a timeout to FileSystem for random reads (#6751)
2020-04-30 14:50:39 -07:00
mock_table.h
Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)
2020-04-15 17:40:44 -07:00
multiget_context.h
Allow MultiGet users to limit cumulative value size (#6826)
2020-05-27 13:07:14 -07:00
persistent_cache_helper.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
persistent_cache_helper.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
persistent_cache_options.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
scoped_arena_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
sst_file_reader_test.cc
Allow table/sst_file_reader_test.cc to use custom Env (#6536)
2020-03-17 11:02:13 -07:00
sst_file_reader.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
sst_file_writer_collectors.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
sst_file_writer.cc
Generate file checksum in SstFileWriter (#6859)
2020-05-20 11:55:31 -07:00
table_builder.h
sst_dump to reduce number of file reads (#6836)
2020-05-12 18:23:33 -07:00
table_properties_internal.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_properties.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_reader_bench.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_reader_caller.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
table_reader.h
Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)
2020-04-15 17:40:44 -07:00
table_test.cc
Clean up some code related to file checksums (#6861)
2020-05-21 08:12:51 -07:00
two_level_iterator.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
two_level_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00