52d8347a91
Summary:
Here's my proposal for making our LOGs easier to read by machines.
The idea is to dump all events as JSON objects. JSON is easy to read by humans, but more importantly, it's easy to read by machines. That way, we can parse this, load into SQLite/mongo and then query or visualize.
I started with table_create and table_delete events, but if everybody agrees, I'll continue by adding more events (flush/compaction/etc etc)
Test Plan:
Ran db_bench. Observed:
2015/01/15-14:13:25.788019 1105ef000 EVENT_LOG_v1 {"time_micros": 1421360005788015, "event": "table_file_creation", "file_number": 12, "file_size": 1909699}
2015/01/15-14:13:25.956500 110740000 EVENT_LOG_v1 {"time_micros": 1421360005956498, "event": "table_file_deletion", "file_number": 12}
Reviewers: yhchiang, rven, dhruba, MarkCallaghan, lgalanis, sdong
Reviewed By: sdong
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D31647
43 lines
1.2 KiB
C++
43 lines
1.2 KiB
C++
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
#include <string>
|
|
|
|
#include "util/event_logger.h"
|
|
#include "util/testharness.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class EventLoggerTest {};
|
|
|
|
class StringLogger : public Logger {
|
|
public:
|
|
using Logger::Logv;
|
|
virtual void Logv(const char* format, va_list ap) override {
|
|
vsnprintf(buffer_, sizeof(buffer_), format, ap);
|
|
}
|
|
char* buffer() { return buffer_; }
|
|
|
|
private:
|
|
char buffer_[1000];
|
|
};
|
|
|
|
TEST(EventLoggerTest, SimpleTest) {
|
|
StringLogger logger;
|
|
EventLogger event_logger(&logger);
|
|
event_logger.Log() << "id" << 5 << "event"
|
|
<< "just_testing";
|
|
std::string output(logger.buffer());
|
|
ASSERT_TRUE(output.find("\"event\": \"just_testing\"") != std::string::npos);
|
|
ASSERT_TRUE(output.find("\"id\": 5") != std::string::npos);
|
|
ASSERT_TRUE(output.find("\"time_micros\"") != std::string::npos);
|
|
}
|
|
|
|
} // namespace rocksdb
|
|
|
|
int main(int argc, char** argv) {
|
|
return rocksdb::test::RunAllTests();
|
|
}
|