andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
c1bb32e1ba
rocksdb/db
History
Dhruba Borthakur c1bb32e1ba Trigger read compaction only if seeks to storage are incurred. 
Summary:
In the current code, a Get() call can trigger compaction if it has to look at more than one file. This causes unnecessary compaction because looking at more than one file is a penalty only if the file is not yet in the cache. Also, th current code counts these files before the bloom filter check is applied.

This patch counts a 'seek' only if the file fails the bloom filter
check and has to read in data block(s) from the storage.

This patch also counts a 'seek' if a file is not present in the file-cache, because opening a file means that its index blocks need to be read into cache.

Test Plan: unit test attached. I will probably add one more unti tests.

Reviewers: heyongqiang

Reviewed By: heyongqiang

CC: MarkCallaghan

Differential Revision: https://reviews.facebook.net/D5709
2012-09-28 11:10:52 -07:00
..
builder.cc Introduce a new method Env->Fsync() that issues fsync (instead of fdatasync). 2012-08-27 21:24:17 -07:00
builder.h A number of fixes: 2011-10-31 17:22:06 +00:00
c_test.c merge 1.5 2012-08-28 11:43:33 -07:00
c.cc put log in a seperate dir 2012-09-06 17:52:08 -07:00
corruption_test.cc Make some variables configurable for each db instance 2012-06-27 14:36:31 -07:00
db_bench.cc add an option to disable seek compaction 2012-09-17 13:59:57 -07:00
db_filesnapshot.cc The BackupAPI should also list the length of the manifest file. 2012-09-25 03:13:25 -07:00
db_impl.cc If ReadCompaction is switched off, then it is better to not even submit background compaction jobs. 2012-09-25 11:07:01 -07:00
db_impl.h The BackupAPI should also list the length of the manifest file. 2012-09-25 03:13:25 -07:00
db_iter.cc A number of fixes: 2011-10-31 17:22:06 +00:00
db_iter.h A number of fixes: 2011-10-31 17:22:06 +00:00
db_statistics.h Fix table-cache size bug, gather table-cache statistics and prevent readahead done by fs. Summary: 2012-05-30 16:42:45 -07:00
db_stats_logger.cc remove boost 2012-09-16 19:33:43 -07:00
db_test.cc Trigger read compaction only if seeks to storage are incurred. 2012-09-28 11:10:52 -07:00
dbformat_test.cc A number of fixes: 2011-10-31 17:22:06 +00:00
dbformat.cc Added bloom filter support. 2012-04-17 08:36:46 -07:00
dbformat.h Make some variables configurable for each db instance 2012-06-27 14:36:31 -07:00
filename_test.cc A number of fixes: 2011-10-31 17:22:06 +00:00
filename.cc put log in a seperate dir 2012-09-06 17:52:08 -07:00
filename.h put log in a seperate dir 2012-09-06 17:52:08 -07:00
log_format.h A number of fixes: 2011-10-31 17:22:06 +00:00
log_reader.cc A number of fixes: 2011-10-31 17:22:06 +00:00
log_reader.h A number of fixes: 2011-10-31 17:22:06 +00:00
log_test.cc A number of fixes: 2011-10-31 17:22:06 +00:00
log_writer.cc A number of fixes: 2011-10-31 17:22:06 +00:00
log_writer.h A number of fixes: 2011-10-31 17:22:06 +00:00
memtable.cc A number of fixes: 2011-10-31 17:22:06 +00:00
memtable.h A number of fixes: 2011-10-31 17:22:06 +00:00
repair.cc Make some variables configurable for each db instance 2012-06-27 14:36:31 -07:00
skiplist_test.cc A number of fixes: 2011-10-31 17:22:06 +00:00
skiplist.h skiplist: optimize for sequential insert pattern 2012-05-11 09:57:40 -07:00
snapshot.h A number of fixes: 2011-10-31 17:22:06 +00:00
table_cache.cc Trigger read compaction only if seeks to storage are incurred. 2012-09-28 11:10:52 -07:00
table_cache.h Trigger read compaction only if seeks to storage are incurred. 2012-09-28 11:10:52 -07:00
version_edit_test.cc Make some variables configurable for each db instance 2012-06-27 14:36:31 -07:00
version_edit.cc Clean up compiler warnings generated by -Wall option. 2012-08-29 14:24:51 -07:00
version_edit.h Make some variables configurable for each db instance 2012-06-27 14:36:31 -07:00
version_set_test.cc A number of fixes: 2011-10-31 17:22:06 +00:00
version_set.cc Trigger read compaction only if seeks to storage are incurred. 2012-09-28 11:10:52 -07:00
version_set.h The BackupAPI should also list the length of the manifest file. 2012-09-25 03:13:25 -07:00
write_batch_internal.h added group commit; drastically speeds up mult-threaded synchronous write workloads 2012-03-08 16:23:21 -08:00
write_batch_test.cc added group commit; drastically speeds up mult-threaded synchronous write workloads 2012-03-08 16:23:21 -08:00
write_batch.cc added group commit; drastically speeds up mult-threaded synchronous write workloads 2012-03-08 16:23:21 -08:00