andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/table
History
Jim Meyering 9283c7afd2 build: remove always-true assertions 
Summary:
Remove some always-true assertions.
They provoke these compilation failures:

  table/plain_table_key_coding.cc:279:20: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
  db/version_set.cc:336:15: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]

* table/plain_table_key_coding.cc (rocksdb): Remove assertion that
unsigned type variable is >= 0.
* db/version_set.cc (DoGenerateLevelFilesBrief): Likewise.

Test Plan:
  Run "make EXTRA_CXXFLAGS='-W -Wextra'" and see fewer errors.

Reviewers: ljin, sdong, igor.sugak, igor

Reviewed By: igor

Subscribers: dhruba

Differential Revision: https://reviews.facebook.net/D33747
2015-02-20 11:07:03 -08:00
..
adaptive_table_factory.cc
introduce ImmutableOptions
2014-09-04 16:18:36 -07:00
adaptive_table_factory.h
Sanitize block-based table index type and check prefix_extractor
2014-10-17 21:18:36 -07:00
block_based_filter_block_test.cc
Remember whole key/prefix filtering on/off in SST file
2015-02-11 11:20:04 -08:00
block_based_filter_block.cc
Remember whole key/prefix filtering on/off in SST file
2015-02-11 11:20:04 -08:00
block_based_filter_block.h
Remember whole key/prefix filtering on/off in SST file
2015-02-11 11:20:04 -08:00
block_based_table_builder.cc
Remember whole key/prefix filtering on/off in SST file
2015-02-11 11:20:04 -08:00
block_based_table_builder.h
introduce ImmutableOptions
2014-09-04 16:18:36 -07:00
block_based_table_factory.cc
Remember whole key/prefix filtering on/off in SST file
2015-02-11 11:20:04 -08:00
block_based_table_factory.h
Remember whole key/prefix filtering on/off in SST file
2015-02-11 11:20:04 -08:00
block_based_table_reader.cc
rocksdb: Fix scan-build memory warning in table/block_based_table_reader.cc
2015-02-19 14:07:38 -08:00
block_based_table_reader.h
Get() to use prefix bloom filter when filter is not block based
2015-02-04 15:15:41 -08:00
block_builder.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
block_builder.h
delete unused Comparator
2014-09-04 09:10:13 +08:00
block_hash_index_test.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
block_hash_index.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
block_hash_index.h
Turn on -Wshadow
2014-10-31 11:59:54 -07:00
block_prefix_index.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
block_prefix_index.h
fix a few compile warnings
2014-09-04 23:06:23 +08:00
block_test.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
block.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
block.h
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
bloom_block.cc
table/bloom_block.*: pass func parameter by reference
2014-09-30 23:30:31 +02:00
bloom_block.h
Enforce write buffer memory limit across column families
2014-12-02 12:09:20 -08:00
cuckoo_table_builder_test.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
cuckoo_table_builder.cc
Support footer versions bigger than 1
2015-01-13 14:33:04 -08:00
cuckoo_table_builder.h
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
cuckoo_table_factory.cc
option to choose module when calculating CuckooTable hash
2014-09-25 13:53:27 -07:00
cuckoo_table_factory.h
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
cuckoo_table_reader_test.cc
Add rocksdb::ToString() to address cases where std::to_string is not available.
2014-11-24 20:44:49 -08:00
cuckoo_table_reader.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
cuckoo_table_reader.h
use GetContext to replace callback function pointer
2014-09-29 11:09:09 -07:00
filter_block.h
Dump routine to BlockBasedTableReader
2014-12-23 13:24:07 -08:00
flush_block_policy.cc
move block based table related options BlockBasedTableOptions
2014-08-25 14:22:05 -07:00
format.cc
New BlockBasedTable version -- better compressed block format
2015-01-14 16:24:24 -08:00
format.h
New BlockBasedTable version -- better compressed block format
2015-01-14 16:24:24 -08:00
full_filter_block_test.cc
Remember whole key/prefix filtering on/off in SST file
2015-02-11 11:20:04 -08:00
full_filter_block.cc
Remember whole key/prefix filtering on/off in SST file
2015-02-11 11:20:04 -08:00
full_filter_block.h
Remember whole key/prefix filtering on/off in SST file
2015-02-11 11:20:04 -08:00
get_context.cc
use GetContext to replace callback function pointer
2014-09-29 11:09:09 -07:00
get_context.h
use GetContext to replace callback function pointer
2014-09-29 11:09:09 -07:00
iter_heap.h
Turn on -Wmissing-prototypes
2014-04-09 21:17:14 -07:00
iterator_wrapper.h
Turn -Wshadow back on
2014-11-06 11:14:28 -08:00
iterator.cc
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
2014-06-02 17:44:57 -07:00
merger_test.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
merger.cc
Fix iOS compile with -Wshorten-64-to-32
2014-11-13 14:39:30 -05:00
merger.h
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
2014-06-02 17:44:57 -07:00
meta_blocks.cc
Support footer versions bigger than 1
2015-01-13 14:33:04 -08:00
meta_blocks.h
Fix iOS compile with -Wshorten-64-to-32
2014-11-13 14:39:30 -05:00
mock_table.cc
CompactionJobTest
2014-11-14 11:35:48 -08:00
mock_table.h
CompactionJobTest
2014-11-14 11:35:48 -08:00
plain_table_builder.cc
Support footer versions bigger than 1
2015-01-13 14:33:04 -08:00
plain_table_builder.h
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
plain_table_factory.cc
in_table_factory.cc: use correct format specifier
2014-09-30 23:30:32 +02:00
plain_table_factory.h
Sanitize block-based table index type and check prefix_extractor
2014-10-17 21:18:36 -07:00
plain_table_index.cc
Block plain_table_index.cc in ROCKSDB_LITE
2014-11-24 20:47:27 -08:00
plain_table_index.h
Block plain_table_index.cc in ROCKSDB_LITE
2014-11-24 20:47:27 -08:00
plain_table_key_coding.cc
build: remove always-true assertions
2015-02-20 11:07:03 -08:00
plain_table_key_coding.h
typo improvement
2014-09-06 23:21:26 +08:00
plain_table_reader.cc
Add rocksdb::ToString() to address cases where std::to_string is not available.
2014-11-24 20:44:49 -08:00
plain_table_reader.h
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
table_builder.h
First phase API clean up
2014-02-03 00:30:43 -08:00
table_properties_internal.h
Fix iOS compile with -Wshorten-64-to-32
2014-11-13 14:39:30 -05:00
table_properties.cc
Add rocksdb::ToString() to address cases where std::to_string is not available.
2014-11-24 20:44:49 -08:00
table_reader_bench.cc
Make db_stress built for ROCKSDB_LITE
2014-11-14 10:20:51 -08:00
table_reader.h
Dump routine to BlockBasedTableReader
2014-12-23 13:24:07 -08:00
table_test.cc
New BlockBasedTable version -- better compressed block format
2015-01-14 16:24:24 -08:00
two_level_iterator.cc
ForwardIterator: reset incomplete iterators on Seek()
2014-08-29 16:21:29 -07:00
two_level_iterator.h
Turn on -Wshadow
2014-10-31 11:59:54 -07:00