3dff28cf9b
Summary: For performance purposes, the lower level routines were changed to use a SystemClock* instead of a std::shared_ptr<SystemClock>. The shared ptr has some performance degradation on certain hardware classes. For most of the system, there is no risk of the pointer being deleted/invalid because the shared_ptr will be stored elsewhere. For example, the ImmutableDBOptions stores the Env which has a std::shared_ptr<SystemClock> in it. The SystemClock* within the ImmutableDBOptions is essentially a "short cut" to gain access to this constant resource. There were a few classes (PeriodicWorkScheduler?) where the "short cut" property did not hold. In those cases, the shared pointer was preserved. Using db_bench readrandom perf_level=3 on my EC2 box, this change performed as well or better than 6.17: 6.17: readrandom : 28.046 micros/op 854902 ops/sec; 61.3 MB/s (355999 of 355999 found) 6.18: readrandom : 32.615 micros/op 735306 ops/sec; 52.7 MB/s (290999 of 290999 found) PR: readrandom : 27.500 micros/op 871909 ops/sec; 62.5 MB/s (367999 of 367999 found) (Note that the times for 6.18 are prior to revert of the SystemClock). Pull Request resolved: https://github.com/facebook/rocksdb/pull/8033 Reviewed By: pdillinger Differential Revision: D27014563 Pulled By: mrambacher fbshipit-source-id: ad0459eba03182e454391b5926bf5cdd45657b67
146 lines
5.2 KiB
C++
146 lines
5.2 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
#include "db/write_controller.h"
|
|
|
|
#include <ratio>
|
|
|
|
#include "rocksdb/system_clock.h"
|
|
#include "test_util/testharness.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
namespace {
|
|
class TimeSetClock : public SystemClockWrapper {
|
|
public:
|
|
explicit TimeSetClock() : SystemClockWrapper(nullptr) {}
|
|
const char* Name() const override { return "TimeSetClock"; }
|
|
uint64_t now_micros_ = 6666;
|
|
uint64_t NowNanos() override { return now_micros_ * std::milli::den; }
|
|
};
|
|
} // namespace
|
|
class WriteControllerTest : public testing::Test {
|
|
public:
|
|
WriteControllerTest() { clock_ = std::make_shared<TimeSetClock>(); }
|
|
std::shared_ptr<TimeSetClock> clock_;
|
|
};
|
|
|
|
TEST_F(WriteControllerTest, ChangeDelayRateTest) {
|
|
WriteController controller(40000000u); // also set max delayed rate
|
|
controller.set_delayed_write_rate(10000000u);
|
|
auto delay_token_0 =
|
|
controller.GetDelayToken(controller.delayed_write_rate());
|
|
ASSERT_EQ(static_cast<uint64_t>(2000000),
|
|
controller.GetDelay(clock_.get(), 20000000u));
|
|
auto delay_token_1 = controller.GetDelayToken(2000000u);
|
|
ASSERT_EQ(static_cast<uint64_t>(10000000),
|
|
controller.GetDelay(clock_.get(), 20000000u));
|
|
auto delay_token_2 = controller.GetDelayToken(1000000u);
|
|
ASSERT_EQ(static_cast<uint64_t>(20000000),
|
|
controller.GetDelay(clock_.get(), 20000000u));
|
|
auto delay_token_3 = controller.GetDelayToken(20000000u);
|
|
ASSERT_EQ(static_cast<uint64_t>(1000000),
|
|
controller.GetDelay(clock_.get(), 20000000u));
|
|
// This is more than max rate. Max delayed rate will be used.
|
|
auto delay_token_4 =
|
|
controller.GetDelayToken(controller.delayed_write_rate() * 3);
|
|
ASSERT_EQ(static_cast<uint64_t>(500000),
|
|
controller.GetDelay(clock_.get(), 20000000u));
|
|
}
|
|
|
|
TEST_F(WriteControllerTest, SanityTest) {
|
|
WriteController controller(10000000u);
|
|
auto stop_token_1 = controller.GetStopToken();
|
|
auto stop_token_2 = controller.GetStopToken();
|
|
|
|
ASSERT_TRUE(controller.IsStopped());
|
|
stop_token_1.reset();
|
|
ASSERT_TRUE(controller.IsStopped());
|
|
stop_token_2.reset();
|
|
ASSERT_FALSE(controller.IsStopped());
|
|
|
|
auto delay_token_1 = controller.GetDelayToken(10000000u);
|
|
ASSERT_EQ(static_cast<uint64_t>(2000000),
|
|
controller.GetDelay(clock_.get(), 20000000u));
|
|
|
|
clock_->now_micros_ += 1999900u; // sleep debt 1000
|
|
|
|
auto delay_token_2 = controller.GetDelayToken(10000000u);
|
|
// Rate reset after changing the token.
|
|
ASSERT_EQ(static_cast<uint64_t>(2000000),
|
|
controller.GetDelay(clock_.get(), 20000000u));
|
|
|
|
clock_->now_micros_ += 1999900u; // sleep debt 1000
|
|
|
|
// One refill: 10240 bytes allowed, 1000 used, 9240 left
|
|
ASSERT_EQ(static_cast<uint64_t>(1124),
|
|
controller.GetDelay(clock_.get(), 1000u));
|
|
clock_->now_micros_ += 1124u; // sleep debt 0
|
|
|
|
delay_token_2.reset();
|
|
// 1000 used, 8240 left
|
|
ASSERT_EQ(static_cast<uint64_t>(0), controller.GetDelay(clock_.get(), 1000u));
|
|
|
|
clock_->now_micros_ += 100u; // sleep credit 100
|
|
// 1000 used, 7240 left
|
|
ASSERT_EQ(static_cast<uint64_t>(0), controller.GetDelay(clock_.get(), 1000u));
|
|
|
|
clock_->now_micros_ += 100u; // sleep credit 200
|
|
// One refill: 10240 fileed, sleep credit generates 2000. 8000 used
|
|
// 7240 + 10240 + 2000 - 8000 = 11480 left
|
|
ASSERT_EQ(static_cast<uint64_t>(1024u),
|
|
controller.GetDelay(clock_.get(), 8000u));
|
|
|
|
clock_->now_micros_ += 200u; // sleep debt 824
|
|
// 1000 used, 10480 left.
|
|
ASSERT_EQ(static_cast<uint64_t>(0), controller.GetDelay(clock_.get(), 1000u));
|
|
|
|
clock_->now_micros_ += 200u; // sleep debt 624
|
|
// Out of bound sleep, still 10480 left
|
|
ASSERT_EQ(static_cast<uint64_t>(3000624u),
|
|
controller.GetDelay(clock_.get(), 30000000u));
|
|
|
|
clock_->now_micros_ += 3000724u; // sleep credit 100
|
|
// 6000 used, 4480 left.
|
|
ASSERT_EQ(static_cast<uint64_t>(0), controller.GetDelay(clock_.get(), 6000u));
|
|
|
|
clock_->now_micros_ += 200u; // sleep credit 300
|
|
// One refill, credit 4480 balance + 3000 credit + 10240 refill
|
|
// Use 8000, 9720 left
|
|
ASSERT_EQ(static_cast<uint64_t>(1024u),
|
|
controller.GetDelay(clock_.get(), 8000u));
|
|
|
|
clock_->now_micros_ += 3024u; // sleep credit 2000
|
|
|
|
// 1720 left
|
|
ASSERT_EQ(static_cast<uint64_t>(0u),
|
|
controller.GetDelay(clock_.get(), 8000u));
|
|
|
|
// 1720 balance + 20000 credit = 20170 left
|
|
// Use 8000, 12170 left
|
|
ASSERT_EQ(static_cast<uint64_t>(0u),
|
|
controller.GetDelay(clock_.get(), 8000u));
|
|
|
|
// 4170 left
|
|
ASSERT_EQ(static_cast<uint64_t>(0u),
|
|
controller.GetDelay(clock_.get(), 8000u));
|
|
|
|
// Need a refill
|
|
ASSERT_EQ(static_cast<uint64_t>(1024u),
|
|
controller.GetDelay(clock_.get(), 9000u));
|
|
|
|
delay_token_1.reset();
|
|
ASSERT_EQ(static_cast<uint64_t>(0),
|
|
controller.GetDelay(clock_.get(), 30000000u));
|
|
delay_token_1.reset();
|
|
ASSERT_FALSE(controller.IsStopped());
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
|
|
int main(int argc, char** argv) {
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
return RUN_ALL_TESTS();
|
|
}
|