90fc40690a
Summary: Do not consider the range tombstone sentinel key as causing 2 adjacent sstables in a level to overlap. When a range tombstone's end key is the largest key in an sstable, the sstable's end key is so to a "sentinel" value that is the smallest key in the next sstable with a sequence number of kMaxSequenceNumber. This "sentinel" is guaranteed to not overlap in internal-key space with the next sstable. Unfortunately, GetOverlappingFiles uses user-keys to determine overlap and was thus considering 2 adjacent sstables in a level to overlap if they were separated by this sentinel key. This in turn would cause compactions to be larger than necessary. Note that this conflicts with https://github.com/facebook/rocksdb/pull/2769 and cases `DBRangeDelTest.CompactionTreatsSplitInputLevelDeletionAtomically` to fail. Pull Request resolved: https://github.com/facebook/rocksdb/pull/4050 Differential Revision: D8844423 Pulled By: ajkr fbshipit-source-id: df3f9f1db8f4cff2bff77376b98b83c2ae1d155b
309 lines
11 KiB
C++
309 lines
11 KiB
C++
// Copyright (c) 2016-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#include <algorithm>
|
|
|
|
#include "db/db_test_util.h"
|
|
#include "db/range_del_aggregator.h"
|
|
#include "rocksdb/comparator.h"
|
|
#include "util/testutil.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class RangeDelAggregatorTest : public testing::Test {};
|
|
|
|
namespace {
|
|
|
|
struct ExpectedPoint {
|
|
Slice begin;
|
|
SequenceNumber seq;
|
|
bool expectAlive;
|
|
};
|
|
|
|
enum Direction {
|
|
kForward,
|
|
kReverse,
|
|
};
|
|
|
|
static auto icmp = InternalKeyComparator(BytewiseComparator());
|
|
|
|
void AddTombstones(RangeDelAggregator* range_del_agg,
|
|
const std::vector<RangeTombstone>& range_dels,
|
|
const InternalKey* smallest = nullptr,
|
|
const InternalKey* largest = nullptr) {
|
|
std::vector<std::string> keys, values;
|
|
for (const auto& range_del : range_dels) {
|
|
auto key_and_value = range_del.Serialize();
|
|
keys.push_back(key_and_value.first.Encode().ToString());
|
|
values.push_back(key_and_value.second.ToString());
|
|
}
|
|
std::unique_ptr<test::VectorIterator> range_del_iter(
|
|
new test::VectorIterator(keys, values));
|
|
range_del_agg->AddTombstones(std::move(range_del_iter), smallest, largest);
|
|
}
|
|
|
|
void VerifyTombstonesEq(const RangeTombstone& a, const RangeTombstone& b) {
|
|
ASSERT_EQ(a.seq_, b.seq_);
|
|
ASSERT_EQ(a.start_key_, b.start_key_);
|
|
ASSERT_EQ(a.end_key_, b.end_key_);
|
|
}
|
|
|
|
void VerifyRangeDelIter(
|
|
RangeDelIterator* range_del_iter,
|
|
const std::vector<RangeTombstone>& expected_range_dels) {
|
|
size_t i = 0;
|
|
for (; range_del_iter->Valid() && i < expected_range_dels.size();
|
|
range_del_iter->Next(), i++) {
|
|
VerifyTombstonesEq(expected_range_dels[i], range_del_iter->Tombstone());
|
|
}
|
|
ASSERT_EQ(expected_range_dels.size(), i);
|
|
ASSERT_FALSE(range_del_iter->Valid());
|
|
}
|
|
|
|
void VerifyRangeDels(
|
|
const std::vector<RangeTombstone>& range_dels_in,
|
|
const std::vector<ExpectedPoint>& expected_points,
|
|
const std::vector<RangeTombstone>& expected_collapsed_range_dels,
|
|
const InternalKey* smallest = nullptr,
|
|
const InternalKey* largest = nullptr) {
|
|
// Test same result regardless of which order the range deletions are added
|
|
// and regardless of collapsed mode.
|
|
for (bool collapsed : {false, true}) {
|
|
for (Direction dir : {kForward, kReverse}) {
|
|
RangeDelAggregator range_del_agg(icmp, {} /* snapshots */, collapsed);
|
|
|
|
std::vector<RangeTombstone> range_dels = range_dels_in;
|
|
if (dir == kReverse) {
|
|
std::reverse(range_dels.begin(), range_dels.end());
|
|
}
|
|
AddTombstones(&range_del_agg, range_dels, smallest, largest);
|
|
|
|
auto mode = RangeDelPositioningMode::kFullScan;
|
|
if (collapsed) {
|
|
mode = RangeDelPositioningMode::kForwardTraversal;
|
|
}
|
|
|
|
for (const auto expected_point : expected_points) {
|
|
ParsedInternalKey parsed_key;
|
|
parsed_key.user_key = expected_point.begin;
|
|
parsed_key.sequence = expected_point.seq;
|
|
parsed_key.type = kTypeValue;
|
|
ASSERT_FALSE(range_del_agg.ShouldDelete(parsed_key, mode));
|
|
if (parsed_key.sequence > 0) {
|
|
--parsed_key.sequence;
|
|
if (expected_point.expectAlive) {
|
|
ASSERT_FALSE(range_del_agg.ShouldDelete(parsed_key, mode));
|
|
} else {
|
|
ASSERT_TRUE(range_del_agg.ShouldDelete(parsed_key, mode));
|
|
}
|
|
}
|
|
}
|
|
|
|
if (collapsed) {
|
|
range_dels = expected_collapsed_range_dels;
|
|
VerifyRangeDelIter(range_del_agg.NewIterator().get(), range_dels);
|
|
} else if (smallest == nullptr && largest == nullptr) {
|
|
// Tombstones in an uncollapsed map are presented in start key
|
|
// order. Tombstones with the same start key are presented in
|
|
// insertion order. We don't handle tombstone truncation here, so the
|
|
// verification is only performed if no truncation was requested.
|
|
std::stable_sort(range_dels.begin(), range_dels.end(),
|
|
[&](const RangeTombstone& a, const RangeTombstone& b) {
|
|
return icmp.user_comparator()->Compare(
|
|
a.start_key_, b.start_key_) < 0;
|
|
});
|
|
VerifyRangeDelIter(range_del_agg.NewIterator().get(), range_dels);
|
|
}
|
|
}
|
|
}
|
|
|
|
RangeDelAggregator range_del_agg(icmp, {} /* snapshots */,
|
|
false /* collapse_deletions */);
|
|
AddTombstones(&range_del_agg, range_dels_in);
|
|
for (size_t i = 1; i < expected_points.size(); ++i) {
|
|
bool overlapped = range_del_agg.IsRangeOverlapped(
|
|
expected_points[i - 1].begin, expected_points[i].begin);
|
|
if (expected_points[i - 1].seq > 0 || expected_points[i].seq > 0) {
|
|
ASSERT_TRUE(overlapped);
|
|
} else {
|
|
ASSERT_FALSE(overlapped);
|
|
}
|
|
}
|
|
}
|
|
|
|
} // anonymous namespace
|
|
|
|
TEST_F(RangeDelAggregatorTest, Empty) { VerifyRangeDels({}, {{"a", 0}}, {}); }
|
|
|
|
TEST_F(RangeDelAggregatorTest, SameStartAndEnd) {
|
|
VerifyRangeDels({{"a", "a", 5}}, {{" ", 0}, {"a", 0}, {"b", 0}}, {});
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, Single) {
|
|
VerifyRangeDels({{"a", "b", 10}}, {{" ", 0}, {"a", 10}, {"b", 0}},
|
|
{{"a", "b", 10}});
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, OverlapAboveLeft) {
|
|
VerifyRangeDels({{"a", "c", 10}, {"b", "d", 5}},
|
|
{{" ", 0}, {"a", 10}, {"c", 5}, {"d", 0}},
|
|
{{"a", "c", 10}, {"c", "d", 5}});
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, OverlapAboveRight) {
|
|
VerifyRangeDels({{"a", "c", 5}, {"b", "d", 10}},
|
|
{{" ", 0}, {"a", 5}, {"b", 10}, {"d", 0}},
|
|
{{"a", "b", 5}, {"b", "d", 10}});
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, OverlapAboveMiddle) {
|
|
VerifyRangeDels({{"a", "d", 5}, {"b", "c", 10}},
|
|
{{" ", 0}, {"a", 5}, {"b", 10}, {"c", 5}, {"d", 0}},
|
|
{{"a", "b", 5}, {"b", "c", 10}, {"c", "d", 5}});
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, OverlapFully) {
|
|
VerifyRangeDels({{"a", "d", 10}, {"b", "c", 5}},
|
|
{{" ", 0}, {"a", 10}, {"d", 0}}, {{"a", "d", 10}});
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, OverlapPoint) {
|
|
VerifyRangeDels({{"a", "b", 5}, {"b", "c", 10}},
|
|
{{" ", 0}, {"a", 5}, {"b", 10}, {"c", 0}},
|
|
{{"a", "b", 5}, {"b", "c", 10}});
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, SameStartKey) {
|
|
VerifyRangeDels({{"a", "c", 5}, {"a", "b", 10}},
|
|
{{" ", 0}, {"a", 10}, {"b", 5}, {"c", 0}},
|
|
{{"a", "b", 10}, {"b", "c", 5}});
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, SameEndKey) {
|
|
VerifyRangeDels({{"a", "d", 5}, {"b", "d", 10}},
|
|
{{" ", 0}, {"a", 5}, {"b", 10}, {"d", 0}},
|
|
{{"a", "b", 5}, {"b", "d", 10}});
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, GapsBetweenRanges) {
|
|
VerifyRangeDels({{"a", "b", 5}, {"c", "d", 10}, {"e", "f", 15}},
|
|
{{" ", 0},
|
|
{"a", 5},
|
|
{"b", 0},
|
|
{"c", 10},
|
|
{"d", 0},
|
|
{"da", 0},
|
|
{"e", 15},
|
|
{"f", 0}},
|
|
{{"a", "b", 5}, {"c", "d", 10}, {"e", "f", 15}});
|
|
}
|
|
|
|
// Note the Cover* tests also test cases where tombstones are inserted under a
|
|
// larger one when VerifyRangeDels() runs them in reverse
|
|
TEST_F(RangeDelAggregatorTest, CoverMultipleFromLeft) {
|
|
VerifyRangeDels(
|
|
{{"b", "d", 5}, {"c", "f", 10}, {"e", "g", 15}, {"a", "f", 20}},
|
|
{{" ", 0}, {"a", 20}, {"f", 15}, {"g", 0}},
|
|
{{"a", "f", 20}, {"f", "g", 15}});
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, CoverMultipleFromRight) {
|
|
VerifyRangeDels(
|
|
{{"b", "d", 5}, {"c", "f", 10}, {"e", "g", 15}, {"c", "h", 20}},
|
|
{{" ", 0}, {"b", 5}, {"c", 20}, {"h", 0}},
|
|
{{"b", "c", 5}, {"c", "h", 20}});
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, CoverMultipleFully) {
|
|
VerifyRangeDels(
|
|
{{"b", "d", 5}, {"c", "f", 10}, {"e", "g", 15}, {"a", "h", 20}},
|
|
{{" ", 0}, {"a", 20}, {"h", 0}}, {{"a", "h", 20}});
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, AlternateMultipleAboveBelow) {
|
|
VerifyRangeDels(
|
|
{{"b", "d", 15}, {"c", "f", 10}, {"e", "g", 20}, {"a", "h", 5}},
|
|
{{" ", 0}, {"a", 5}, {"b", 15}, {"d", 10}, {"e", 20}, {"g", 5}, {"h", 0}},
|
|
{{"a", "b", 5},
|
|
{"b", "d", 15},
|
|
{"d", "e", 10},
|
|
{"e", "g", 20},
|
|
{"g", "h", 5}});
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, MergingIteratorAllEmptyStripes) {
|
|
for (bool collapsed : {true, false}) {
|
|
RangeDelAggregator range_del_agg(icmp, {1, 2}, collapsed);
|
|
VerifyRangeDelIter(range_del_agg.NewIterator().get(), {});
|
|
}
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, MergingIteratorOverlappingStripes) {
|
|
for (bool collapsed : {true, false}) {
|
|
RangeDelAggregator range_del_agg(icmp, {5, 15, 25, 35}, collapsed);
|
|
AddTombstones(
|
|
&range_del_agg,
|
|
{{"d", "e", 10}, {"aa", "b", 20}, {"c", "d", 30}, {"a", "b", 10}});
|
|
VerifyRangeDelIter(
|
|
range_del_agg.NewIterator().get(),
|
|
{{"a", "b", 10}, {"aa", "b", 20}, {"c", "d", 30}, {"d", "e", 10}});
|
|
}
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, MergingIteratorSeek) {
|
|
RangeDelAggregator range_del_agg(icmp, {5, 15}, true /* collapsed */);
|
|
AddTombstones(&range_del_agg, {{"a", "c", 10},
|
|
{"b", "c", 11},
|
|
{"f", "g", 10},
|
|
{"c", "d", 20},
|
|
{"e", "f", 20}});
|
|
auto it = range_del_agg.NewIterator();
|
|
|
|
// Verify seek positioning.
|
|
it->Seek("");
|
|
VerifyTombstonesEq(it->Tombstone(), {"a", "b", 10});
|
|
it->Seek("a");
|
|
VerifyTombstonesEq(it->Tombstone(), {"a", "b", 10});
|
|
it->Seek("aa");
|
|
VerifyTombstonesEq(it->Tombstone(), {"a", "b", 10});
|
|
it->Seek("b");
|
|
VerifyTombstonesEq(it->Tombstone(), {"b", "c", 11});
|
|
it->Seek("c");
|
|
VerifyTombstonesEq(it->Tombstone(), {"c", "d", 20});
|
|
it->Seek("dd");
|
|
VerifyTombstonesEq(it->Tombstone(), {"e", "f", 20});
|
|
it->Seek("f");
|
|
VerifyTombstonesEq(it->Tombstone(), {"f", "g", 10});
|
|
it->Seek("g");
|
|
ASSERT_EQ(it->Valid(), false);
|
|
it->Seek("h");
|
|
ASSERT_EQ(it->Valid(), false);
|
|
|
|
// Verify iteration after seek.
|
|
it->Seek("c");
|
|
VerifyRangeDelIter(it.get(),
|
|
{{"c", "d", 20}, {"e", "f", 20}, {"f", "g", 10}});
|
|
}
|
|
|
|
TEST_F(RangeDelAggregatorTest, TruncateTombstones) {
|
|
const InternalKey smallest("b", 1, kTypeRangeDeletion);
|
|
const InternalKey largest("e", kMaxSequenceNumber, kTypeRangeDeletion);
|
|
VerifyRangeDels(
|
|
{{"a", "c", 10}, {"d", "f", 10}},
|
|
{{"a", 10, true}, // truncated
|
|
{"b", 10, false}, // not truncated
|
|
{"d", 10, false}, // not truncated
|
|
{"e", 10, true}}, // truncated
|
|
{{"b", "c", 10}, {"d", "e", 10}},
|
|
&smallest, &largest);
|
|
}
|
|
|
|
} // namespace rocksdb
|
|
|
|
int main(int argc, char** argv) {
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
return RUN_ALL_TESTS();
|
|
}
|