c6d464a9da
Summary: I have manually audited the entire RocksJava code base. Sorry for the large pull-request, I have broken it down into many small atomic commits though. My initial intention was to fix the warnings that appear when running RocksJava on Java 8 with `-Xcheck:jni`, for example when running `make jtest` you would see many errors similar to: ``` WARNING in native method: JNI call made without checking exceptions when required to from CallObjectMethod WARNING in native method: JNI call made without checking exceptions when required to from CallVoidMethod WARNING in native method: JNI call made without checking exceptions when required to from CallStaticVoidMethod ... ``` A few of those warnings still remain, however they seem to come directly from the JVM and are not directly related to RocksJava; I am in contact with the OpenJDK hostpot-dev mailing list about these - http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-February/025981.html. As a result of fixing these, I realised we were not r Closes https://github.com/facebook/rocksdb/pull/1890 Differential Revision: D4591758 Pulled By: siying fbshipit-source-id: 7f7fdf4
51 lines
1.6 KiB
C++
51 lines
1.6 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
// This file implements the callback "bridge" between Java and C++ for
|
|
// rocksdb::Logger
|
|
|
|
#ifndef JAVA_ROCKSJNI_LOGGERJNICALLBACK_H_
|
|
#define JAVA_ROCKSJNI_LOGGERJNICALLBACK_H_
|
|
|
|
#include <jni.h>
|
|
#include <memory>
|
|
#include <string>
|
|
#include "port/port.h"
|
|
#include "rocksdb/env.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class LoggerJniCallback : public Logger {
|
|
public:
|
|
LoggerJniCallback(JNIEnv* env, jobject jLogger);
|
|
virtual ~LoggerJniCallback();
|
|
|
|
using Logger::SetInfoLogLevel;
|
|
using Logger::GetInfoLogLevel;
|
|
// Write an entry to the log file with the specified format.
|
|
virtual void Logv(const char* format, va_list ap);
|
|
// Write an entry to the log file with the specified log level
|
|
// and format. Any log with level under the internal log level
|
|
// of *this (see @SetInfoLogLevel and @GetInfoLogLevel) will not be
|
|
// printed.
|
|
virtual void Logv(const InfoLogLevel log_level,
|
|
const char* format, va_list ap);
|
|
|
|
private:
|
|
JavaVM* m_jvm;
|
|
jobject m_jLogger;
|
|
jmethodID m_jLogMethodId;
|
|
jobject m_jdebug_level;
|
|
jobject m_jinfo_level;
|
|
jobject m_jwarn_level;
|
|
jobject m_jerror_level;
|
|
jobject m_jfatal_level;
|
|
jobject m_jheader_level;
|
|
std::unique_ptr<char[]> format_str(const char* format, va_list ap) const;
|
|
};
|
|
} // namespace rocksdb
|
|
|
|
#endif // JAVA_ROCKSJNI_LOGGERJNICALLBACK_H_
|