andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/db
History
Aaron Gao cc87075d63 No need to limit to 20 files in UpdateAccumulatedStats() if options.max_open_files=-1 
Summary:
There is a hardcoded constraint in our statistics collection that prevents reading properties from more than 20 SST files. This means our statistics will be very inaccurate for databases with > 20 files since additional files are just ignored. The purpose of constraining the number of files used is to bound the I/O performed during statistics collection, since these statistics need to be recomputed every time the database reopened.

However, this constraint doesn't take into account the case where option "max_open_files" is -1. In that case, all the file metadata has already been read, so MaybeInitializeFileMetaData() won't incur any I/O cost. so this diff gets rid of the 20-file constraint in case max_open_files == -1.

Test Plan:
write into unit test db/db_properties_test.cc - "ValidateSampleNumber".
We generate 20 files with 2 rows and 10 files with 1 row.
If max_open_files !=-1, the `rocksdb.estimate-num-keys` should be (10*1 + 10*2)/20 * 30 = 45. Otherwise, it should be the ground truth, 50.
{F1089153}

Reviewers: andrewkr

Reviewed By: andrewkr

Subscribers: andrewkr, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D56253
2016-04-01 16:19:12 -07:00
..
auto_roll_logger_test.cc
Redo SyncPoints for flush while rolling test
2016-02-22 21:32:19 -08:00
auto_roll_logger.cc
Redo SyncPoints for flush while rolling test
2016-02-22 21:32:19 -08:00
auto_roll_logger.h
Redo SyncPoints for flush while rolling test
2016-02-22 21:32:19 -08:00
builder.cc
Adding pin_l0_filter_and_index_blocks_in_cache feature and related fixes.
2016-04-01 10:42:39 -07:00
builder.h
Adding pin_l0_filter_and_index_blocks_in_cache feature and related fixes.
2016-04-01 10:42:39 -07:00
c_test.c
Deprecate CompactionFilterV2
2015-07-17 18:59:11 +02:00
c.cc
Adding pin_l0_filter_and_index_blocks_in_cache feature and related fixes.
2016-04-01 10:42:39 -07:00
column_family_test.cc
Add test to make sure DropColumnFamily doesn't impact existing iterators
2016-02-24 10:25:38 -08:00
column_family.cc
ColumnFamilyOptions SanitizeOptions is buggy on 32-bit platforms.
2016-03-14 16:21:54 -07:00
column_family.h
Adding pin_l0_filter_and_index_blocks_in_cache feature and related fixes.
2016-04-01 10:42:39 -07:00
compact_files_test.cc
Fixed CompactFiles() spuriously failing or corrupting DB
2016-02-22 13:54:58 -08:00
compacted_db_impl.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
compacted_db_impl.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
compaction_iterator_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
compaction_iterator.cc
Fix data race issue when sub-compaction is used in CompactionJob
2016-03-24 19:36:39 -07:00
compaction_iterator.h
Fix data race issue when sub-compaction is used in CompactionJob
2016-03-24 19:36:39 -07:00
compaction_job_stats_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
compaction_job_test.cc
Introduce SstFileManager::SetMaxAllowedSpaceUsage() to cap disk space usage
2016-02-17 15:20:23 -08:00
compaction_job.cc
Fix data race issue when sub-compaction is used in CompactionJob
2016-03-24 19:36:39 -07:00
compaction_job.h
Introduce SstFileManager::SetMaxAllowedSpaceUsage() to cap disk space usage
2016-02-17 15:20:23 -08:00
compaction_picker_test.cc
Change some RocksDB default options
2016-03-31 17:12:18 -07:00
compaction_picker.cc
Compaction always needs to be removed from level0_compactions_in_progress_ for universal compaction
2016-03-02 21:23:28 -08:00
compaction_picker.h
Improve comment in compaction.h and compaction_picker.h
2016-03-08 16:46:41 -08:00
compaction.cc
Fix data race issue when sub-compaction is used in CompactionJob
2016-03-24 19:36:39 -07:00
compaction.h
Fix data race issue when sub-compaction is used in CompactionJob
2016-03-24 19:36:39 -07:00
comparator_db_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
convenience.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
corruption_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
cuckoo_table_db_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
db_block_cache_test.cc
Fix no compression test
2016-03-15 12:17:40 -07:00
db_compaction_filter_test.cc
Change some RocksDB default options
2016-03-31 17:12:18 -07:00
db_compaction_test.cc
Change some RocksDB default options
2016-03-31 17:12:18 -07:00
db_dynamic_level_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
db_filesnapshot.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
db_impl_debug.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
db_impl_experimental.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
db_impl_readonly.cc
Add Iterator Property rocksdb.iterator.version_number
2016-03-02 16:23:59 -08:00
db_impl_readonly.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
db_impl.cc
Adding pin_l0_filter_and_index_blocks_in_cache feature and related fixes.
2016-04-01 10:42:39 -07:00
db_impl.h
Correct a typo in a comment
2016-03-24 19:39:13 -07:00
db_info_dumper.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
db_info_dumper.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
db_inplace_update_test.cc
Change some RocksDB default options
2016-03-31 17:12:18 -07:00
db_iter_test.cc
Add Iterator Property rocksdb.iterator.version_number
2016-03-02 16:23:59 -08:00
db_iter.cc
Eliminate std::deque initialization while iterating over merge operands
2016-04-01 15:48:55 -07:00
db_iter.h
Add Iterator Property rocksdb.iterator.version_number
2016-03-02 16:23:59 -08:00
db_log_iter_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
db_properties_test.cc
No need to limit to 20 files in UpdateAccumulatedStats() if options.max_open_files=-1
2016-04-01 16:19:12 -07:00
db_table_properties_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
db_tailing_iter_test.cc
Change Property name from "rocksdb.current_version_number" to "rocksdb.current-super-version-number"
2016-03-04 18:15:29 -08:00
db_test2.cc
Adding pin_l0_filter_and_index_blocks_in_cache feature and related fixes.
2016-04-01 10:42:39 -07:00
db_test_util.cc
Change some RocksDB default options
2016-03-31 17:12:18 -07:00
db_test_util.h
Introduce SstFileManager::SetMaxAllowedSpaceUsage() to cap disk space usage
2016-02-17 15:20:23 -08:00
db_test.cc
Change some RocksDB default options
2016-03-31 17:12:18 -07:00
db_universal_compaction_test.cc
Change some RocksDB default options
2016-03-31 17:12:18 -07:00
db_wal_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
dbformat_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
dbformat.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
dbformat.h
WriteBatchWithIndex micro optimization
2016-04-01 15:23:46 -07:00
deletefile_test.cc
Handle concurrent manifest update and backup creation
2016-02-29 12:56:55 -08:00
event_helpers.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
event_helpers.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
experimental.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
fault_injection_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
file_indexer_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
file_indexer.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
file_indexer.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
filename_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
filename.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
filename.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
flush_job_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
flush_job.cc
Adding pin_l0_filter_and_index_blocks_in_cache feature and related fixes.
2016-04-01 10:42:39 -07:00
flush_job.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
flush_scheduler.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
flush_scheduler.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
forward_iterator_bench.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
forward_iterator.cc
Change Property name from "rocksdb.current_version_number" to "rocksdb.current-super-version-number"
2016-03-04 18:15:29 -08:00
forward_iterator.h
Add Iterator Property rocksdb.iterator.version_number
2016-03-02 16:23:59 -08:00
inlineskiplist_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
inlineskiplist.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
internal_stats.cc
Change Property name from "rocksdb.current_version_number" to "rocksdb.current-super-version-number"
2016-03-04 18:15:29 -08:00
internal_stats.h
Change Property name from "rocksdb.current_version_number" to "rocksdb.current-super-version-number"
2016-03-04 18:15:29 -08:00
job_context.h
Cleanup stale manifests outside of full purge
2016-03-10 18:16:21 -08:00
listener_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
log_format.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
log_reader.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
log_reader.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
log_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
log_writer.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
log_writer.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
managed_iterator.cc
Fixes warnings and ensure correct int behavior on 32-bit platforms.
2016-03-16 22:57:57 +01:00
managed_iterator.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
manual_compaction_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
memtable_allocator.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
memtable_allocator.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
memtable_list_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
memtable_list.cc
Fixes warnings and ensure correct int behavior on 32-bit platforms.
2016-03-16 22:57:57 +01:00
memtable_list.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
memtable.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
memtable.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
memtablerep_bench.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
merge_context.h
Eliminate std::deque initialization while iterating over merge operands
2016-04-01 15:48:55 -07:00
merge_helper_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
merge_helper.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
merge_helper.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
merge_operator.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
merge_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
options_file_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
perf_context_test.cc
Fix perf_context::merge_operator_time_nanos calculation
2016-03-25 18:29:43 -07:00
plain_table_db_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
prefix_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
repair_test.cc
Add unit tests for RepairDB
2016-03-18 15:18:42 -07:00
repair.cc
In all the places where log records are read, there was a check that
2016-03-30 23:05:22 +05:30
skiplist_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
skiplist.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
slice.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
snapshot_impl.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
snapshot_impl.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
table_cache.cc
Adding pin_l0_filter_and_index_blocks_in_cache feature and related fixes.
2016-04-01 10:42:39 -07:00
table_cache.h
Adding pin_l0_filter_and_index_blocks_in_cache feature and related fixes.
2016-04-01 10:42:39 -07:00
table_properties_collector_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
table_properties_collector.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
table_properties_collector.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
transaction_log_impl.cc
In all the places where log records are read, there was a check that
2016-03-30 23:05:22 +05:30
transaction_log_impl.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
version_builder_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
version_builder.cc
Adding pin_l0_filter_and_index_blocks_in_cache feature and related fixes.
2016-04-01 10:42:39 -07:00
version_builder.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
version_edit_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
version_edit.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
version_edit.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
version_set_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
version_set.cc
No need to limit to 20 files in UpdateAccumulatedStats() if options.max_open_files=-1
2016-04-01 16:19:12 -07:00
version_set.h
Fix data race issue when sub-compaction is used in CompactionJob
2016-03-24 19:36:39 -07:00
wal_manager_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
wal_manager.cc
In all the places where log records are read, there was a check that
2016-03-30 23:05:22 +05:30
wal_manager.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
write_batch_base.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
write_batch_internal.h
In all the places where log records are read, there was a check that
2016-03-30 23:05:22 +05:30
write_batch_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
write_batch.cc
WriteBatchWithIndex micro optimization
2016-04-01 15:23:46 -07:00
write_callback_test.cc
Improve write_with_callback_test to sync WAL
2016-02-16 14:04:14 -08:00
write_callback.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
write_controller_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
write_controller.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
write_controller.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
write_thread.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
write_thread.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
writebuffer.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
xfunc_test_points.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
xfunc_test_points.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00