cd535c2280
Summary: In latest leaf's, MayContainHash() consistently consumes 5%~7% CPU usage. I checked the code and did an experiment with/without inlining this method. In release mode, with `1024 * 1024 * 256` bits and `1024 * 512` entries, both call 2^30 MayContainHash() with distinctive parameters. As the result showed, this patch reduced the running time from 9.127 sec to 7.891 sec. Test Plan: make check Reviewers: sdong, haobo CC: leveldb Differential Revision: https://reviews.facebook.net/D15177
71 lines
2.0 KiB
C++
71 lines
2.0 KiB
C++
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
#pragma once
|
|
|
|
#include <atomic>
|
|
#include <memory>
|
|
|
|
namespace rocksdb {
|
|
|
|
class Slice;
|
|
|
|
class DynamicBloom {
|
|
public:
|
|
// total_bits: fixed total bits for the bloom
|
|
// hash_func: customized hash function
|
|
// num_probes: number of hash probes for a single key
|
|
DynamicBloom(uint32_t total_bits,
|
|
uint32_t (*hash_func)(const Slice& key),
|
|
uint32_t num_probes = 6);
|
|
|
|
explicit DynamicBloom(uint32_t total_bits, uint32_t num_probes = 6);
|
|
|
|
// Assuming single threaded access to Add
|
|
void Add(const Slice& key) { AddHash(hash_func_(key)); }
|
|
|
|
// Assuming single threaded access to Add
|
|
void AddHash(uint32_t hash);
|
|
|
|
// Multithreaded access to MayContain is OK
|
|
bool MayContain(const Slice& key);
|
|
|
|
// Multithreaded access to MayContain is OK
|
|
bool MayContainHash(uint32_t hash);
|
|
|
|
private:
|
|
uint32_t (*hash_func_)(const Slice& key);
|
|
const uint32_t kTotalBits;
|
|
const uint32_t kNumProbes;
|
|
std::unique_ptr<unsigned char[]> data_;
|
|
};
|
|
|
|
inline bool DynamicBloom::MayContain(const Slice& key) {
|
|
return (MayContainHash(hash_func_(key)));
|
|
}
|
|
|
|
inline bool DynamicBloom::MayContainHash(uint32_t h) {
|
|
const uint32_t delta = (h >> 17) | (h << 15); // Rotate right 17 bits
|
|
for (uint32_t i = 0; i < kNumProbes; i++) {
|
|
const uint32_t bitpos = h % kTotalBits;
|
|
if (((data_[bitpos / 8]) & (1 << (bitpos % 8))) == 0) {
|
|
return false;
|
|
}
|
|
h += delta;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
inline void DynamicBloom::AddHash(uint32_t h) {
|
|
const uint32_t delta = (h >> 17) | (h << 15); // Rotate right 17 bits
|
|
for (uint32_t i = 0; i < kNumProbes; i++) {
|
|
const uint32_t bitpos = h % kTotalBits;
|
|
data_[bitpos / 8] |= (1 << (bitpos % 8));
|
|
h += delta;
|
|
}
|
|
}
|
|
|
|
} // rocksdb
|