5009b5326b
Summary: Currently, if users define both of full key bloom and prefix bloom in SST files. During Get(), if full key bloom shows the key may exist, we still go ahead and check prefix bloom. This is wasteful. If bloom filter for full keys exists, we should always ignore prefix bloom in Get(). Test Plan: Run existing tests Reviewers: yhchiang, IslamAbdelRahman Reviewed By: IslamAbdelRahman Subscribers: leveldb, andrewkr, dhruba Differential Revision: https://reviews.facebook.net/D57825
110 lines
3.3 KiB
C++
110 lines
3.3 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
#include "table/full_filter_block.h"
|
|
|
|
#include "rocksdb/filter_policy.h"
|
|
#include "port/port.h"
|
|
#include "util/coding.h"
|
|
#include "util/perf_context_imp.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
FullFilterBlockBuilder::FullFilterBlockBuilder(
|
|
const SliceTransform* prefix_extractor, bool whole_key_filtering,
|
|
FilterBitsBuilder* filter_bits_builder)
|
|
: prefix_extractor_(prefix_extractor),
|
|
whole_key_filtering_(whole_key_filtering),
|
|
num_added_(0) {
|
|
assert(filter_bits_builder != nullptr);
|
|
filter_bits_builder_.reset(filter_bits_builder);
|
|
}
|
|
|
|
void FullFilterBlockBuilder::Add(const Slice& key) {
|
|
if (whole_key_filtering_) {
|
|
AddKey(key);
|
|
}
|
|
if (prefix_extractor_ && prefix_extractor_->InDomain(key)) {
|
|
AddPrefix(key);
|
|
}
|
|
}
|
|
|
|
// Add key to filter if needed
|
|
inline void FullFilterBlockBuilder::AddKey(const Slice& key) {
|
|
filter_bits_builder_->AddKey(key);
|
|
num_added_++;
|
|
}
|
|
|
|
// Add prefix to filter if needed
|
|
inline void FullFilterBlockBuilder::AddPrefix(const Slice& key) {
|
|
Slice prefix = prefix_extractor_->Transform(key);
|
|
filter_bits_builder_->AddKey(prefix);
|
|
num_added_++;
|
|
}
|
|
|
|
Slice FullFilterBlockBuilder::Finish() {
|
|
if (num_added_ != 0) {
|
|
num_added_ = 0;
|
|
return filter_bits_builder_->Finish(&filter_data_);
|
|
}
|
|
return Slice();
|
|
}
|
|
|
|
FullFilterBlockReader::FullFilterBlockReader(
|
|
const SliceTransform* prefix_extractor, bool _whole_key_filtering,
|
|
const Slice& contents, FilterBitsReader* filter_bits_reader,
|
|
Statistics* stats)
|
|
: FilterBlockReader(contents.size(), stats, _whole_key_filtering),
|
|
prefix_extractor_(prefix_extractor),
|
|
contents_(contents) {
|
|
assert(filter_bits_reader != nullptr);
|
|
filter_bits_reader_.reset(filter_bits_reader);
|
|
}
|
|
|
|
FullFilterBlockReader::FullFilterBlockReader(
|
|
const SliceTransform* prefix_extractor, bool _whole_key_filtering,
|
|
BlockContents&& contents, FilterBitsReader* filter_bits_reader,
|
|
Statistics* stats)
|
|
: FullFilterBlockReader(prefix_extractor, _whole_key_filtering,
|
|
contents.data, filter_bits_reader, stats) {
|
|
block_contents_ = std::move(contents);
|
|
}
|
|
|
|
bool FullFilterBlockReader::KeyMayMatch(const Slice& key,
|
|
uint64_t block_offset) {
|
|
assert(block_offset == kNotValid);
|
|
if (!whole_key_filtering_) {
|
|
return true;
|
|
}
|
|
return MayMatch(key);
|
|
}
|
|
|
|
bool FullFilterBlockReader::PrefixMayMatch(const Slice& prefix,
|
|
uint64_t block_offset) {
|
|
assert(block_offset == kNotValid);
|
|
if (!prefix_extractor_) {
|
|
return true;
|
|
}
|
|
return MayMatch(prefix);
|
|
}
|
|
|
|
bool FullFilterBlockReader::MayMatch(const Slice& entry) {
|
|
if (contents_.size() != 0) {
|
|
if (filter_bits_reader_->MayMatch(entry)) {
|
|
PERF_COUNTER_ADD(bloom_sst_hit_count, 1);
|
|
return true;
|
|
} else {
|
|
PERF_COUNTER_ADD(bloom_sst_miss_count, 1);
|
|
return false;
|
|
}
|
|
}
|
|
return true; // remain the same with block_based filter
|
|
}
|
|
|
|
size_t FullFilterBlockReader::ApproximateMemoryUsage() const {
|
|
return contents_.size();
|
|
}
|
|
} // namespace rocksdb
|