andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
d060421c77
rocksdb/utilities
History
Maysam Yabandeh d060421c77 Fix a leak in prepared_section_completed_ 
Summary:
The zeroed entries were not removed from prepared_section_completed_ map. This patch adds a unit test to show the problem and fixes that by refactoring the code. The new code is more efficient since i) it uses two separate mutex to avoid contention between commit and prepare threads, ii) it uses a sorted vector for maintaining uniq log entires with prepare which avoids a very large heap with many duplicate entries.
Closes https://github.com/facebook/rocksdb/pull/3545

Differential Revision: D7106071

Pulled By: maysamyabandeh

fbshipit-source-id: b3ae17cb6cd37ef10b6b35e0086c15c758768a48
2018-03-01 20:41:56 -08:00
..
backupable Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
blob_db Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
cassandra Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
checkpoint Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
compaction_filters Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
convenience Change RocksDB License 2017-07-15 16:11:23 -07:00
date_tiered WritePrepared Txn: Iterator 2017-10-09 17:15:28 -07:00
document Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
geodb Change RocksDB License 2017-07-15 16:11:23 -07:00
leveldb_options Change RocksDB License 2017-07-15 16:11:23 -07:00
lua Suppress unused warnings 2018-02-02 12:27:07 -08:00
memory Change RocksDB License 2017-07-15 16:11:23 -07:00
merge_operators Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
option_change_migration Change RocksDB License 2017-07-15 16:11:23 -07:00
options Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
persistent_cache Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
redis Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
simulator_cache Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
spatialdb Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
table_properties_collectors Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
transactions Fix a leak in prepared_section_completed_ 2018-03-01 20:41:56 -08:00
ttl Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
write_batch_with_index WritePrepared Txn: optimize SubBatchCnt 2018-02-22 18:12:26 -08:00
col_buf_decoder.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
col_buf_decoder.h Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
col_buf_encoder.cc fix shift UBSAN error in col_buf_encoder.cc 2018-02-20 16:44:00 -08:00
col_buf_encoder.h Change RocksDB License 2017-07-15 16:11:23 -07:00
column_aware_encoding_exp.cc fix gflags namespace 2017-12-01 10:42:05 -08:00
column_aware_encoding_test.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
column_aware_encoding_util.cc WritePrepared Txn: fix non-emptied PreparedHeap bug 2018-02-21 13:42:23 -08:00
column_aware_encoding_util.h Change RocksDB License 2017-07-15 16:11:23 -07:00
debug.cc Fix naming in InternalKey 2017-09-12 17:17:42 -07:00
env_librados_test.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
env_librados.cc Suppress lint in old files 2018-01-29 12:56:42 -08:00
env_librados.md Add EnvLibrados - RocksDB Env of RADOS (#1222) 2016-07-21 11:16:34 -07:00
env_mirror_test.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
env_mirror.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
env_timed_test.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
env_timed.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
merge_operators.h garbage collect tombstones in merge operator 2017-08-31 10:11:54 -07:00
object_registry_test.cc Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
util_merge_operators_test.cc Change RocksDB License 2017-07-15 16:11:23 -07:00