7062d0ea68
Summary: In the current implementation, perf_context.db_mutex_lock_nanos and perf_context.db_condition_wait_nanos also include the mutex-wait time other than DB Mutex. This patch fix this issue by incrementing the counters only when it detects a DB mutex. Test Plan: perf_context_test Reviewers: anthony, IslamAbdelRahman, sdong, igor Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D48555
80 lines
2.3 KiB
C++
80 lines
2.3 KiB
C++
// Copyright (c) 2015, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
#include "util/instrumented_mutex.h"
|
|
#include "util/perf_context_imp.h"
|
|
#include "util/thread_status_util.h"
|
|
|
|
namespace rocksdb {
|
|
void InstrumentedMutex::Lock() {
|
|
PERF_CONDITIONAL_TIMER_GUARD(db_mutex_lock_nanos,
|
|
stats_code_ == DB_MUTEX_WAIT_MICROS);
|
|
uint64_t wait_time_micros = 0;
|
|
if (env_ != nullptr && stats_ != nullptr) {
|
|
{
|
|
StopWatch sw(env_, nullptr, 0, &wait_time_micros);
|
|
LockInternal();
|
|
}
|
|
RecordTick(stats_, stats_code_, wait_time_micros);
|
|
} else {
|
|
LockInternal();
|
|
}
|
|
}
|
|
|
|
void InstrumentedMutex::LockInternal() {
|
|
#ifndef NDEBUG
|
|
ThreadStatusUtil::TEST_StateDelay(ThreadStatus::STATE_MUTEX_WAIT);
|
|
#endif
|
|
mutex_.Lock();
|
|
}
|
|
|
|
void InstrumentedCondVar::Wait() {
|
|
PERF_CONDITIONAL_TIMER_GUARD(db_condition_wait_nanos,
|
|
stats_code_ == DB_MUTEX_WAIT_MICROS);
|
|
uint64_t wait_time_micros = 0;
|
|
if (env_ != nullptr && stats_ != nullptr) {
|
|
{
|
|
StopWatch sw(env_, nullptr, 0, &wait_time_micros);
|
|
WaitInternal();
|
|
}
|
|
RecordTick(stats_, stats_code_, wait_time_micros);
|
|
} else {
|
|
WaitInternal();
|
|
}
|
|
}
|
|
|
|
void InstrumentedCondVar::WaitInternal() {
|
|
#ifndef NDEBUG
|
|
ThreadStatusUtil::TEST_StateDelay(ThreadStatus::STATE_MUTEX_WAIT);
|
|
#endif
|
|
cond_.Wait();
|
|
}
|
|
|
|
bool InstrumentedCondVar::TimedWait(uint64_t abs_time_us) {
|
|
PERF_CONDITIONAL_TIMER_GUARD(db_condition_wait_nanos,
|
|
stats_code_ == DB_MUTEX_WAIT_MICROS);
|
|
uint64_t wait_time_micros = 0;
|
|
bool result = false;
|
|
if (env_ != nullptr && stats_ != nullptr) {
|
|
{
|
|
StopWatch sw(env_, nullptr, 0, &wait_time_micros);
|
|
result = TimedWaitInternal(abs_time_us);
|
|
}
|
|
RecordTick(stats_, stats_code_, wait_time_micros);
|
|
} else {
|
|
result = TimedWaitInternal(abs_time_us);
|
|
}
|
|
return result;
|
|
}
|
|
|
|
bool InstrumentedCondVar::TimedWaitInternal(uint64_t abs_time_us) {
|
|
#ifndef NDEBUG
|
|
ThreadStatusUtil::TEST_StateDelay(ThreadStatus::STATE_MUTEX_WAIT);
|
|
#endif
|
|
return cond_.TimedWait(abs_time_us);
|
|
}
|
|
|
|
} // namespace rocksdb
|