b4b69e4f77
Summary: Our existing test notation is very similar to what is used in gtest. It makes it easy to adopt what is different. In this diff I modify existing [[ https://code.google.com/p/googletest/wiki/Primer#Test_Fixtures:_Using_the_Same_Data_Configuration_for_Multiple_Te | test fixture ]] classes to inherit from `testing::Test`. Also for unit tests that use fixture class, `TEST` is replaced with `TEST_F` as required in gtest. There are several custom `main` functions in our existing tests. To make this transition easier, I modify all `main` functions to fallow gtest notation. But eventually we can remove them and use implementation of `main` that gtest provides. ```lang=bash % cat ~/transform #!/bin/sh files=$(git ls-files '*test\.cc') for file in $files do if grep -q "rocksdb::test::RunAllTests()" $file then if grep -Eq '^class \w+Test {' $file then perl -pi -e 's/^(class \w+Test) {/${1}: public testing::Test {/g' $file perl -pi -e 's/^(TEST)/${1}_F/g' $file fi perl -pi -e 's/(int main.*\{)/${1}::testing::InitGoogleTest(&argc, argv);/g' $file perl -pi -e 's/rocksdb::test::RunAllTests/RUN_ALL_TESTS/g' $file fi done % sh ~/transform % make format ``` Second iteration of this diff contains only scripted changes. Third iteration contains manual changes to fix last errors and make it compilable. Test Plan: Build and notice no errors. ```lang=bash % USE_CLANG=1 make check -j55 ``` Tests are still testing. Reviewers: meyering, sdong, rven, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D35157
181 lines
5.7 KiB
C++
181 lines
5.7 KiB
C++
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#include "db/filename.h"
|
|
|
|
#include "db/dbformat.h"
|
|
#include "port/port.h"
|
|
#include "util/logging.h"
|
|
#include "util/testharness.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class FileNameTest : public testing::Test {};
|
|
|
|
TEST_F(FileNameTest, Parse) {
|
|
Slice db;
|
|
FileType type;
|
|
uint64_t number;
|
|
|
|
char kDefautInfoLogDir = 1;
|
|
char kDifferentInfoLogDir = 2;
|
|
char kNoCheckLogDir = 4;
|
|
char kAllMode = kDefautInfoLogDir | kDifferentInfoLogDir | kNoCheckLogDir;
|
|
|
|
// Successful parses
|
|
static struct {
|
|
const char* fname;
|
|
uint64_t number;
|
|
FileType type;
|
|
char mode;
|
|
} cases[] = {
|
|
{"100.log", 100, kLogFile, kAllMode},
|
|
{"0.log", 0, kLogFile, kAllMode},
|
|
{"0.sst", 0, kTableFile, kAllMode},
|
|
{"CURRENT", 0, kCurrentFile, kAllMode},
|
|
{"LOCK", 0, kDBLockFile, kAllMode},
|
|
{"MANIFEST-2", 2, kDescriptorFile, kAllMode},
|
|
{"MANIFEST-7", 7, kDescriptorFile, kAllMode},
|
|
{"METADB-2", 2, kMetaDatabase, kAllMode},
|
|
{"METADB-7", 7, kMetaDatabase, kAllMode},
|
|
{"LOG", 0, kInfoLogFile, kDefautInfoLogDir},
|
|
{"LOG.old", 0, kInfoLogFile, kDefautInfoLogDir},
|
|
{"LOG.old.6688", 6688, kInfoLogFile, kDefautInfoLogDir},
|
|
{"rocksdb_dir_LOG", 0, kInfoLogFile, kDifferentInfoLogDir},
|
|
{"rocksdb_dir_LOG.old", 0, kInfoLogFile, kDifferentInfoLogDir},
|
|
{"rocksdb_dir_LOG.old.6688", 6688, kInfoLogFile, kDifferentInfoLogDir},
|
|
{"18446744073709551615.log", 18446744073709551615ull, kLogFile,
|
|
kAllMode}, };
|
|
for (char mode : {kDifferentInfoLogDir, kDefautInfoLogDir, kNoCheckLogDir}) {
|
|
for (unsigned int i = 0; i < sizeof(cases) / sizeof(cases[0]); i++) {
|
|
InfoLogPrefix info_log_prefix(mode != kDefautInfoLogDir, "/rocksdb/dir");
|
|
if (cases[i].mode & mode) {
|
|
std::string f = cases[i].fname;
|
|
if (mode == kNoCheckLogDir) {
|
|
ASSERT_TRUE(ParseFileName(f, &number, &type)) << f;
|
|
} else {
|
|
ASSERT_TRUE(ParseFileName(f, &number, info_log_prefix.prefix, &type))
|
|
<< f;
|
|
}
|
|
ASSERT_EQ(cases[i].type, type) << f;
|
|
ASSERT_EQ(cases[i].number, number) << f;
|
|
}
|
|
}
|
|
}
|
|
|
|
// Errors
|
|
static const char* errors[] = {
|
|
"",
|
|
"foo",
|
|
"foo-dx-100.log",
|
|
".log",
|
|
"",
|
|
"manifest",
|
|
"CURREN",
|
|
"CURRENTX",
|
|
"MANIFES",
|
|
"MANIFEST",
|
|
"MANIFEST-",
|
|
"XMANIFEST-3",
|
|
"MANIFEST-3x",
|
|
"META",
|
|
"METADB",
|
|
"METADB-",
|
|
"XMETADB-3",
|
|
"METADB-3x",
|
|
"LOC",
|
|
"LOCKx",
|
|
"LO",
|
|
"LOGx",
|
|
"18446744073709551616.log",
|
|
"184467440737095516150.log",
|
|
"100",
|
|
"100.",
|
|
"100.lop"
|
|
};
|
|
for (unsigned int i = 0; i < sizeof(errors) / sizeof(errors[0]); i++) {
|
|
std::string f = errors[i];
|
|
ASSERT_TRUE(!ParseFileName(f, &number, &type)) << f;
|
|
};
|
|
}
|
|
|
|
TEST_F(FileNameTest, InfoLogFileName) {
|
|
std::string dbname = ("/data/rocksdb");
|
|
std::string db_absolute_path;
|
|
Env::Default()->GetAbsolutePath(dbname, &db_absolute_path);
|
|
|
|
ASSERT_EQ("/data/rocksdb/LOG", InfoLogFileName(dbname, db_absolute_path, ""));
|
|
ASSERT_EQ("/data/rocksdb/LOG.old.666",
|
|
OldInfoLogFileName(dbname, 666u, db_absolute_path, ""));
|
|
|
|
ASSERT_EQ("/data/rocksdb_log/data_rocksdb_LOG",
|
|
InfoLogFileName(dbname, db_absolute_path, "/data/rocksdb_log"));
|
|
ASSERT_EQ(
|
|
"/data/rocksdb_log/data_rocksdb_LOG.old.666",
|
|
OldInfoLogFileName(dbname, 666u, db_absolute_path, "/data/rocksdb_log"));
|
|
}
|
|
|
|
TEST_F(FileNameTest, Construction) {
|
|
uint64_t number;
|
|
FileType type;
|
|
std::string fname;
|
|
|
|
fname = CurrentFileName("foo");
|
|
ASSERT_EQ("foo/", std::string(fname.data(), 4));
|
|
ASSERT_TRUE(ParseFileName(fname.c_str() + 4, &number, &type));
|
|
ASSERT_EQ(0U, number);
|
|
ASSERT_EQ(kCurrentFile, type);
|
|
|
|
fname = LockFileName("foo");
|
|
ASSERT_EQ("foo/", std::string(fname.data(), 4));
|
|
ASSERT_TRUE(ParseFileName(fname.c_str() + 4, &number, &type));
|
|
ASSERT_EQ(0U, number);
|
|
ASSERT_EQ(kDBLockFile, type);
|
|
|
|
fname = LogFileName("foo", 192);
|
|
ASSERT_EQ("foo/", std::string(fname.data(), 4));
|
|
ASSERT_TRUE(ParseFileName(fname.c_str() + 4, &number, &type));
|
|
ASSERT_EQ(192U, number);
|
|
ASSERT_EQ(kLogFile, type);
|
|
|
|
fname = TableFileName({DbPath("bar", 0)}, 200, 0);
|
|
std::string fname1 =
|
|
TableFileName({DbPath("foo", 0), DbPath("bar", 0)}, 200, 1);
|
|
ASSERT_EQ(fname, fname1);
|
|
ASSERT_EQ("bar/", std::string(fname.data(), 4));
|
|
ASSERT_TRUE(ParseFileName(fname.c_str() + 4, &number, &type));
|
|
ASSERT_EQ(200U, number);
|
|
ASSERT_EQ(kTableFile, type);
|
|
|
|
fname = DescriptorFileName("bar", 100);
|
|
ASSERT_EQ("bar/", std::string(fname.data(), 4));
|
|
ASSERT_TRUE(ParseFileName(fname.c_str() + 4, &number, &type));
|
|
ASSERT_EQ(100U, number);
|
|
ASSERT_EQ(kDescriptorFile, type);
|
|
|
|
fname = TempFileName("tmp", 999);
|
|
ASSERT_EQ("tmp/", std::string(fname.data(), 4));
|
|
ASSERT_TRUE(ParseFileName(fname.c_str() + 4, &number, &type));
|
|
ASSERT_EQ(999U, number);
|
|
ASSERT_EQ(kTempFile, type);
|
|
|
|
fname = MetaDatabaseName("met", 100);
|
|
ASSERT_EQ("met/", std::string(fname.data(), 4));
|
|
ASSERT_TRUE(ParseFileName(fname.c_str() + 4, &number, &type));
|
|
ASSERT_EQ(100U, number);
|
|
ASSERT_EQ(kMetaDatabase, type);
|
|
}
|
|
|
|
} // namespace rocksdb
|
|
|
|
int main(int argc, char** argv) {
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
return RUN_ALL_TESTS();
|
|
}
|