andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
d7ae42b0f8
rocksdb/table
History
Marton Trencseni 522de4f59e Adding pin_l0_filter_and_index_blocks_in_cache feature. 
Summary:
When a block based table file is opened, if prefetch_index_and_filter is true, it will prefetch the index and filter blocks, putting them into the block cache.
What this feature adds: when a L0 block based table file is opened, if pin_l0_filter_and_index_blocks_in_cache is true in the options (and prefetch_index_and_filter is true), then the filter and index blocks aren't released back to the block cache at the end of BlockBasedTableReader::Open(). Instead the table reader takes ownership of them, hence pinning them, ie. the LRU cache will never push them out. Meanwhile in the table reader, further accesses will not hit the block cache, thus avoiding lock contention.
When the table reader is destroyed, it releases the pinned blocks (if there were any). This has to happen before the cache is destroyed, so I had to introduce a TableReader::Close(), to guarantee the order of destruction.

Test Plan:
Added two unit tests for this. Existing unit tests run fine (default is pin_l0_filter_and_index_blocks_in_cache=false).

DISABLE_JEMALLOC=1 OPT=-g make all valgrind_check -j32
  Mac: OK.
  Linux: with D55287 patched in it's OK.

Reviewers: sdong

Reviewed By: sdong

Subscribers: andrewkr, leveldb, dhruba

Differential Revision: https://reviews.facebook.net/D54801
2016-03-17 22:40:01 +00:00
..
adaptive_table_factory.cc Pass column family ID to table property collector 2015-10-09 14:36:51 -07:00
adaptive_table_factory.h Pass column family ID to table property collector 2015-10-09 14:36:51 -07:00
block_based_filter_block_test.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_based_filter_block.cc Revert "Revert "Fixed the bug when both whole_key_filtering and prefix_extractor are set."" 2016-02-22 16:33:26 -08:00
block_based_filter_block.h Revert "Revert "Fixed the bug when both whole_key_filtering and prefix_extractor are set."" 2016-02-22 16:33:26 -08:00
block_based_table_builder.cc Cache to have an option to fail Cache::Insert() when full 2016-03-10 17:35:19 -08:00
block_based_table_builder.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_based_table_factory.cc Adding pin_l0_filter_and_index_blocks_in_cache feature. 2016-03-17 22:40:01 +00:00
block_based_table_factory.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_based_table_reader.cc Adding pin_l0_filter_and_index_blocks_in_cache feature. 2016-03-17 22:40:01 +00:00
block_based_table_reader.h Adding pin_l0_filter_and_index_blocks_in_cache feature. 2016-03-17 22:40:01 +00:00
block_builder.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_builder.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_hash_index_test.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_hash_index.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_hash_index.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_prefix_index.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_prefix_index.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block_test.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
block.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
bloom_block.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
bloom_block.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
cuckoo_table_builder_test.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
cuckoo_table_builder.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
cuckoo_table_builder.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
cuckoo_table_factory.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
cuckoo_table_factory.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
cuckoo_table_reader_test.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
cuckoo_table_reader.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
cuckoo_table_reader.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
filter_block.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
flush_block_policy.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
format.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
format.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
full_filter_block_test.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
full_filter_block.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
full_filter_block.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
get_context.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
get_context.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
internal_iterator.h Add Iterator Property rocksdb.iterator.version_number 2016-03-02 16:23:59 -08:00
iter_heap.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
iterator_wrapper.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
iterator.cc Rename iterator property "rocksdb.iterator.is.key.pinned" => "rocksdb.iterator.is-key-pinned" 2016-03-01 13:47:12 -08:00
merger_test.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
merger.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
merger.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
meta_blocks.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
meta_blocks.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
mock_table.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
mock_table.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
plain_table_builder.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
plain_table_builder.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
plain_table_factory.cc Merge pull request #805 from SherlockNoMad/OptionHelperFix 2015-11-17 16:24:52 -08:00
plain_table_factory.h Fix build broken by previous commit of "option helper refactor" 2015-11-17 16:52:54 -08:00
plain_table_index.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
plain_table_index.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
plain_table_key_coding.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
plain_table_key_coding.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
plain_table_reader.cc Skip bottom-level filter block caching when hit-optimized 2015-12-23 10:15:07 -08:00
plain_table_reader.h Skip bottom-level filter block caching when hit-optimized 2015-12-23 10:15:07 -08:00
scoped_arena_iterator.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
sst_file_writer.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
table_builder.h Adding pin_l0_filter_and_index_blocks_in_cache feature. 2016-03-17 22:40:01 +00:00
table_properties_internal.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
table_properties.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
table_reader_bench.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
table_reader.h Adding pin_l0_filter_and_index_blocks_in_cache feature. 2016-03-17 22:40:01 +00:00
table_test.cc Adding pin_l0_filter_and_index_blocks_in_cache feature. 2016-03-17 22:40:01 +00:00
two_level_iterator.cc Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00
two_level_iterator.h Updated all copyright headers to the new format. 2016-02-09 15:12:00 -08:00