Andrew Kryczka
dd29ad4223
Separate internal and user key comparators in BlockIter (#6944)
Summary:
Replace `BlockIter::comparator_` and `IndexBlockIter::user_comparator_wrapper_` with a concrete `UserComparatorWrapper` and `InternalKeyComparator`. The motivation for this change was the inconvenience of not knowing the concrete type of `BlockIter::comparator_`, which prevented calling specialized internal key comparison functions to optimize comparison of keys with global seqno applied.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6944
Test Plan:
benchmark setup -- single file DBs, in-memory, no compression. "normal_db"
created by regular flush; "ingestion_db" created by ingesting a file. Both
DBs have same contents.
```
$ TEST_TMPDIR=/dev/shm/normal_db/ ./db_bench -benchmarks=fillrandom,compact -write_buffer_size=10485760000 -disable_auto_compactions=true -compression_type=none -num=1000000
$ ./ldb write_extern_sst ./tmp.sst --db=/dev/shm/ingestion_db/dbbench/ --compression_type=no --hex --create_if_missing < <(./sst_dump --command=scan --output_hex --file=/dev/shm/normal_db/dbbench/000007.sst | awk 'began {print "0x" substr($1, 2, length($1) - 2), "==>", "0x" $5} ; /^Sst file format: block-based/ {began=1}')
$ ./ldb ingest_extern_sst ./tmp.sst --db=/dev/shm/ingestion_db/dbbench/
```
benchmark run command:
```
$ TEST_TMPDIR=/dev/shm/$DB/ ./db_bench -benchmarks=seekrandom -seek_nexts=$SEEK_NEXT -use_existing_db=true -cache_index_and_filter_blocks=false -num=1000000 -cache_size=0 -threads=1 -reads=200000000 -mmap_read=1 -verify_checksum=false
```
results: perf improved marginally for ingestion_db and did not change significantly for normal_db:
SEEK_NEXT | DB | code | ops/sec | % change
-- | -- | -- | -- | --
0 | normal_db | master | 350880 |
0 | normal_db | PR6944 | 351040 | 0.0
0 | ingestion_db | master | 343255 |
0 | ingestion_db | PR6944 | 349424 | 1.8
10 | normal_db | master | 218711 |
10 | normal_db | PR6944 | 217892 | -0.4
10 | ingestion_db | master | 220334 |
10 | ingestion_db | PR6944 | 226437 | 2.8
Reviewed By: pdillinger
Differential Revision: D21924676
Pulled By: ajkr
fbshipit-source-id: ea4288a2eefa8112eb6c651a671c1de18c12e538
2020-07-07 17:26:16 -07:00
..
2020-07-07 17:26:16 -07:00
2020-06-29 14:53:17 -07:00
2020-02-20 12:09:57 -08:00
2020-06-29 14:53:17 -07:00
2020-06-29 14:53:17 -07:00
2020-06-19 16:18:24 -07:00
2020-06-17 10:57:40 -07:00
2020-06-29 14:53:17 -07:00
2020-06-29 14:53:17 -07:00
2020-04-15 17:40:44 -07:00
2020-04-15 17:40:44 -07:00
2020-03-12 21:41:50 -07:00
2020-06-29 14:53:17 -07:00
2020-07-07 17:26:16 -07:00
2020-06-29 14:53:17 -07:00
2020-04-01 16:40:18 -07:00
2020-04-01 16:40:18 -07:00
2020-03-16 12:20:50 -07:00
2020-03-16 12:20:50 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-07-07 17:26:16 -07:00
2020-02-20 12:09:57 -08:00
2020-07-07 17:26:16 -07:00
2020-07-07 17:26:16 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-07-07 17:26:16 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-06-29 14:53:17 -07:00
2020-06-22 13:32:07 -07:00
2020-06-26 11:14:08 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-06-29 14:53:17 -07:00
2020-06-29 14:53:17 -07:00
2020-07-07 17:26:16 -07:00
2020-06-29 14:53:17 -07:00
2020-07-02 13:30:41 -07:00
2020-02-20 12:09:57 -08:00
2020-03-12 21:41:50 -07:00
2020-03-12 21:41:50 -07:00
2020-06-02 12:30:23 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-06-03 15:55:03 -07:00
2020-07-07 17:26:16 -07:00
2020-06-29 14:53:17 -07:00
2020-03-17 12:33:10 -07:00
2020-06-05 11:08:25 -07:00
2020-07-07 17:26:16 -07:00
2020-06-29 14:53:17 -07:00
2020-06-19 16:18:24 -07:00
2020-06-19 16:18:24 -07:00
2020-06-29 14:53:17 -07:00
2020-06-29 14:53:17 -07:00