rocksdb/tools
Igor Canadi 88841bd007 Explicitly cast char to signed char in Hash()
Summary:
The compilers we use treat char as signed. However, this is not guarantee of C standard and some compilers (for ARM platform for example), treat char as unsigned. Code that assumes that char is either signed or unsigned is wrong.

This change explicitly casts the char to signed version. This will not break any of our use cases on x86, which, I believe are all of them. In case somebody out there is using RocksDB on ARM AND using bloom filters, they're going to have a bad time. However, it is very unlikely that this is the case.

Test Plan: sanity test with previous commit (with new sanity test)

Reviewers: yhchiang, ljin, sdong

Reviewed By: ljin

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D22767
2014-09-08 18:57:40 -07:00
..
auto_sanity_test.sh Explicitly cast char to signed char in Hash() 2014-09-08 18:57:40 -07:00
blob_store_bench.cc Rename "benchmark" back to "bench". 2014-04-21 13:12:15 -07:00
db_crashtest2.py Remove seek compaction 2014-06-20 10:23:02 +02:00
db_crashtest.py Remove seek compaction 2014-06-20 10:23:02 +02:00
db_repl_stress.cc Make RocksDB work with newer gflags 2014-05-08 17:25:13 -07:00
db_sanity_test.cc Explicitly cast char to signed char in Hash() 2014-09-08 18:57:40 -07:00
db_stress.cc Implement full filter for block based table. 2014-09-08 10:37:05 -07:00
ldb_test.py Consistency Check Function 2014-03-20 13:42:45 -07:00
ldb.cc Revert "Don't compile ldb tool into static library" 2014-04-15 11:29:02 -07:00
reduce_levels_test.cc Fix compile error in reduce_levels_test. 2014-06-23 17:48:20 -06:00
sst_dump.cc introduce ImmutableOptions 2014-09-04 16:18:36 -07:00