andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
dfbe52e099
rocksdb/env
History
Anand Ananthabhotla dfbe52e099 Fix the Logger::Close() and DBImpl::Close() design pattern 
Summary:
The recent Logger::Close() and DBImpl::Close() implementation rely on
calling the CloseImpl() virtual function from the destructor, which will
not work. Refactor the implementation to have a private close helper
function in derived classes that can be called by both CloseImpl() and
the destructor.
Closes https://github.com/facebook/rocksdb/pull/3528

Reviewed By: gfosco

Differential Revision: D7049303

Pulled By: anand1976

fbshipit-source-id: 76a64cbf403209216dfe4864ecf96b5d7f3db9f4
2018-02-23 13:57:26 -08:00
..
env_basic_test.cc Move some files under util/ to separate dirs 2017-04-05 19:09:16 -07:00
env_chroot.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
env_chroot.h Change RocksDB License 2017-07-15 16:11:23 -07:00
env_encryption.cc Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
env_hdfs.cc Fix the Logger::Close() and DBImpl::Close() design pattern 2018-02-23 13:57:26 -08:00
env_posix.cc Several small "fixes" 2018-02-15 16:57:37 -08:00
env_test.cc Fix the Logger::Close() and DBImpl::Close() design pattern 2018-02-23 13:57:26 -08:00
env.cc Fix the Logger::Close() and DBImpl::Close() design pattern 2018-02-23 13:57:26 -08:00
io_posix.cc Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
io_posix.h Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
mock_env_test.cc Move some files under util/ to separate dirs 2017-04-05 19:09:16 -07:00
mock_env.cc Back out "[codemod] - comment out unused parameters" 2018-02-22 12:43:17 -08:00
mock_env.h Change RocksDB License 2017-07-15 16:11:23 -07:00
posix_logger.h Fix the Logger::Close() and DBImpl::Close() design pattern 2018-02-23 13:57:26 -08:00