7eebe6d38a
Summary: The mechanism to mark files for compaction is most commonly used in delete-triggered compaction. This PR adds an option to exercise the marking mechanism on random files created by db_stress. This PR also enables that option in db_crashtest.py on its db_stress runs at random. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7231 Test Plan: - ran some minified crash tests; verified they succeed and we see `"compaction_reason": "FilesMarkedForCompaction"` regularly in the logs. ``` $ TEST_TMPDIR=/dev/shm python tools/db_crashtest.py blackbox --duration=600 --interval=30 --max_key=10000000 --write_buffer_size=1048576 --target_file_size_base=1048576 --max_bytes_for_level_base=4194304 --value_size_mult=33 $ TEST_TMPDIR=/dev/shm python tools/db_crashtest.py whitebox --duration=600 --interval=30 --max_key=1000000 --write_buffer_size=1048576 --target_file_size_base=1048576 --max_bytes_for_level_base=4194304 --value_size_mult=33 --random_kill_odd=8887 ``` Reviewed By: anand1976 Differential Revision: D23025156 Pulled By: ajkr fbshipit-source-id: a404c467ebc12afa94dae35956ea9b372f592a96
65 lines
2.1 KiB
C++
65 lines
2.1 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include "rocksdb/table.h"
|
|
#include "util/gflags_compat.h"
|
|
|
|
DECLARE_int32(mark_for_compaction_one_file_in);
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// A `DbStressTablePropertiesCollector` ignores what keys/values were added to
|
|
// the table, adds no properties to the table, and decides at random whether the
|
|
// table will be marked for compaction according to
|
|
// `FLAGS_mark_for_compaction_one_file_in`.
|
|
class DbStressTablePropertiesCollector : public TablePropertiesCollector {
|
|
public:
|
|
DbStressTablePropertiesCollector()
|
|
: need_compact_(Random::GetTLSInstance()->OneInOpt(
|
|
FLAGS_mark_for_compaction_one_file_in)) {}
|
|
|
|
virtual Status AddUserKey(const Slice& /* key */, const Slice& /* value */,
|
|
EntryType /*type*/, SequenceNumber /*seq*/,
|
|
uint64_t /*file_size*/) override {
|
|
return Status::OK();
|
|
}
|
|
|
|
virtual Status Finish(UserCollectedProperties* /* properties */) override {
|
|
return Status::OK();
|
|
}
|
|
|
|
virtual UserCollectedProperties GetReadableProperties() const override {
|
|
return UserCollectedProperties{};
|
|
}
|
|
|
|
virtual const char* Name() const override {
|
|
return "DbStressTablePropertiesCollector";
|
|
}
|
|
|
|
virtual bool NeedCompact() const override { return need_compact_; }
|
|
|
|
private:
|
|
const bool need_compact_;
|
|
};
|
|
|
|
// A `DbStressTablePropertiesCollectorFactory` creates
|
|
// `DbStressTablePropertiesCollectorFactory`s.
|
|
class DbStressTablePropertiesCollectorFactory
|
|
: public TablePropertiesCollectorFactory {
|
|
public:
|
|
virtual TablePropertiesCollector* CreateTablePropertiesCollector(
|
|
TablePropertiesCollectorFactory::Context /* context */) override {
|
|
return new DbStressTablePropertiesCollector();
|
|
}
|
|
|
|
virtual const char* Name() const override {
|
|
return "DbStressTablePropertiesCollectorFactory";
|
|
}
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|