Summary: Previously, the `MemPurge` sampling function was assessing whether a random entry from a memtable was garbage or not by simply querying the given memtable (see https://github.com/facebook/rocksdb/issues/8628 for more details). In this diff, I am updating the sampling function by querying not only the memtable the entry was drawn from, but also all subsequent memtables that have a greater memtable ID. I also added the size of the value for KV entries in the payload/useful payload estimates (which was also one of the reasons why sampling was not as good as mempurging all the time in terms of L0 SST files reduction). Once these changes were made, I was able to clean obsolete objects and functions from the `MemtableList` struct, and did a bit of cleanup everywhere. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8656 Reviewed By: pdillinger Differential Revision: D30288583 Pulled By: bjlemaire fbshipit-source-id: 7646a545ec56f4715949daa59ab5eee74540feb3 |
||
---|---|---|
.. | ||
alloc_tracker.cc | ||
hash_linklist_rep.cc | ||
hash_linklist_rep.h | ||
hash_skiplist_rep.cc | ||
hash_skiplist_rep.h | ||
inlineskiplist_test.cc | ||
inlineskiplist.h | ||
memtablerep_bench.cc | ||
skiplist_test.cc | ||
skiplist.h | ||
skiplistrep.cc | ||
stl_wrappers.h | ||
vectorrep.cc | ||
write_buffer_manager_test.cc | ||
write_buffer_manager.cc |