e5a1b727c0
Summary: While GC, blob DB use optimistic transaction to delete or replace the index entry in LSM, to guarantee correctness if there's a normal write writing to the same key. However, the previous implementation doesn't call SetSnapshot() nor use GetForUpdate() of transaction API, instead it do its own sequence number checking before beginning the transaction. A normal write can sneak in after the sequence number check and overwrite the key, and the GC will delete or relocate the old version of the key by mistake. Update the code to property use GetForUpdate() to check the existing index entry. After the patch the sequence number store with each blob record is useless, So I'm considering remove the sequence number from blob record, in another patch. Closes https://github.com/facebook/rocksdb/pull/2703 Differential Revision: D5589178 Pulled By: yiwu-arbug fbshipit-source-id: 8dc960cd5f4e61b36024ba7c32d05584ce149c24 |
||
|---|---|---|
| .. | ||
| blob_db_impl.cc | ||
| blob_db_impl.h | ||
| blob_db_test.cc | ||
| blob_db.cc | ||
| blob_db.h | ||
| blob_dump_tool.cc | ||
| blob_dump_tool.h | ||
| blob_file.cc | ||
| blob_log_format.cc | ||
| blob_log_format.h | ||
| blob_log_reader.cc | ||
| blob_log_reader.h | ||
| blob_log_writer.cc | ||
| blob_log_writer.h | ||
| ttl_extractor.cc | ||