d0f1b49ab6
Summary: Currently, the only way to close an open DB is to destroy the DB object. There is no way for the caller to know the status. In one instance, the destructor encountered an error due to failure to close a log file on HDFS. In order to prevent silent failures, we add DB::Close() that calls CloseImpl() which must be implemented by its descendants. The main failure point in the destructor is closing the log file. This patch also adds a Close() entry point to Logger in order to get status. When DBOptions::info_log is allocated and owned by the DBImpl, it is explicitly closed by DBImpl::CloseImpl(). Closes https://github.com/facebook/rocksdb/pull/3348 Differential Revision: D6698158 Pulled By: anand1976 fbshipit-source-id: 9468e2892553eb09c4c41b8723f590c0dbd8ab7d
142 lines
4.1 KiB
C++
142 lines
4.1 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Logger implementation that can be shared by all environments
|
|
// where enough posix functionality is available.
|
|
|
|
#pragma once
|
|
#include <list>
|
|
#include <string>
|
|
|
|
#include "port/port.h"
|
|
#include "port/util_logger.h"
|
|
#include "util/filename.h"
|
|
#include "util/mutexlock.h"
|
|
#include "util/sync_point.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
#ifndef ROCKSDB_LITE
|
|
// Rolls the log file by size and/or time
|
|
class AutoRollLogger : public Logger {
|
|
public:
|
|
AutoRollLogger(Env* env, const std::string& dbname,
|
|
const std::string& db_log_dir, size_t log_max_size,
|
|
size_t log_file_time_to_roll,
|
|
const InfoLogLevel log_level = InfoLogLevel::INFO_LEVEL)
|
|
: Logger(log_level),
|
|
dbname_(dbname),
|
|
db_log_dir_(db_log_dir),
|
|
env_(env),
|
|
status_(Status::OK()),
|
|
kMaxLogFileSize(log_max_size),
|
|
kLogFileTimeToRoll(log_file_time_to_roll),
|
|
cached_now(static_cast<uint64_t>(env_->NowMicros() * 1e-6)),
|
|
ctime_(cached_now),
|
|
cached_now_access_count(0),
|
|
call_NowMicros_every_N_records_(100),
|
|
mutex_() {
|
|
env->GetAbsolutePath(dbname, &db_absolute_path_);
|
|
log_fname_ = InfoLogFileName(dbname_, db_absolute_path_, db_log_dir_);
|
|
RollLogFile();
|
|
ResetLogger();
|
|
}
|
|
|
|
using Logger::Logv;
|
|
void Logv(const char* format, va_list ap) override;
|
|
|
|
// Write a header entry to the log. All header information will be written
|
|
// again every time the log rolls over.
|
|
virtual void LogHeader(const char* format, va_list ap) override;
|
|
|
|
// check if the logger has encountered any problem.
|
|
Status GetStatus() {
|
|
return status_;
|
|
}
|
|
|
|
size_t GetLogFileSize() const override {
|
|
std::shared_ptr<Logger> logger;
|
|
{
|
|
MutexLock l(&mutex_);
|
|
// pin down the current logger_ instance before releasing the mutex.
|
|
logger = logger_;
|
|
}
|
|
return logger->GetLogFileSize();
|
|
}
|
|
|
|
void Flush() override {
|
|
std::shared_ptr<Logger> logger;
|
|
{
|
|
MutexLock l(&mutex_);
|
|
// pin down the current logger_ instance before releasing the mutex.
|
|
logger = logger_;
|
|
}
|
|
TEST_SYNC_POINT("AutoRollLogger::Flush:PinnedLogger");
|
|
if (logger) {
|
|
logger->Flush();
|
|
}
|
|
}
|
|
|
|
virtual ~AutoRollLogger() {
|
|
}
|
|
|
|
void SetCallNowMicrosEveryNRecords(uint64_t call_NowMicros_every_N_records) {
|
|
call_NowMicros_every_N_records_ = call_NowMicros_every_N_records;
|
|
}
|
|
|
|
// Expose the log file path for testing purpose
|
|
std::string TEST_log_fname() const {
|
|
return log_fname_;
|
|
}
|
|
|
|
uint64_t TEST_ctime() const { return ctime_; }
|
|
|
|
private:
|
|
bool LogExpired();
|
|
Status ResetLogger();
|
|
void RollLogFile();
|
|
// Log message to logger without rolling
|
|
void LogInternal(const char* format, ...);
|
|
// Serialize the va_list to a string
|
|
std::string ValistToString(const char* format, va_list args) const;
|
|
// Write the logs marked as headers to the new log file
|
|
void WriteHeaderInfo();
|
|
// Implementation of Close()
|
|
virtual Status CloseImpl() override {
|
|
if (logger_) {
|
|
return logger_->Close();
|
|
} else {
|
|
return Status::OK();
|
|
}
|
|
}
|
|
|
|
std::string log_fname_; // Current active info log's file name.
|
|
std::string dbname_;
|
|
std::string db_log_dir_;
|
|
std::string db_absolute_path_;
|
|
Env* env_;
|
|
std::shared_ptr<Logger> logger_;
|
|
// current status of the logger
|
|
Status status_;
|
|
const size_t kMaxLogFileSize;
|
|
const size_t kLogFileTimeToRoll;
|
|
// header information
|
|
std::list<std::string> headers_;
|
|
// to avoid frequent env->NowMicros() calls, we cached the current time
|
|
uint64_t cached_now;
|
|
uint64_t ctime_;
|
|
uint64_t cached_now_access_count;
|
|
uint64_t call_NowMicros_every_N_records_;
|
|
mutable port::Mutex mutex_;
|
|
};
|
|
#endif // !ROCKSDB_LITE
|
|
|
|
// Facade to craete logger automatically
|
|
Status CreateLoggerFromOptions(const std::string& dbname,
|
|
const DBOptions& options,
|
|
std::shared_ptr<Logger>* logger);
|
|
|
|
} // namespace rocksdb
|