andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/table
History
anand76 cb1dc29655 Fix a buffer overrun problem in BlockBasedTable::MultiGet (#6014) 
Summary:
The calculation in BlockBasedTable::MultiGet for the required buffer length for reading in compressed blocks is incorrect. It needs to take the 5-byte block trailer into account.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6014

Test Plan: Add a unit test DBBasicTest.MultiGetBufferOverrun that fails in asan_check before the fix, and passes after.

Differential Revision: D18412753

Pulled By: anand1976

fbshipit-source-id: 754dfb66be1d5f161a7efdf87be872198c7e3b72
2019-11-12 10:57:32 -08:00
..
adaptive
Organizing rocksdb/table directory by format
2019-05-30 14:51:11 -07:00
block_based
Fix a buffer overrun problem in BlockBasedTable::MultiGet (#6014)
2019-11-12 10:57:32 -08:00
cuckoo
Use delete to disable automatic generated methods. (#5009)
2019-09-11 18:09:00 -07:00
plain
Refactor some confusing logic in PlainTableReader
2019-09-13 10:26:36 -07:00
block_fetcher.cc
Add an option to put first key of each sst block in the index (#5289)
2019-06-24 20:54:04 -07:00
block_fetcher.h
Combine the read-ahead logic for user reads and compaction reads (#5431)
2019-06-19 14:10:46 -07:00
cleanable_test.cc
Move test related files under util/ to test_util/ (#5377)
2019-05-30 11:25:51 -07:00
format.cc
Add an option to put first key of each sst block in the index (#5289)
2019-06-24 20:54:04 -07:00
format.h
Fix a buffer overrun problem in BlockBasedTable::MultiGet (#6014)
2019-11-12 10:57:32 -08:00
full_filter_bits_builder.h
Refactor some confusing logic in PlainTableReader
2019-09-13 10:26:36 -07:00
get_context.cc
New API to get all merge operands for a Key (#5604)
2019-08-06 14:26:44 -07:00
get_context.h
Fix local includes
2019-08-22 16:21:47 -07:00
internal_iterator.h
Revert "Merging iterator to avoid child iterator reseek for some cases (#5286)" (#5871)
2019-10-01 14:41:58 -07:00
iter_heap.h
Make InternalKeyComparator final and directly use it in merging iterator
2017-09-11 12:04:21 -07:00
iterator_wrapper.h
Revert "Merging iterator to avoid child iterator reseek for some cases (#5286)" (#5871)
2019-10-01 14:41:58 -07:00
iterator.cc
Add an option to put first key of each sst block in the index (#5289)
2019-06-24 20:54:04 -07:00
merger_test.cc
Move test related files under util/ to test_util/ (#5377)
2019-05-30 11:25:51 -07:00
merging_iterator.cc
Fix a previous revert
2019-10-01 16:58:47 -07:00
merging_iterator.h
Index value delta encoding (#3983)
2018-08-09 16:58:40 -07:00
meta_blocks.cc
Add an option to put first key of each sst block in the index (#5289)
2019-06-24 20:54:04 -07:00
meta_blocks.h
Fix comment of function NotifyCollectTableCollectorsOnFinish (#5738)
2019-08-29 10:57:01 -07:00
mock_table.cc
Add more callers for table reader. (#5454)
2019-06-20 14:31:48 -07:00
mock_table.h
Optimizing ApproximateSize to create index iterator just once (#5693)
2019-08-16 14:18:28 -07:00
multiget_context.h
Support row cache with batched MultiGet (#5706)
2019-08-28 16:11:56 -07:00
persistent_cache_helper.cc
Organizing rocksdb/table directory by format
2019-05-30 14:51:11 -07:00
persistent_cache_helper.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
persistent_cache_options.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
scoped_arena_iterator.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
sst_file_reader_test.cc
simplify include directive involving inttypes (#5402)
2019-06-06 13:56:07 -07:00
sst_file_reader.cc
Do readahead in VerifyChecksum() (#5713)
2019-08-16 16:42:56 -07:00
sst_file_writer_collectors.h
Fix SstFileReader not able to open ingested file (#5097)
2019-03-26 10:25:18 -07:00
sst_file_writer.cc
Move some memory related files from util/ to memory/ (#5382)
2019-05-30 17:44:09 -07:00
table_builder.h
Integrate block cache tracer into db_impl (#5433)
2019-06-13 15:43:10 -07:00
table_properties_internal.h
Index value delta encoding (#3983)
2018-08-09 16:58:40 -07:00
table_properties.cc
Organizing rocksdb/table directory by format
2019-05-30 14:51:11 -07:00
table_reader_bench.cc
New API to get all merge operands for a Key (#5604)
2019-08-06 14:26:44 -07:00
table_reader_caller.h
Add more callers for table reader. (#5454)
2019-06-20 14:31:48 -07:00
table_reader.h
Do readahead in VerifyChecksum() (#5713)
2019-08-16 16:42:56 -07:00
table_test.cc
upgrade gtest 1.7.0 => 1.8.1 for json result writing
2019-09-09 11:24:11 -07:00
two_level_iterator.cc
Add an option to put first key of each sst block in the index (#5289)
2019-06-24 20:54:04 -07:00
two_level_iterator.h
Add an option to put first key of each sst block in the index (#5289)
2019-06-24 20:54:04 -07:00