andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/db
History
Alex Yang e8180f9901 added public api to schedule flush/compaction, code to prevent race with db::open 
Summary:
Fixes T8781168.

Added a new function EnableAutoCompactions in db.h to be publicly
avialable.  This allows compaction to be re-enabled after disabling it via
SetOptions

Refactored code to set the dbptr earlier on in TransactionDB::Open and DB::Open
Temporarily disable auto_compaction in TransactionDB::Open until dbptr is set to
prevent race condition.

Test Plan:
Ran make all check

verified fix on myrocks side:
was able to reproduce the seg fault with
../tools/mysqltest.sh --mem --force rocksdb.drop_table

method was to manually sleep the thread after DB::Open but before TransactionDB ptr was
assigned in transaction_db_impl.cc:
  DB::Open(db_options, dbname, column_families_copy, handles, &db);
  clock_t goal = (60000 * 10) + clock();
  while (goal > clock());
  ...dbptr(aka rdb) gets assigned below

verified my changes fixed the issue.

Also added unit test 'ToggleAutoCompaction' in transaction_test.cc

Reviewers: hermanlee4, anthony

Reviewed By: anthony

Subscribers: alex, dhruba

Differential Revision: https://reviews.facebook.net/D51147
2015-12-03 22:59:44 -08:00
..
builder.cc
Move skip_table_builder_flush to BlockBasedTableOption
2015-10-30 18:33:01 -07:00
builder.h
Move skip_table_builder_flush to BlockBasedTableOption
2015-10-30 18:33:01 -07:00
c_test.c
Deprecate CompactionFilterV2
2015-07-17 18:59:11 +02:00
c.cc
Move skip_table_builder_flush to BlockBasedTableOption
2015-10-30 18:33:01 -07:00
column_family_test.cc
Enable RocksDB to persist Options file.
2015-11-10 22:58:01 -08:00
column_family.cc
UniversalCompactionPicker::PickCompaction(): avoid to form compactions if there is no file
2015-11-16 10:32:45 -08:00
column_family.h
Total SST files size DB Property
2015-08-20 11:47:19 -07:00
compact_files_test.cc
Make sure that CompactFiles does not run two parallel Level 0 compactions
2015-11-13 12:01:00 -08:00
compacted_db_impl.cc
Remove db_impl_readonly dependency on utilities
2015-07-14 11:32:54 -07:00
compacted_db_impl.h
Remove db_impl_readonly dependency on utilities
2015-07-14 11:32:54 -07:00
compaction_iterator_test.cc
Compaction filter on merge operands
2015-10-07 09:30:03 -07:00
compaction_iterator.cc
Have a way for compaction filter to ignore snapshots
2015-11-20 15:57:26 -08:00
compaction_iterator.h
Have a way for compaction filter to ignore snapshots
2015-11-20 15:57:26 -08:00
compaction_job_stats_test.cc
No need to #ifdef test only code on windows
2015-10-22 15:15:37 -07:00
compaction_job_test.cc
log_writer: pass log number and whether recycling is enabled to ctor
2015-10-18 21:24:32 -04:00
compaction_job.cc
Move skip_table_builder_flush to BlockBasedTableOption
2015-10-30 18:33:01 -07:00
compaction_job.h
Seperate InternalIterator from Iterator
2015-10-13 15:32:13 -07:00
compaction_picker_test.cc
Fix condition for bottommost level
2015-10-05 17:40:18 -07:00
compaction_picker.cc
UniversalCompactionPicker::PickCompaction(): avoid to form compactions if there is no file
2015-11-16 10:32:45 -08:00
compaction_picker.h
Make sure that CompactFiles does not run two parallel Level 0 compactions
2015-11-13 12:01:00 -08:00
compaction.cc
CompactionFilter::Context to contain column family ID
2015-10-08 11:27:38 -07:00
compaction.h
Passing table properties to compaction callback
2015-10-09 18:10:55 -07:00
comparator_db_test.cc
Moving memtable related files from util to a new directory memtable
2015-10-16 14:10:33 -07:00
convenience.cc
move convenience.h out of utilities
2015-07-15 14:51:51 -07:00
corruption_test.cc
Switch to thread-local random for skiplist
2015-11-09 19:25:22 -08:00
cuckoo_table_db_test.cc
Block cuckoo table tests in ROCKSDB_LITE
2015-07-20 10:50:46 -07:00
db_bench.cc
Lint everything
2015-11-16 12:56:21 -08:00
db_compaction_filter_test.cc
Have a way for compaction filter to ignore snapshots
2015-11-20 15:57:26 -08:00
db_compaction_test.cc
Fix incorrect merge in db/db_compaction_test.cc
2015-12-02 14:09:09 -08:00
db_dynamic_level_test.cc
No need to #ifdef test only code on windows
2015-10-22 15:15:37 -07:00
db_filesnapshot.cc
Add wal files to Checkpoint for multiple column families.
2015-06-19 16:08:31 -07:00
db_impl_debug.cc
Add Memory Insight support to utilities
2015-11-03 17:52:17 -08:00
db_impl_experimental.cc
Clean up InstallSuperVersion
2015-06-17 12:37:59 -07:00
db_impl_readonly.cc
Remove db_impl_readonly dependency on utilities
2015-07-14 11:32:54 -07:00
db_impl_readonly.h
Override DBImplReadOnly::SyncWAL() to return NotSupported. Previously, calling it caused program abort.
2015-09-25 21:25:30 -07:00
db_impl.cc
added public api to schedule flush/compaction, code to prevent race with db::open
2015-12-03 22:59:44 -08:00
db_impl.h
added public api to schedule flush/compaction, code to prevent race with db::open
2015-12-03 22:59:44 -08:00
db_inplace_update_test.cc
Clean up dependency: Move db_test_util.* to db directory
2015-10-12 13:05:42 -07:00
db_iter_test.cc
No need to #ifdef test only code on windows
2015-10-22 15:15:37 -07:00
db_iter.cc
Revert previous behavior of internal_key_skipped_count
2015-11-30 21:55:05 -08:00
db_iter.h
Prefix-based iterating only shows keys in prefix
2015-11-05 13:24:05 -08:00
db_log_iter_test.cc
No need to #ifdef test only code on windows
2015-10-22 15:15:37 -07:00
db_table_properties_test.cc
Avoid empty ranges vector with subsequent zero element access
2015-12-02 14:50:33 -08:00
db_tailing_iter_test.cc
Reuse file iterators in tailing iterator when memtable is flushed
2015-11-13 15:50:59 -08:00
db_test_util.cc
Fix DBTest.SuggestCompactRangeTest for disable jemalloc case
2015-11-30 16:40:47 -08:00
db_test_util.h
Fix CLANG build
2015-11-30 20:02:13 -08:00
db_test.cc
added public api to schedule flush/compaction, code to prevent race with db::open
2015-12-03 22:59:44 -08:00
db_universal_compaction_test.cc
UniversalCompactionPicker::PickCompaction(): avoid to form compactions if there is no file
2015-11-16 10:32:45 -08:00
db_wal_test.cc
No need to #ifdef test only code on windows
2015-10-22 15:15:37 -07:00
dbformat_test.cc
Avoid manipulating const char* arrays
2015-07-14 00:21:41 -07:00
dbformat.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
dbformat.h
key_ cannot become nullptr, so no check is needed for that
2015-09-18 20:15:20 +02:00
deletefile_test.cc
Improved FileExists API
2015-07-20 17:20:40 -07:00
event_helpers.cc
Passing table properties to compaction callback
2015-10-09 18:10:55 -07:00
event_helpers.h
Add EventListener::OnTableFileDeletion()
2015-06-03 19:57:01 -07:00
experimental.cc
Implement DB::PromoteL0 method
2015-04-23 12:10:36 -07:00
fault_injection_test.cc
No need to #ifdef test only code on windows
2015-10-22 15:15:37 -07:00
file_indexer_test.cc
Fix possible SIGSEGV in CompactRange (github issue #596)
2015-04-29 10:52:31 -07:00
file_indexer.cc
Fix possible SIGSEGV in CompactRange (github issue #596)
2015-04-29 10:52:31 -07:00
file_indexer.h
Fix public API dependency on internal codes and dependency on MAX_INT32
2015-07-11 10:32:11 -07:00
filename_test.cc
rocksdb: switch to gtest
2015-03-17 14:08:00 -07:00
filename.cc
Enable RocksDB to persist Options file.
2015-11-10 22:58:01 -08:00
filename.h
Enable RocksDB to persist Options file.
2015-11-10 22:58:01 -08:00
flush_job_test.cc
log_writer: pass log number and whether recycling is enabled to ctor
2015-10-18 21:24:32 -04:00
flush_job.cc
Seperate InternalIterator from Iterator
2015-10-13 15:32:13 -07:00
flush_job.h
Seperate InternalIterator from Iterator
2015-10-13 15:32:13 -07:00
flush_scheduler.cc
Don't return (or dereference) dangling pointer
2014-10-02 14:33:16 -07:00
flush_scheduler.h
Fix data race #1
2015-01-26 11:48:07 -08:00
forward_iterator_bench.cc
Block forward_iterator_bench under MAC and Windows
2015-11-17 11:51:37 -08:00
forward_iterator.cc
Fix forward_iterator allocation of vector.
2015-11-17 10:27:51 -08:00
forward_iterator.h
Reuse file iterators in tailing iterator when memtable is flushed
2015-11-13 15:50:59 -08:00
inlineskiplist_test.cc
InlineSkipList - part 2/3
2015-11-24 14:30:56 -08:00
inlineskiplist.h
InlineSkipList part 3/3 - new skiplist type that colocates key and node
2015-11-24 15:16:02 -08:00
internal_stats.cc
Allow GetProperty to report the number of currently running flushes / compactions.
2015-10-17 00:16:36 -07:00
internal_stats.h
Allow GetProperty to report the number of currently running flushes / compactions.
2015-10-17 00:16:36 -07:00
job_context.h
fixed leaking log::Writers
2015-07-07 12:10:10 -07:00
listener_test.cc
Lint everything
2015-11-16 12:56:21 -08:00
log_format.h
log_{reader,write}: recyclable record format
2015-10-19 17:24:05 -04:00
log_reader.cc
log_{reader,write}: recyclable record format
2015-10-19 17:24:05 -04:00
log_reader.h
log_{reader,write}: recyclable record format
2015-10-19 17:24:05 -04:00
log_test.cc
log_{reader,write}: recyclable record format
2015-10-19 17:24:05 -04:00
log_writer.cc
log_{reader,write}: recyclable record format
2015-10-19 17:24:05 -04:00
log_writer.h
log_{reader,write}: recyclable record format
2015-10-19 17:24:05 -04:00
managed_iterator.cc
Windows Port from Microsoft
2015-07-01 16:13:56 -07:00
managed_iterator.h
Fixed xfunc related compile errors in ROCKSDB_LITE
2015-04-09 21:05:18 -07:00
manual_compaction_test.cc
Move manual_compaction_test.cc from util to db
2015-10-14 11:06:27 -07:00
memtable_allocator.cc
Enforce write buffer memory limit across column families
2014-12-02 12:09:20 -08:00
memtable_allocator.h
Enforce write buffer memory limit across column families
2014-12-02 12:09:20 -08:00
memtable_list_test.cc
Removing duplicate code
2015-08-05 07:33:27 -07:00
memtable_list.cc
Seperate InternalIterator from Iterator
2015-10-13 15:32:13 -07:00
memtable_list.h
Seperate InternalIterator from Iterator
2015-10-13 15:32:13 -07:00
memtable.cc
Seperate InternalIterator from Iterator
2015-10-13 15:32:13 -07:00
memtable.h
Seperate InternalIterator from Iterator
2015-10-13 15:32:13 -07:00
memtablerep_bench.cc
Merge pull request #811 from OverlordQ/unused-variable-warning
2015-11-02 12:44:27 -08:00
merge_context.h
API to fetch from both a WriteBatchWithIndex and the db
2015-05-11 14:51:51 -07:00
merge_helper_test.cc
Compaction filter on merge operands
2015-10-07 09:30:03 -07:00
merge_helper.cc
Seperate InternalIterator from Iterator
2015-10-13 15:32:13 -07:00
merge_helper.h
Seperate InternalIterator from Iterator
2015-10-13 15:32:13 -07:00
merge_operator.cc
Call merge operators with empty values
2015-06-26 11:35:46 -07:00
merge_test.cc
Make merge_test runnable in ROCKSDB_LITE
2015-07-20 11:17:52 -07:00
options_file_test.cc
Fixed build failure of RocksDBLite test on options_file_test.cc
2015-11-10 23:23:36 -08:00
perf_context_test.cc
Make perf_context.db_mutex_lock_nanos and db_condition_wait_nanos only measures DB Mutex
2015-10-13 10:41:48 -07:00
plain_table_db_test.cc
PlainTableReader to support non-mmap mode
2015-09-23 11:41:07 -07:00
prefix_test.cc
Prefix-based iterating only shows keys in prefix
2015-11-05 13:24:05 -08:00
repair.cc
log_reader: pass log_number and optional info_log to ctor
2015-10-18 21:24:32 -04:00
skiplist_test.cc
rocksdb: switch to gtest
2015-03-17 14:08:00 -07:00
skiplist.h
Switch to thread-local random for skiplist
2015-11-09 19:25:22 -08:00
slice.cc
Create an abstract interface for write batches
2015-03-17 19:23:08 -07:00
snapshot_impl.cc
simple ManagedSnapshot wrapper
2015-08-06 17:59:05 -07:00
snapshot_impl.h
simple ManagedSnapshot wrapper
2015-08-06 17:59:05 -07:00
table_cache.cc
Seperate InternalIterator from Iterator
2015-10-13 15:32:13 -07:00
table_cache.h
Seperate InternalIterator from Iterator
2015-10-13 15:32:13 -07:00
table_properties_collector_test.cc
Pass column family ID to table property collector
2015-10-09 14:36:51 -07:00
table_properties_collector.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
table_properties_collector.h
Pass column family ID to table property collector
2015-10-09 14:36:51 -07:00
transaction_log_impl.cc
log_reader: pass log_number and optional info_log to ctor
2015-10-18 21:24:32 -04:00
transaction_log_impl.h
Move rate_limiter, write buffering, most perf context instrumentation and most random kill out of Env
2015-07-17 16:58:18 -07:00
version_builder_test.cc
Add a mode to always pick the oldest file to compact for each level
2015-09-21 17:21:59 -07:00
version_builder.cc
Update DB::AddFile() to have less restrictions
2015-10-30 16:38:10 -07:00
version_builder.h
Log more information for the add file with overlapping range failure
2015-10-19 17:31:13 -07:00
version_edit_test.cc
New Manifest format to allow customized fields in NewFile.
2015-10-08 15:51:45 -07:00
version_edit.cc
New Manifest format to allow customized fields in NewFile.
2015-10-08 15:51:45 -07:00
version_edit.h
New Manifest format to allow customized fields in NewFile.
2015-10-08 15:51:45 -07:00
version_set_test.cc
Report live data size estimate
2015-07-21 21:33:20 -07:00
version_set.cc
Merge pull request #746 from ceph/wip-recycle
2015-10-26 15:01:28 -07:00
version_set.h
Log more information for the add file with overlapping range failure
2015-10-19 17:31:13 -07:00
wal_manager_test.cc
log_writer: pass log number and whether recycling is enabled to ctor
2015-10-18 21:24:32 -04:00
wal_manager.cc
log_reader: pass log_number and optional info_log to ctor
2015-10-18 21:24:32 -04:00
wal_manager.h
Fix -Wnon-virtual-dtor errors
2014-11-10 17:39:38 -05:00
write_batch_base.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
write_batch_internal.h
Don't merge WriteBatch-es if WAL is disabled
2015-11-12 10:50:38 -08:00
write_batch_test.cc
track WriteBatch contents
2015-11-10 16:56:06 -08:00
write_batch.cc
Don't merge WriteBatch-es if WAL is disabled
2015-11-12 10:50:38 -08:00
write_callback_test.cc
Fix compile for write_callback_test in ROCKSDB_LITE
2015-07-20 10:54:15 -07:00
write_callback.h
Optimistic Transactions
2015-05-29 14:36:35 -07:00
write_controller_test.cc
Slow down writes by bytes written
2015-06-11 20:42:18 -07:00
write_controller.cc
Slow down writes by bytes written
2015-06-11 20:42:18 -07:00
write_controller.h
Slow down writes by bytes written
2015-06-11 20:42:18 -07:00
write_thread.cc
incorrect batch group size computation for write throttling
2015-11-06 09:23:55 -08:00
write_thread.h
reduce db mutex contention for write batch groups
2015-08-14 10:55:43 -07:00
writebuffer.h
Enforce write buffer memory limit across column families
2014-12-02 12:09:20 -08:00