4f5a687254
Summary: This pull request solves the jlong overflow problem on 32-Bit machines as described in https://github.com/facebook/rocksdb/issues/278: 1. There is a new org.rocksdb.test.PlatformRandomHelper to assist in getting random values. For 32 Bit the getLong method is overriden by xpromaches code above. For 64 Bit it behaves as is. 2. The detection should be cross-platform (Windows is supported though it is not ported completely yet). 3. Every JNI method which sets jlong values must check if the value fits into size_t. If it overflows size_t a InvalidArgument Status object will be returned. If its ok a OK Status will be returned. 4. Setters which have this check will throw a RocksDBException if its no OK Status. Additionally some other parts of code were corrected using the wrong type casts. Test Plan: make rocksdbjava make jtest Differential Revision: https://reviews.facebook.net/D24531
145 lines
4.5 KiB
C++
145 lines
4.5 KiB
C++
// Copyright (c) 2014, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
// This file implements the "bridge" between Java and C++ and enables
|
|
// calling c++ rocksdb::RestoreBackupableDB and rocksdb::RestoreOptions methods
|
|
// from Java side.
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <jni.h>
|
|
#include <string>
|
|
|
|
#include "include/org_rocksdb_RestoreOptions.h"
|
|
#include "include/org_rocksdb_RestoreBackupableDB.h"
|
|
#include "rocksjni/portal.h"
|
|
#include "rocksdb/utilities/backupable_db.h"
|
|
/*
|
|
* Class: org_rocksdb_RestoreOptions
|
|
* Method: newRestoreOptions
|
|
* Signature: (Z)J
|
|
*/
|
|
jlong Java_org_rocksdb_RestoreOptions_newRestoreOptions(JNIEnv* env,
|
|
jobject jobj, jboolean keep_log_files) {
|
|
auto ropt = new rocksdb::RestoreOptions(keep_log_files);
|
|
return reinterpret_cast<jlong>(ropt);
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RestoreOptions
|
|
* Method: dispose
|
|
* Signature: (J)V
|
|
*/
|
|
void Java_org_rocksdb_RestoreOptions_dispose(JNIEnv* env, jobject jobj,
|
|
jlong jhandle) {
|
|
auto ropt = reinterpret_cast<rocksdb::RestoreOptions*>(jhandle);
|
|
assert(ropt);
|
|
delete ropt;
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RestoreBackupableDB
|
|
* Method: newRestoreBackupableDB
|
|
* Signature: (J)J
|
|
*/
|
|
jlong Java_org_rocksdb_RestoreBackupableDB_newRestoreBackupableDB(JNIEnv* env,
|
|
jobject jobj, jlong jopt_handle) {
|
|
auto opt = reinterpret_cast<rocksdb::BackupableDBOptions*>(jopt_handle);
|
|
auto rdb = new rocksdb::RestoreBackupableDB(rocksdb::Env::Default(), *opt);
|
|
return reinterpret_cast<jlong>(rdb);
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RestoreBackupableDB
|
|
* Method: restoreDBFromBackup0
|
|
* Signature: (JJLjava/lang/String;Ljava/lang/String;J)V
|
|
*/
|
|
void Java_org_rocksdb_RestoreBackupableDB_restoreDBFromBackup0(JNIEnv* env,
|
|
jobject jobj, jlong jhandle, jlong jbackup_id, jstring jdb_dir,
|
|
jstring jwal_dir, jlong jopt_handle) {
|
|
auto opt = reinterpret_cast<rocksdb::RestoreOptions*>(jopt_handle);
|
|
|
|
const char* cdb_dir = env->GetStringUTFChars(jdb_dir, 0);
|
|
const char* cwal_dir = env->GetStringUTFChars(jwal_dir, 0);
|
|
|
|
auto rdb = reinterpret_cast<rocksdb::RestoreBackupableDB*>(jhandle);
|
|
rocksdb::Status s =
|
|
rdb->RestoreDBFromBackup(jbackup_id, cdb_dir, cwal_dir, *opt);
|
|
|
|
env->ReleaseStringUTFChars(jdb_dir, cdb_dir);
|
|
env->ReleaseStringUTFChars(jwal_dir, cwal_dir);
|
|
|
|
if (!s.ok()) {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RestoreBackupableDB
|
|
* Method: restoreDBFromLatestBackup0
|
|
* Signature: (JLjava/lang/String;Ljava/lang/String;J)V
|
|
*/
|
|
void Java_org_rocksdb_RestoreBackupableDB_restoreDBFromLatestBackup0(
|
|
JNIEnv* env, jobject jobj, jlong jhandle, jstring jdb_dir, jstring jwal_dir,
|
|
jlong jopt_handle) {
|
|
auto opt = reinterpret_cast<rocksdb::RestoreOptions*>(jopt_handle);
|
|
|
|
const char* cdb_dir = env->GetStringUTFChars(jdb_dir, 0);
|
|
const char* cwal_dir = env->GetStringUTFChars(jwal_dir, 0);
|
|
|
|
auto rdb = reinterpret_cast<rocksdb::RestoreBackupableDB*>(jhandle);
|
|
rocksdb::Status s =
|
|
rdb->RestoreDBFromLatestBackup(cdb_dir, cwal_dir, *opt);
|
|
|
|
env->ReleaseStringUTFChars(jdb_dir, cdb_dir);
|
|
env->ReleaseStringUTFChars(jwal_dir, cwal_dir);
|
|
|
|
if (!s.ok()) {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RestoreBackupableDB
|
|
* Method: purgeOldBackups0
|
|
* Signature: (JI)V
|
|
*/
|
|
void Java_org_rocksdb_RestoreBackupableDB_purgeOldBackups0(JNIEnv* env,
|
|
jobject jobj, jlong jhandle, jint jnum_backups_to_keep) {
|
|
auto rdb = reinterpret_cast<rocksdb::RestoreBackupableDB*>(jhandle);
|
|
rocksdb::Status s = rdb->PurgeOldBackups(jnum_backups_to_keep);
|
|
|
|
if (!s.ok()) {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RestoreBackupableDB
|
|
* Method: deleteBackup0
|
|
* Signature: (JJ)V
|
|
*/
|
|
void Java_org_rocksdb_RestoreBackupableDB_deleteBackup0(JNIEnv* env,
|
|
jobject jobj, jlong jhandle, jlong jbackup_id) {
|
|
auto rdb = reinterpret_cast<rocksdb::RestoreBackupableDB*>(jhandle);
|
|
rocksdb::Status s = rdb->DeleteBackup(jbackup_id);
|
|
|
|
if (!s.ok()) {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_RestoreBackupableDB
|
|
* Method: dispose
|
|
* Signature: (J)V
|
|
*/
|
|
void Java_org_rocksdb_RestoreBackupableDB_dispose(JNIEnv* env, jobject jobj,
|
|
jlong jhandle) {
|
|
auto ropt = reinterpret_cast<rocksdb::RestoreBackupableDB*>(jhandle);
|
|
assert(ropt);
|
|
delete ropt;
|
|
}
|