andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/db
History
Igor Canadi eb5b637fb0 Fix condition for bottommost level 
Summary:
The function GetBoundaryKeys() returns the smallest key from the first file and largest key from the last file. This is good for any level >0, but it's not correct for level 0. In level 0, files can overlap, so we need to check all files for boundary keys. This bug can cause wrong value for bottommost_level in compaction (value of true, although correct is false), which means we can set sequence numbers to 0 even if the key is not the oldest one in the database.

Herman reported corruption while testing MyRocks. Fortunately, the patch that added the bug was not released yet.

Test Plan: added a new test to compaction_picker_test.

Reviewers: hermanlee4, sdong

Reviewed By: sdong

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D48201
2015-10-05 17:40:18 -07:00
..
builder.cc
Fixed a bug which causes rocksdb.flush.write.bytes stat is always zero
2015-09-25 13:34:49 -07:00
builder.h
Smarter purging during flush
2015-08-24 11:11:12 -07:00
c_test.c
Deprecate CompactionFilterV2
2015-07-17 18:59:11 +02:00
c.cc
Don't let flushes preempt compactions
2015-07-17 12:02:52 -07:00
column_family_test.cc
Fix Windows constexpr issue and '#ifdef' column_family_test in Release.
2015-09-21 16:21:01 -07:00
column_family.cc
Add options.hard_pending_compaction_bytes_limit to stop writes if compaction lagging behind
2015-09-14 12:51:16 -07:00
column_family.h
Total SST files size DB Property
2015-08-20 11:47:19 -07:00
compact_files_test.cc
Improved FileExists API
2015-07-20 17:20:40 -07:00
compacted_db_impl.cc
Remove db_impl_readonly dependency on utilities
2015-07-14 11:32:54 -07:00
compacted_db_impl.h
Remove db_impl_readonly dependency on utilities
2015-07-14 11:32:54 -07:00
compaction_iterator_test.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
compaction_iterator.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
compaction_iterator.h
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
compaction_job_stats_test.cc
Make CompactionJobStatsTest.UniversalCompactionTest more robust
2015-09-28 13:55:53 -07:00
compaction_job_test.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
compaction_job.cc
Add compaction time to log output
2015-09-15 17:11:44 -07:00
compaction_job.h
Refactored common code of Builder/CompactionJob out into a CompactionIterator
2015-09-10 14:35:25 -07:00
compaction_picker_test.cc
Fix condition for bottommost level
2015-10-05 17:40:18 -07:00
compaction_picker.cc
Add a mode to always pick the oldest file to compact for each level
2015-09-21 17:21:59 -07:00
compaction_picker.h
Add counters for L0 stall while L0-L1 compaction is taking place
2015-09-14 11:03:37 -07:00
compaction.cc
Fix condition for bottommost level
2015-10-05 17:40:18 -07:00
compaction.h
Improving condition for bottommost level during compaction
2015-09-16 17:47:50 -07:00
comparator_db_test.cc
Unified maps with Comparator for sorting, other cleanup
2015-09-02 13:58:22 -07:00
convenience.cc
move convenience.h out of utilities
2015-07-15 14:51:51 -07:00
corruption_test.cc
Make corruption_test more robust
2015-10-05 14:46:28 -07:00
cuckoo_table_db_test.cc
Block cuckoo table tests in ROCKSDB_LITE
2015-07-20 10:50:46 -07:00
db_bench.cc
Add max_file_opening_threads to db_bench
2015-09-30 09:51:31 -07:00
db_compaction_filter_test.cc
Initialize variable to avoid warning
2015-09-11 12:07:54 -07:00
db_compaction_test.cc
[minor] Reuse SleepingBackgroundTask
2015-09-25 10:29:44 -07:00
db_dynamic_level_test.cc
Move DynamicLevel related db-tests to db_dynamic_level_test.cc
2015-07-13 19:00:30 -07:00
db_filesnapshot.cc
Add wal files to Checkpoint for multiple column families.
2015-06-19 16:08:31 -07:00
db_impl_debug.cc
reduce db mutex contention for write batch groups
2015-08-14 10:55:43 -07:00
db_impl_experimental.cc
Clean up InstallSuperVersion
2015-06-17 12:37:59 -07:00
db_impl_readonly.cc
Remove db_impl_readonly dependency on utilities
2015-07-14 11:32:54 -07:00
db_impl_readonly.h
Override DBImplReadOnly::SyncWAL() to return NotSupported. Previously, calling it caused program abort.
2015-09-25 21:25:30 -07:00
db_impl.cc
Add APIs PauseBackgroundWork() and ContinueBackgroundWork()
2015-10-02 13:17:34 -07:00
db_impl.h
Add APIs PauseBackgroundWork() and ContinueBackgroundWork()
2015-10-02 13:17:34 -07:00
db_inplace_update_test.cc
Move in-place-update related tests from db_test.cc to db_inplace_update_test.cc
2015-07-20 16:05:28 -07:00
db_iter_test.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
db_iter.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
db_iter.h
reduce references to cfd->options() in DBImpl
2014-09-08 15:04:34 -07:00
db_log_iter_test.cc
Make TransactionLogIterator related tests from db_test.cc to db_log_iter_test.cc
2015-07-14 16:08:21 -07:00
db_tailing_iter_test.cc
Fix case when forward iterator misses a new update
2015-09-04 14:28:45 -07:00
db_test.cc
Fix valgrind - Initialize done variable
2015-10-05 10:10:11 -07:00
db_universal_compaction_test.cc
Arena usage to be calculated using malloc_usable_size()
2015-08-31 09:39:27 -07:00
db_wal_test.cc
Add two unit tests for SyncWAL()
2015-08-05 14:27:02 -07:00
dbformat_test.cc
Avoid manipulating const char* arrays
2015-07-14 00:21:41 -07:00
dbformat.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
dbformat.h
key_ cannot become nullptr, so no check is needed for that
2015-09-18 20:15:20 +02:00
deletefile_test.cc
Improved FileExists API
2015-07-20 17:20:40 -07:00
event_helpers.cc
Add EventListener::OnTableFileDeletion()
2015-06-03 19:57:01 -07:00
event_helpers.h
Add EventListener::OnTableFileDeletion()
2015-06-03 19:57:01 -07:00
experimental.cc
Implement DB::PromoteL0 method
2015-04-23 12:10:36 -07:00
fault_injection_test.cc
[minor] Reuse SleepingBackgroundTask
2015-09-25 10:29:44 -07:00
file_indexer_test.cc
Fix possible SIGSEGV in CompactRange (github issue #596)
2015-04-29 10:52:31 -07:00
file_indexer.cc
Fix possible SIGSEGV in CompactRange (github issue #596)
2015-04-29 10:52:31 -07:00
file_indexer.h
Fix public API dependency on internal codes and dependency on MAX_INT32
2015-07-11 10:32:11 -07:00
filename_test.cc
rocksdb: switch to gtest
2015-03-17 14:08:00 -07:00
filename.cc
Fixed old lint errors in db/filename.cc
2015-09-23 12:39:16 -07:00
filename.h
Fixed old lint errors in db/filename.h
2015-09-23 12:22:44 -07:00
flush_job_test.cc
Unified maps with Comparator for sorting, other cleanup
2015-09-02 13:58:22 -07:00
flush_job.cc
Fixed a bug which causes rocksdb.flush.write.bytes stat is always zero
2015-09-25 13:34:49 -07:00
flush_job.h
Smarter purging during flush
2015-08-24 11:11:12 -07:00
flush_scheduler.cc
Don't return (or dereference) dangling pointer
2014-10-02 14:33:16 -07:00
flush_scheduler.h
Fix data race #1
2015-01-26 11:48:07 -08:00
forward_iterator.cc
Relaxed assert in forward iterator
2015-09-08 17:15:11 -07:00
forward_iterator.h
Fix case when forward iterator misses a new update
2015-09-04 14:28:45 -07:00
internal_stats.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
internal_stats.h
Add options.hard_pending_compaction_bytes_limit to stop writes if compaction lagging behind
2015-09-14 12:51:16 -07:00
job_context.h
fixed leaking log::Writers
2015-07-07 12:10:10 -07:00
listener_test.cc
Fix listener_test when using ROCKSDB_MALLOC_USABLE_SIZE
2015-08-31 23:11:12 -07:00
log_format.h
Some minor refactoring on the code
2014-01-02 16:32:31 -08:00
log_reader.cc
Move rate_limiter, write buffering, most perf context instrumentation and most random kill out of Env
2015-07-17 16:58:18 -07:00
log_reader.h
Move rate_limiter, write buffering, most perf context instrumentation and most random kill out of Env
2015-07-17 16:58:18 -07:00
log_test.cc
Removing duplicate code
2015-08-05 07:33:27 -07:00
log_writer.cc
Move rate_limiter, write buffering, most perf context instrumentation and most random kill out of Env
2015-07-17 16:58:18 -07:00
log_writer.h
Unified maps with Comparator for sorting, other cleanup
2015-09-02 13:58:22 -07:00
managed_iterator.cc
Windows Port from Microsoft
2015-07-01 16:13:56 -07:00
managed_iterator.h
Fixed xfunc related compile errors in ROCKSDB_LITE
2015-04-09 21:05:18 -07:00
memtable_allocator.cc
Enforce write buffer memory limit across column families
2014-12-02 12:09:20 -08:00
memtable_allocator.h
Enforce write buffer memory limit across column families
2014-12-02 12:09:20 -08:00
memtable_list_test.cc
Removing duplicate code
2015-08-05 07:33:27 -07:00
memtable_list.cc
Fixing race condition in DBTest.DynamicMemtableOptions
2015-08-24 17:04:18 -07:00
memtable_list.h
Introduce GetIntProperty("rocksdb.size-all-mem-tables")
2015-08-19 13:32:09 -07:00
memtable.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
memtable.h
Allow GetApproximateSize() to include mem table size if it is skip list memtable
2015-06-16 18:13:23 -07:00
memtablerep_bench.cc
Added Equal method to Comparator interface
2015-09-08 15:30:49 -07:00
merge_context.h
API to fetch from both a WriteBatchWithIndex and the db
2015-05-11 14:51:51 -07:00
merge_helper_test.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
merge_helper.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
merge_helper.h
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
merge_operator.cc
Call merge operators with empty values
2015-06-26 11:35:46 -07:00
merge_test.cc
Make merge_test runnable in ROCKSDB_LITE
2015-07-20 11:17:52 -07:00
perf_context_test.cc
Makefile minor cleanup
2015-03-30 16:05:35 -04:00
plain_table_db_test.cc
PlainTableReader to support non-mmap mode
2015-09-23 11:41:07 -07:00
prefix_test.cc
Skipped tests shouldn't be failures
2015-09-15 18:10:36 -07:00
repair.cc
Smarter purging during flush
2015-08-24 11:11:12 -07:00
skiplist_test.cc
rocksdb: switch to gtest
2015-03-17 14:08:00 -07:00
skiplist.h
reduce comparisons by skiplist
2015-08-11 11:25:22 -07:00
slice.cc
Create an abstract interface for write batches
2015-03-17 19:23:08 -07:00
snapshot_impl.cc
simple ManagedSnapshot wrapper
2015-08-06 17:59:05 -07:00
snapshot_impl.h
simple ManagedSnapshot wrapper
2015-08-06 17:59:05 -07:00
table_cache.cc
Refactor NewTableReader to accept TableReaderOptions
2015-09-11 11:36:33 -07:00
table_cache.h
ReadaheadRandomAccessFile -- userspace readahead
2015-08-26 15:25:59 -07:00
table_properties_collector_test.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
table_properties_collector.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
table_properties_collector.h
Add experimental DB::AddFile() to plug sst files into empty DB
2015-09-23 12:42:43 -07:00
transaction_log_impl.cc
Move rate_limiter, write buffering, most perf context instrumentation and most random kill out of Env
2015-07-17 16:58:18 -07:00
transaction_log_impl.h
Move rate_limiter, write buffering, most perf context instrumentation and most random kill out of Env
2015-07-17 16:58:18 -07:00
version_builder_test.cc
Add a mode to always pick the oldest file to compact for each level
2015-09-21 17:21:59 -07:00
version_builder.cc
Bug fix: table readers created by TableCache::Get() doesn't have latency histogram reported
2015-09-02 12:57:07 -07:00
version_builder.h
Bug fix: table readers created by TableCache::Get() doesn't have latency histogram reported
2015-09-02 12:57:07 -07:00
version_edit_test.cc
Add TablePropertiesCollector::NeedCompact() to suggest DB to further compact output files
2015-06-05 20:18:21 -07:00
version_edit.cc
Added JSON manifest dump option to ldb command
2015-07-17 10:07:40 -07:00
version_edit.h
Refactored common code of Builder/CompactionJob out into a CompactionIterator
2015-09-10 14:35:25 -07:00
version_set_test.cc
Report live data size estimate
2015-07-21 21:33:20 -07:00
version_set.cc
Add a mode to always pick the oldest file to compact for each level
2015-09-21 17:21:59 -07:00
version_set.h
Add a mode to always pick the oldest file to compact for each level
2015-09-21 17:21:59 -07:00
wal_manager_test.cc
Skip unsupported tests in ROCKSDB_LITE
2015-07-20 11:24:54 -07:00
wal_manager.cc
Improved FileExists API
2015-07-20 17:20:40 -07:00
wal_manager.h
Fix -Wnon-virtual-dtor errors
2014-11-10 17:39:38 -05:00
write_batch_base.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
write_batch_internal.h
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
write_batch_test.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
write_batch.cc
Support for SingleDelete()
2015-09-17 11:42:56 -07:00
write_callback_test.cc
Fix compile for write_callback_test in ROCKSDB_LITE
2015-07-20 10:54:15 -07:00
write_callback.h
Optimistic Transactions
2015-05-29 14:36:35 -07:00
write_controller_test.cc
Slow down writes by bytes written
2015-06-11 20:42:18 -07:00
write_controller.cc
Slow down writes by bytes written
2015-06-11 20:42:18 -07:00
write_controller.h
Slow down writes by bytes written
2015-06-11 20:42:18 -07:00
write_thread.cc
reduce db mutex contention for write batch groups
2015-08-14 10:55:43 -07:00
write_thread.h
reduce db mutex contention for write batch groups
2015-08-14 10:55:43 -07:00
writebuffer.h
Enforce write buffer memory limit across column families
2014-12-02 12:09:20 -08:00