35af0433cf
Summary: Forgot to re-test crash test after adding read-only filesystem enforcement to https://github.com/facebook/rocksdb/issues/8142. The problem is ReadOnlyFileSystem would reject CreateDirIfMissing whenever DBOptions::create_if_missing=true. The fix that is better for users is to allow CreateDirIfMissing in ReadOnlyFileSystem if the directory exists, so that they don't cause a failure on using create_if_missing with opening backups as read-only DBs. Added this option test to the unit test (in addition to being in the crash test). Also fixed a couple of lints. And some better messaging from 'make format' so that when you run it with uncommitted changes, it's clear that it's only checking the uncommitted changes. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8161 Test Plan: local blackbox_crash_test with amplified backup_one_in Reviewed By: ajkr Differential Revision: D27614409 Pulled By: pdillinger fbshipit-source-id: 63ccb626c7e34c200d61c6bca2a8f60da9015179
105 lines
3.8 KiB
C++
105 lines
3.8 KiB
C++
// Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#ifndef ROCKSDB_LITE
|
|
|
|
#include "rocksdb/file_system.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// A FileSystem wrapper that only allows read-only operation.
|
|
//
|
|
// This class has not been fully analyzed for providing strong security
|
|
// guarantees.
|
|
class ReadOnlyFileSystem : public FileSystemWrapper {
|
|
static inline IOStatus FailReadOnly() {
|
|
IOStatus s = IOStatus::IOError("Attempted write to ReadOnlyFileSystem");
|
|
assert(s.GetRetryable() == false);
|
|
return s;
|
|
}
|
|
|
|
public:
|
|
explicit ReadOnlyFileSystem(const std::shared_ptr<FileSystem>& base)
|
|
: FileSystemWrapper(base) {}
|
|
|
|
IOStatus NewWritableFile(const std::string& /*fname*/,
|
|
const FileOptions& /*options*/,
|
|
std::unique_ptr<FSWritableFile>* /*result*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus ReuseWritableFile(const std::string& /*fname*/,
|
|
const std::string& /*old_fname*/,
|
|
const FileOptions& /*options*/,
|
|
std::unique_ptr<FSWritableFile>* /*result*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus NewRandomRWFile(const std::string& /*fname*/,
|
|
const FileOptions& /*options*/,
|
|
std::unique_ptr<FSRandomRWFile>* /*result*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus NewDirectory(const std::string& /*dir*/,
|
|
const IOOptions& /*options*/,
|
|
std::unique_ptr<FSDirectory>* /*result*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus DeleteFile(const std::string& /*fname*/,
|
|
const IOOptions& /*options*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus CreateDir(const std::string& /*dirname*/,
|
|
const IOOptions& /*options*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus CreateDirIfMissing(const std::string& dirname,
|
|
const IOOptions& options,
|
|
IODebugContext* dbg) override {
|
|
// Allow if dir already exists
|
|
bool is_dir = false;
|
|
IOStatus s = IsDirectory(dirname, options, &is_dir, dbg);
|
|
if (s.ok() && is_dir) {
|
|
return s;
|
|
} else {
|
|
return FailReadOnly();
|
|
}
|
|
}
|
|
IOStatus DeleteDir(const std::string& /*dirname*/,
|
|
const IOOptions& /*options*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus RenameFile(const std::string& /*src*/, const std::string& /*dest*/,
|
|
const IOOptions& /*options*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus LinkFile(const std::string& /*src*/, const std::string& /*dest*/,
|
|
const IOOptions& /*options*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus LockFile(const std::string& /*fname*/, const IOOptions& /*options*/,
|
|
FileLock** /*lock*/, IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
IOStatus NewLogger(const std::string& /*fname*/, const IOOptions& /*options*/,
|
|
std::shared_ptr<Logger>* /*result*/,
|
|
IODebugContext* /*dbg*/) override {
|
|
return FailReadOnly();
|
|
}
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
|
|
#endif // ROCKSDB_LITE
|