andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/util
History
Yanqin Jin f15414b656 Timer should run scheduled function without mutex (#7228) 
Summary:
Timer (defined in timer.h) schedules and runs user-specified fuctions
regularly. Current implementation holds the mutex while running user
function, which will lead to contention and waiting.
To fix, Timer::Run releases mutex before running user function, and
re-acquires it afterwards.
This fix will impact how we can cancel a task. If the task is running,
it is not holding the mutex. The thread calling Cancel() should wait
until the current task finishes.

Test Plan (devserver):
make check
COMPILE_WITH_ASAN=1 make check

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7228

Reviewed By: jay-zhuang

Differential Revision: D23065487

Pulled By: riversand963

fbshipit-source-id: 07cb59741f506d3eb875c8ab90f73437568d3724
2020-08-11 22:37:39 -07:00
..
aligned_buffer.h
Remove memcpy from RandomAccessFileReader::Read in direct IO mode (#6455)
2020-03-06 14:05:12 -08:00
autovector_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
autovector.h
Change autovector to have a reserved size in LITE mode (#6868)
2020-05-21 14:48:10 -07:00
bloom_impl.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
bloom_test.cc
Minimize memory internal fragmentation for Bloom filters (#6427)
2020-06-22 13:32:07 -07:00
build_version.cc.in
Add copyright headers per FB open-source checkup tool. (#5199)
2019-04-18 10:55:01 -07:00
build_version.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
cast_util.h
Replace reinterpret_cast with static_cast_with_check (#7067)
2020-07-02 19:25:41 -07:00
channel.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
coding_test.cc
Fix potential overflow of unsigned type in for loop (#6902)
2020-06-02 15:05:07 -07:00
coding.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
coding.h
Clean up some code related to file checksums (#6861)
2020-05-21 08:12:51 -07:00
compaction_job_stats_impl.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
comparator.cc
Iterator with timestamp (#6255)
2020-03-06 16:24:27 -08:00
compression_context_cache.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
compression_context_cache.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
compression.h
Add tests for compression failure in BlockBasedTableBuilder (#6709)
2020-05-12 09:27:35 -07:00
concurrent_task_limiter_impl.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
concurrent_task_limiter_impl.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
core_local.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
crc32c_arm64.cc
Suppress UBSAN warning in CRC32 ARM (#6827)
2020-05-08 14:14:00 -07:00
crc32c_arm64.h
Apply formatter to recent 200+ commits. (#5830)
2019-09-20 12:04:26 -07:00
crc32c_ppc_asm.S
Remove PATENTS text from a few straggler files (#5326)
2019-05-21 16:22:35 -07:00
crc32c_ppc_constants.h
Remove PATENTS text from a few straggler files (#5326)
2019-05-21 16:22:35 -07:00
crc32c_ppc.c
C file should not include <cinttypes>, it is a C++ header. (#5499)
2019-06-24 16:12:39 -07:00
crc32c_ppc.h
Remove PATENTS text from a few straggler files (#5326)
2019-05-21 16:22:35 -07:00
crc32c_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
crc32c.cc
C++20 compatibility (#6697)
2020-04-20 13:24:25 -07:00
crc32c.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
defer_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
defer.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
duplicate_detector.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
dynamic_bloom_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
dynamic_bloom.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
dynamic_bloom.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
file_checksum_helper.cc
Add NewFileChecksumGenCrc32cFactory to file checksum (#6688)
2020-04-13 19:13:41 -07:00
file_checksum_helper.h
Clean up some code related to file checksums (#6861)
2020-05-21 08:12:51 -07:00
file_reader_writer_test.cc
More Makefile Cleanup (#7097)
2020-07-09 14:35:17 -07:00
filelock_test.cc
filelock_test: add freebsd headers for waitpid (#7010)
2020-06-25 17:25:42 -07:00
filter_bench.cc
Minimize memory internal fragmentation for Bloom filters (#6427)
2020-06-22 13:32:07 -07:00
gflags_compat.h
filter_bench - a prelim tool for SST filter benchmarking (#5825)
2019-10-07 20:10:53 -07:00
hash_map.h
Change HashMap::Insert()'s value to a const reference (#6567)
2020-03-20 14:59:54 -07:00
hash_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
hash.cc
C++20 compatibility (#6697)
2020-04-20 13:24:25 -07:00
hash.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
heap_test.cc
Revert "Update googletest from 1.8.1 to 1.10.0 (#6808)" (#6923)
2020-06-03 15:55:03 -07:00
heap.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
kv_map.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
log_write_bench.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
math.h
Basic MultiGet support for partitioned filters (#6757)
2020-04-28 14:49:34 -07:00
murmurhash.cc
C++20 compatibility (#6697)
2020-04-20 13:24:25 -07:00
murmurhash.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
mutexlock.h
Prevents Table Cache to open same files more times (#6707)
2020-04-21 13:16:31 -07:00
ppc-opcode.h
Remove PATENTS text from a few straggler files (#5326)
2019-05-21 16:22:35 -07:00
random_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
random.cc
More Makefile Cleanup (#7097)
2020-07-09 14:35:17 -07:00
random.h
More Makefile Cleanup (#7097)
2020-07-09 14:35:17 -07:00
rate_limiter_test.cc
Fix+clean up handling of mock sleeps (#7101)
2020-08-11 12:41:30 -07:00
rate_limiter.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
rate_limiter.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
repeatable_thread_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
repeatable_thread.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
set_comparator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
slice_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
slice_transform_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
slice.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
status.cc
Fix status message size assert (#7045)
2020-07-09 18:12:55 -07:00
stderr_logger.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
stop_watch.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
string_util.cc
Add Struct Type to OptionsTypeInfo (#6425)
2020-05-21 10:58:39 -07:00
string_util.h
Add Struct Type to OptionsTypeInfo (#6425)
2020-05-21 10:58:39 -07:00
thread_list_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
thread_local_test.cc
Fix ThreadLocalTest.SequentialReadWriteTest failure when running individually (#6929)
2020-06-04 11:44:09 -07:00
thread_local.cc
Fix typo in ThreadData comment (#7131)
2020-07-15 09:23:23 -07:00
thread_local.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
thread_operation.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
threadpool_imp.cc
Make it able to lower cpu priority to specific level in threadpool (#6969)
2020-06-13 13:25:20 -07:00
threadpool_imp.h
Make it able to lower cpu priority to specific level in threadpool (#6969)
2020-06-13 13:25:20 -07:00
timer_queue_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
timer_queue.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
timer_test.cc
Timer should run scheduled function without mutex (#7228)
2020-08-11 22:37:39 -07:00
timer.h
Timer should run scheduled function without mutex (#7228)
2020-08-11 22:37:39 -07:00
user_comparator_wrapper.h
Separate internal and user key comparators in BlockIter (#6944)
2020-07-07 17:26:16 -07:00
vector_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
work_queue_test.cc
Add pipelined & parallel compression optimization (#6262)
2020-04-01 16:40:18 -07:00
work_queue.h
Revamp cache_bench to resemble a real workload (#6629)
2020-04-03 10:26:49 -07:00
xxh3p.h
Remove XXH3(preview) streaming APIs (#6540)
2020-03-16 17:02:00 -07:00
xxhash.cc
C++20 compatibility (#6697)
2020-04-20 13:24:25 -07:00
xxhash.h
Misc hashing updates / upgrades (#5909)
2019-10-24 17:16:46 -07:00