andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
f1592a06c2
rocksdb/monitoring
History
Andrew Kryczka 508a09fd62 Print histogram count and sum in statistics string 
Summary:
Previously it only printed percentiles, even though our histogram keeps track of count and sum (and more). There have been many times we want to know more than the percentiles. For example, we currently want sum of "rocksdb.compression.times.nanos" and sum of "rocksdb.decompression.times.nanos", which would allow us to know the relative cost of compression vs decompression.

This PR adds count and sum to the string printed by `StatisticsImpl::ToString`. This is a bit risky as there are definitely parsers assuming the old format. I will mention it in HISTORY.md and hope for the best...
Closes https://github.com/facebook/rocksdb/pull/3863

Differential Revision: D8038831

Pulled By: ajkr

fbshipit-source-id: 0465b72e4b0cbf18ef965f4efe402601d16d5b5c
2018-05-21 11:12:47 -07:00
..
file_read_sample.h Change RocksDB License 2017-07-15 16:11:23 -07:00
histogram_test.cc fix inclusive-exclusiveness of histogram ToString 2017-09-01 10:56:34 -07:00
histogram_windowing.cc uint64_t and size_t changes to compile for iOS 2018-03-06 12:43:51 -08:00
histogram_windowing.h fix HistogramWindowingImpl copy-{assignment,constructor} 2017-09-01 11:11:56 -07:00
histogram.cc Print histogram count and sum in statistics string 2018-05-21 11:12:47 -07:00
histogram.h Scale histogram bucket size by constant factor 2017-08-21 17:10:40 -07:00
instrumented_mutex.cc In instrumented mutex, take timing once for both of perf_context and statistics 2018-05-17 12:56:53 -07:00
instrumented_mutex.h Change RocksDB License 2017-07-15 16:11:23 -07:00
iostats_context_imp.h Directly refernce perf_context internally. 2017-09-15 17:15:10 -07:00
iostats_context_test.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
iostats_context.cc Directly refernce perf_context internally. 2017-09-15 17:15:10 -07:00
perf_context_imp.h In instrumented mutex, take timing once for both of perf_context and statistics 2018-05-17 12:56:53 -07:00
perf_context.cc Improve write time breakdown stats 2018-04-23 17:58:54 -07:00
perf_level_imp.h Change RocksDB License 2017-07-15 16:11:23 -07:00
perf_level.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
perf_step_timer.h In instrumented mutex, take timing once for both of perf_context and statistics 2018-05-17 12:56:53 -07:00
statistics_test.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
statistics.cc Print histogram count and sum in statistics string 2018-05-21 11:12:47 -07:00
statistics.h Add a ticker stat for number of keys skipped during iteration 2017-11-20 21:26:37 -08:00
thread_status_impl.cc comment unused parameters to turn on -Wunused-parameter flag 2018-04-12 17:59:16 -07:00
thread_status_updater_debug.cc comment unused parameters to turn on -Wunused-parameter flag 2018-04-12 17:59:16 -07:00
thread_status_updater.cc comment unused parameters to turn on -Wunused-parameter flag 2018-04-12 17:59:16 -07:00
thread_status_updater.h Use RAII instead of pointers in cf_info_map 2017-09-28 14:26:47 -07:00
thread_status_util_debug.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
thread_status_util.cc comment unused parameters to turn on -Wunused-parameter flag 2018-04-12 17:59:16 -07:00
thread_status_util.h Change RocksDB License 2017-07-15 16:11:23 -07:00