Zhongyi Xie d1c9ede195 Fix duplicated file names in PurgeObsoleteFiles (#5603) ... Summary: Currently in `DBImpl::PurgeObsoleteFiles`, the list of candidate files is create through a combination of calling LogFileName using `log_delete_files` and `full_scan_candidate_files`. In full_scan_candidate_files, the filenames look like this {file_name = "074715.log", file_path = "/txlogs/3306"}, but LogFileName produces filenames like this that prepends a slash: {file_name = "/074715.log", file_path = "/txlogs/3306"}, This confuses the dedup step here: bb4178066d/db/db_impl/db_impl_files.cc (L339-L345) Because duplicates still exist, DeleteFile is called on the same file twice, and hits an error on the second try. Error message: Failed to mark /txlogs/3302/764418.log as trash. The root cause is the use of `kDumbDbName` when generating file names, it creates file names like /074715.log. This PR removes the use of `kDumbDbName` and create paths without leading '/' when dbname can be ignored. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5603 Test Plan: make check Differential Revision: D16413203 Pulled By: miasantreble fbshipit-source-id: 6ba8288382c55f7d5e3892d722fc94b57d2e4491		2019-08-01 15:50:05 -07:00
..
db_impl_compaction_flush.cc	Ref and unref cfd before and after calling WaitForFlushMemTables (#5513)	2019-07-01 14:12:02 -07:00
db_impl_debug.cc	Ref and unref cfd before and after calling WaitForFlushMemTables (#5513)	2019-07-01 14:12:02 -07:00
db_impl_experimental.cc	simplify include directive involving inttypes (#5402)	2019-06-06 13:56:07 -07:00
db_impl_files.cc	Fix duplicated file names in PurgeObsoleteFiles (#5603)	2019-08-01 15:50:05 -07:00
db_impl_open.cc	Added log_readahead_size option to control prefetching for Log::Reader (#5592)	2019-07-19 12:00:19 -07:00
db_impl_readonly.cc	Make format	2019-05-31 15:24:43 -07:00
db_impl_readonly.h	Export Import sst files (#5495)	2019-07-17 12:27:14 -07:00
db_impl_secondary.cc	Added log_readahead_size option to control prefetching for Log::Reader (#5592)	2019-07-19 12:00:19 -07:00
db_impl_secondary.h	Override check consistency for DBImplSecondary (#5469)	2019-06-17 15:39:55 -07:00
db_impl_write.cc	Avoid user key copying for Get/Put/Write with user-timestamp (#5502)	2019-07-25 15:27:39 -07:00
db_impl.cc	Improve CPU Efficiency of ApproximateSize (part 2) (#5609)	2019-07-31 08:50:00 -07:00
db_impl.h	Added SizeApproximationOptions to DB::GetApproximateSizes (#5626)	2019-07-25 22:42:30 -07:00
db_secondary_test.cc	Fix a bug caused by secondary not skipping the beginning of new MANIFEST (#5472)	2019-06-18 11:21:37 -07:00