f5bc3b99d5
Summary: It's never too soon to refactor something. The patch splits the recently introduced (`VersionEdit` related) `BlobFileState` into two classes `BlobFileAddition` and `BlobFileGarbage`. The idea is that once blob files are closed, they are immutable, and the only thing that changes is the amount of garbage in them. In the new design, `BlobFileAddition` contains the immutable attributes (currently, the count and total size of all blobs, checksum method, and checksum value), while `BlobFileGarbage` contains the mutable GC-related information elements (count and total size of garbage blobs). This is a better fit for the GC logic and is more consistent with how SST files are handled. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6502 Test Plan: `make check` Differential Revision: D20348352 Pulled By: ltamasi fbshipit-source-id: ff93f0121e80ab15e0e0a6525ba0d6af16a0e008
56 lines
1.7 KiB
C++
56 lines
1.7 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include <cstdint>
|
|
#include <iosfwd>
|
|
#include <string>
|
|
|
|
#include "db/blob_constants.h"
|
|
#include "rocksdb/rocksdb_namespace.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
class JSONWriter;
|
|
class Slice;
|
|
class Status;
|
|
|
|
class BlobFileGarbage {
|
|
public:
|
|
BlobFileGarbage() = default;
|
|
|
|
BlobFileGarbage(uint64_t blob_file_number, uint64_t garbage_blob_count,
|
|
uint64_t garbage_blob_bytes)
|
|
: blob_file_number_(blob_file_number),
|
|
garbage_blob_count_(garbage_blob_count),
|
|
garbage_blob_bytes_(garbage_blob_bytes) {}
|
|
|
|
uint64_t GetBlobFileNumber() const { return blob_file_number_; }
|
|
uint64_t GetGarbageBlobCount() const { return garbage_blob_count_; }
|
|
uint64_t GetGarbageBlobBytes() const { return garbage_blob_bytes_; }
|
|
|
|
void EncodeTo(std::string* output) const;
|
|
Status DecodeFrom(Slice* input);
|
|
|
|
std::string DebugString() const;
|
|
std::string DebugJSON() const;
|
|
|
|
private:
|
|
uint64_t blob_file_number_ = kInvalidBlobFileNumber;
|
|
uint64_t garbage_blob_count_ = 0;
|
|
uint64_t garbage_blob_bytes_ = 0;
|
|
};
|
|
|
|
bool operator==(const BlobFileGarbage& lhs, const BlobFileGarbage& rhs);
|
|
bool operator!=(const BlobFileGarbage& lhs, const BlobFileGarbage& rhs);
|
|
|
|
std::ostream& operator<<(std::ostream& os,
|
|
const BlobFileGarbage& blob_file_garbage);
|
|
JSONWriter& operator<<(JSONWriter& jw,
|
|
const BlobFileGarbage& blob_file_garbage);
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|